Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp795940imn; Tue, 26 Jul 2022 09:28:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vOj7FWuiLpTN8Jy/JklGN1eUYmiYd02BqpdAjKovnKPbTo5HcX3D9q9fjjfitk84e0YqXh X-Received: by 2002:a17:907:6090:b0:72f:3dc3:f0c8 with SMTP id ht16-20020a170907609000b0072f3dc3f0c8mr14188790ejc.539.1658852908594; Tue, 26 Jul 2022 09:28:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658852908; cv=none; d=google.com; s=arc-20160816; b=WudbRQVJfVMyp0XF4r7rJcJOCCJ9TWNZAL64ecqqEbIaOO8HgdbhS7c/nW8c/0JQUG F8sNzl1hGalzraisRhrgnJ04NASJ8lJd+NO23nVX3q5povRTRZfcyAiVgRvDfSH1CiOx YyvYAN38EyZ999rdAH5swSKlr8wEMliaq8plVUqKQHgeV5C8na/zR6BNjwDz7GxnLviJ nJadfoXqPE0IOrDwojYnvWjen6HsSBqfaPCBACNHjJQD2jhCxLUx4IytTDAZgvn2pY9X KTIvc1D/pPznaRYqR9m33QLfLSYW2pyEpPYVEMXZ/rp7S9uNkS7dnsarNxPgJk8erwdu 5Rcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=c+Nzd2+P+EMAfSfgAc/jjEqkPYlTPQ0Q+/aFvnyEr6Q=; b=M/qhNSDO+FRfIW1kmrK7JWulTLxqJF9wkzSuteLjrypcn2tS5Ta1b4eBbfl5oGpjEW oBpFwoWWC/ikxWyCsbwJHq3cWKbISogKD5UMBWErxZ0hVSuzEt/2qaGUL0/HuZgs1uEG IbttkNdfaCdf2yDb1mxynDTQE8iPqomRLUeLlLqIdpmWLYQ2QqteG+/7j4CMbgqKVZrz xS2elY+t64iu9sCyEMaGzbrMMKh/jCiLj8KA2GZIAKKbfzJuvjyyP80Gf7Ku3SB+BrCw gzIxOdOUz4FHBxJto99LStAr6JOGdlMJP0mydxxeEgAqLDcKWPLichit2ZcA+873wCj3 U3ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f39-20020a05640232a700b0043c1802a7b1si4822232eda.588.2022.07.26.09.28.02; Tue, 26 Jul 2022 09:28:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239172AbiGZQ0i (ORCPT + 99 others); Tue, 26 Jul 2022 12:26:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbiGZQ0g (ORCPT ); Tue, 26 Jul 2022 12:26:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 843DB1CFCC; Tue, 26 Jul 2022 09:26:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F456B8188C; Tue, 26 Jul 2022 16:26:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D89C433C1; Tue, 26 Jul 2022 16:26:30 +0000 (UTC) Date: Tue, 26 Jul 2022 12:26:29 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Tao Zhou , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org Subject: Re: [PATCH V7 02/16] rv: Add runtime reactors interface Message-ID: <20220726122629.2a99cb6e@gandalf.local.home> In-Reply-To: <516e8767f20f47b185b7dc0dceb1f1d3abb36dce.1658778484.git.bristot@kernel.org> References: <516e8767f20f47b185b7dc0dceb1f1d3abb36dce.1658778484.git.bristot@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2022 22:11:14 +0200 Daniel Bristot de Oliveira wrote: > +/** > + * reactor_cleanup_monitor - cleanup a monitor reference > + * @mdef: monitor's definition. > + */ > +void reactor_cleanup_monitor(struct rv_monitor_def *mdef) > +{ > + mdef->rdef->counter--; > +} > + Doesn't this require a lock? Also you might want to add a WARN_ONCE() if it goes below zero. -- Steve