Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220726062436.90290-1-zhengqi.arch@bytedance.com> <621fb975-413d-a6b4-8126-0b78d5b60853@redhat.com>
In-Reply-To: <621fb975-413d-a6b4-8126-0b78d5b60853@redhat.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 26 Jul 2022 09:26:38 -0700
Message-ID: <CAHk-=wh_TrgNm6vz7=7CgZppr0UrZ9TwLyb3dgPXyG-w=a8kJQ@mail.gmail.com>
Subject: Re: [PATCH] mm: fix NULL pointer dereference in wp_page_reuse()
To:     David Hildenbrand <david@redhat.com>
Cc:     Qi Zheng <zhengqi.arch@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 26, 2022 at 12:45 AM David Hildenbrand <david@redhat.com> wrote:
>
> >       VM_BUG_ON(!(vmf->flags & FAULT_FLAG_WRITE));
> > -     VM_BUG_ON(PageAnon(page) && !PageAnonExclusive(page));
> > +     VM_BUG_ON(page && PageAnon(page) && !PageAnonExclusive(page));
>
> Indeed, fortunately, only an issue in the VM_BUG_ON statement

Well, at least Fedora ends up enabling CONFIG_DEBUG_VM by default, so
normal people - not just VM people - can definitely see this.

> Reviewed-by: David Hildenbrand <david@redhat.com>

Applied.

                    Linus