Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 19:13:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Peter Suti <peter.suti@streamunlimited.com>,
        Chuansheng Liu <chuansheng.liu@intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: core: set smem_len before
 fb_deferred_io_init call
Message-ID: <20220726161347.GR2338@kadam>
References: <20220726082114.891853-1-peter.suti@streamunlimited.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220726082114.891853-1-peter.suti@streamunlimited.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7yqiM4dBJFAA1/hpwOrp4n1yxBe1s+BIfBTLiSGgjhdN0cejisvdqMjGfSpz?=
 =?us-ascii?Q?BpCvzT3gySbBpVOL0YYUnX/t4excOCYCLMNanD/bq9puc9L/iuPXDx+t3OgK?=
 =?us-ascii?Q?H/t94aMv/998UI1c7NZfegkmLTDOcH9tx1IeuivsIUfUk/dguv8jLm1Uqn+i?=
 =?us-ascii?Q?y+/v6cKHGwhHauCa6rGNsTq4aAS5KyhLcFXpIFrhHIPx+m3L+p9VuA8jlKsi?=
 =?us-ascii?Q?FBkBap644z/TAB8GgAiwcq5SFiKCtJgv1D8itEtvNoh0jQnw9uH7WRntcQwq?=
 =?us-ascii?Q?V48OSyq1DmDkeMxs6UiEjsacO6MXNeCtcVxWMJohCRDpMxr1w32UW5v9vbJ2?=
 =?us-ascii?Q?+7jxV+j23kUiphIgk4Q1jGaOouOEoBYrM+B5hJKSjYLBQB7wpUK0xI2IExOt?=
 =?us-ascii?Q?dQ0U11CNsKrtDlBRVNjgHxwrt/2RVoYM6Geuli3IG4IMzDB8IQvhdnbLhKcV?=
 =?us-ascii?Q?8QsPKe5yvUxsNzAHb+eWCU5mS3bT3eZoLIQA5xnlpji0ehRrrsBTI9ycYVVo?=
 =?us-ascii?Q?eCT6Q8RIBR2yN6bt1bP+1rmvRv7s8wrLsdOfZF9J63o+OBPUyWeVxjNrttSO?=
 =?us-ascii?Q?sWKXA8YS+hnaURt8+fJftyM+G9fAtRjS2+uZxnhaSko/0XkgXNkS3O7kFYj5?=
 =?us-ascii?Q?yZhCIVolFPCvHTN4h8qR5m2Vbj+rsz+soknpFkiOLlE3e4aZx9RjuAFQvaJE?=
 =?us-ascii?Q?2QVEQkowX92ZvllhmtY6D7oGUr2u6U+/l8wIydoIn1ITI3mLpW/NEgPtA7zc?=
 =?us-ascii?Q?Dpdl/Nn+K/N4sWkkbU6iIcXZNipC/Od0JmP9eoR9YYUl6+GvkQWMIolBO+Bd?=
 =?us-ascii?Q?Kb/rXxc31rY0iTty/8Pi/YVGeSvSyM5P/ujFhs+ryhU6B21NPGPBsBaCpch+?=
 =?us-ascii?Q?cYMPTNfeTa57w3bCCosLLQF+RefWtIVtrYm7XR1HcnSKy9Dl87IK3YzO7iJm?=
 =?us-ascii?Q?aqw8fqVOOrVmRYRz2cpYpqa5USSZHLJDlS/NF7XvDwfll08N0Hfee+NDPx/F?=
 =?us-ascii?Q?j9DCsvZt57i+RXSi1a1UuFuq3W33oK82qw7kKYdXwuUOOS89eyyHq4Q0eUv+?=
 =?us-ascii?Q?F08xZU67pX7JBquV3PIOAOmFfjF5too3kpqxuTKcNFIUXx6pPYqJL5hkx6h+?=
 =?us-ascii?Q?KYFSCkksJl7ndaQKrVivmXx9Tt805AKvNOfseuEF1ULFwocn3e4m4bVyw4dd?=
 =?us-ascii?Q?b8Yo5RJznEX7B/+b3nDIrQQuEGbY9udw37GfAf7PYrWJ+v6C+InA8gmyhvzq?=
 =?us-ascii?Q?AsmPtfkb/5CiZshLcSejIlD1XUGft8rQEeKdsFLNwAk2HZf0lr0szTZMl6Xx?=
 =?us-ascii?Q?MiTGsacdaKV8tu+tSEi5CMEOdypdnenkDvQm41wooBUqh2fxlO1/LOIDUvf1?=
 =?us-ascii?Q?ZkjPbIPReDZZzcX6DXumY9sbRJ6H1qvbkyCzwChRhKEsb7Mx+3QwjH8F5c2R?=
 =?us-ascii?Q?4YEOsK/0jXyivBm+q457dAt9v80o2zaLOmLQyiPJenpXlc1BM/9SQqQVcvXn?=
 =?us-ascii?Q?aRmU/p3sXUJ9ZA0cLcly+MrxxHWDZ1gSedPJ0O2pHq556NFjnmjajxYZnx07?=
 =?us-ascii?Q?asBkSbaFfle9jTGoVDWOupbOwiI1ZTFd5PQh2IEBNMa/4cDubDjr711WCnEh?=
 =?us-ascii?Q?4Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9981f1e0-719b-41be-45d3-08da6f21dd55
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:14:07.3521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ue9Ga6sOnhwIYvV1gsK2zPcYduyOorYIlQdFoylj3XLIG/7vQfO2pTBj6YGXetTLL9XeG4iUh77dKea7rEDnNvZZDvTjW4P+E3aeTCrZbMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4479
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_04,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207260063
X-Proofpoint-GUID: vTmx0m2G7k2tWyFn9UNLB-RVA8gAwjyP
X-Proofpoint-ORIG-GUID: vTmx0m2G7k2tWyFn9UNLB-RVA8gAwjyP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the patch.

On Tue, Jul 26, 2022 at 10:21:13AM +0200, Peter Suti wrote:
> fb_deferred_io_init depends on smem_len being filled
> to be able to initialize the virtual page lists since
> commit 856082f021a2 ("fbdev: defio: fix the pagelist corruption")
> 

This code has changed since then so the patch needs to be updated.
The patch is still necessary but the bug will look different now
because there was a WARN_ON() added.

Currently the commit message does not say how this bug looks like to the
user.  Also the use a Fixes tag.  Something like this:

The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
initializing info->fix.smem_len.  It is set to zero by the
framebuffer_alloc() function.  It will trigger a WARN_ON() at the
start of fb_deferred_io_init() and the function will not do anything.

Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")
Signed-off-by:

Make sure you CC the original author (Chuansheng Liu) so they can review
the bug fix.

Google used to give good guides for how to send a v2 patch but now the
first page is just useless.  :/

regards,
dan carpenter


> Signed-off-by: Peter Suti <peter.suti@streamunlimited.com>
> ---
>  drivers/staging/fbtft/fbtft-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 9c4d797e7ae4..4137c1a51e1b 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -656,7 +656,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
>  	fbdefio->delay =           HZ / fps;
>  	fbdefio->sort_pagelist =   true;
>  	fbdefio->deferred_io =     fbtft_deferred_io;
> -	fb_deferred_io_init(info);
>  
>  	snprintf(info->fix.id, sizeof(info->fix.id), "%s", dev->driver->name);
>  	info->fix.type =           FB_TYPE_PACKED_PIXELS;
> @@ -667,6 +666,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
>  	info->fix.line_length =    width * bpp / 8;
>  	info->fix.accel =          FB_ACCEL_NONE;
>  	info->fix.smem_len =       vmem_size;
> +	fb_deferred_io_init(info);
>  
>  	info->var.rotate =         pdata->rotate;
>  	info->var.xres =           width;
> -- 
> 2.25.1
>