Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220725203129.1973260-1-nfraprado@collabora.com>
In-Reply-To: <20220725203129.1973260-1-nfraprado@collabora.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Tue, 26 Jul 2022 09:50:24 -0700
Message-ID: <CACeCKaeN12pikzZOVHSv-JQJn4z7Cn61wTqoiAce58-QRSqk_g@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: retimer: Add missing id check in match callback
To:     =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        kernel@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

HI N=C3=ADcolas,

On Mon, Jul 25, 2022 at 1:31 PM N=C3=ADcolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> The fwnode_connection_find_match() function handles two cases: named
> references and graph endpoints. In the second case, the match function
> passed in is called with the id to check for the match. However, the
> match function for the recently added type-c retimer class assumes the
> connection has already been matched (which is only true for the first
> case).
>
> The result is that with that change, all type-c nodes with graph
> endpoints defer probe indefinitely, independently of having a retimer
> connection or not.
>
> Add the missing check, like is done by the type-c mux and usb role
> switch code, to fix the issue.
>
> Fixes: ddaf8d96f93b ("usb: typec: Add support for retimers")
> Signed-off-by: N=C3=ADcolas F. R. A. Prado <nfraprado@collabora.com>
FWIW,
Reviewed-by: Prashant Malani <pmalani@chromium.org>