Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 14:23:56 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Abhishek Sahu <abhsahu@nvidia.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 1/5] vfio: Add the device features for the low power
 entry and exit
Message-ID: <20220726172356.GH4438@nvidia.com>
References: <20220719121523.21396-1-abhsahu@nvidia.com>
 <20220719121523.21396-2-abhsahu@nvidia.com>
 <20220721163445.49d15daf.alex.williamson@redhat.com>
 <aaef2e78-1ed2-fe8b-d167-8ea2dcbe45b6@nvidia.com>
 <20220725160928.43a17560.alex.williamson@redhat.com>
 <bd7bca18-ae07-c04a-23d3-bf71245da0cc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd7bca18-ae07-c04a-23d3-bf71245da0cc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?04agtZLbMDn9zXxQgVraKYeTnjq35vtvCHcuF3DsPPiBHwfE1np6ohdK9kTW?=
 =?us-ascii?Q?utFgCG2EdWy6G/QQkwBa9+FmnVs7tGUaD9fk/DDUx4iVdAslOC0HGaQPxh4G?=
 =?us-ascii?Q?lPTbhKNCsQ76uiT5wwLLW0c6rbL0tAG/IOSHlqheCKJU2ZrsSWuJPnMtYVDi?=
 =?us-ascii?Q?8Ofy66Y8cFFEH5idAf6+qJOfCxE+fcOi5OEf4DbH6GccU/VZnQ2dW00jDCgu?=
 =?us-ascii?Q?zXTZryOmtkKYw2cUsD6RsfkgEbaoiOJ8aOP8uwbTN55Gyz+DZMOzMFTZwLE4?=
 =?us-ascii?Q?F29eaIMM4ota2EKlWdudutkWdI6JJYW0p2a6nixUut4GNooiHS42QAylRwcg?=
 =?us-ascii?Q?8dHCvElyMaQ3R3XzyqTDOYCGyZkN7cKGTUJ1aCYD3F3dovIJuCRf9rAKTnMv?=
 =?us-ascii?Q?XqMdKGc7/oYEEO8DGiEtJRxCeVw38YBKSj7A/NzI4yNMdroGg775cRMWru/8?=
 =?us-ascii?Q?H2XaxkhQib7tFAYY93vtNo6NQbMmB+JxvMhowHoUE/HWRjHAqnzXDgEV/lG5?=
 =?us-ascii?Q?7d1Ybdk2ihWv/bvMULL46G+/GhB9iaQtO7exgXhoWCKCxQucn9BAQtapZg2h?=
 =?us-ascii?Q?toWtpkQ6zapiAUHmKMHRoRHYkGeSPFk+IqSU7b1xZ5pG6HlxOCVns/5P1J0E?=
 =?us-ascii?Q?stdNygHdcvPKjuu5rDZdFVEAd0uEn6ltrkHsb1p1qnIuiaNEea9ZZ2SNaJYh?=
 =?us-ascii?Q?1CsIVRx//t+RMmORjQh7iM+egC+SSch/UktYQKSfbq476/ubdUgZS/92auZO?=
 =?us-ascii?Q?IhaBx3T7zyz845GSzUDBYHR/p0lzpxmvd04Jnp1ZVHfSeLo6nWQSBYvAAtR4?=
 =?us-ascii?Q?9kZyWBoEghekr8RqPjfZphgAgfYZ+H/u/AOyNtSj60k3xk2WMfOa7eoOUVv8?=
 =?us-ascii?Q?GC8HaRrhOyh9Wv8JKFI7FHhWgCoikAK48zo8IiE9pO7KnODRuZtAJmy1K0Sw?=
 =?us-ascii?Q?goKUJ+rGedXu+n2O0hHXTFwA0wJ2nSPvXGX+lgtF+wK4AnM/zLNnx3xV/ere?=
 =?us-ascii?Q?70syiIN2Ko6zNlhYoWd+ozTf4m0/U8fYokNWfiiL4CA18PvzFz0jT51c72k+?=
 =?us-ascii?Q?ZFJnQa9CQmw4Zcp06+Bx+k1Dn7GY8PZAUt0h86MSf2i53/m8lRnwie1RzrCs?=
 =?us-ascii?Q?15nVsw8Gkok4NrAASAVYtqm90at92t9/x2GDOSeY/9uvbKdHeZf81NenDw6h?=
 =?us-ascii?Q?P6zVrFtWFEVpN4Nm3ldm8UcA2TELVvHGvskxZZMUsTp0Ux/E0YjLgW/PDyck?=
 =?us-ascii?Q?YWNpUuBJZcRSLTcFAk49eIMHOx3kSguKv+gWoOC3pvR3nJHZN8Agy4YZIi+T?=
 =?us-ascii?Q?is3TwO8OGDHKOBfQ7GfxPPHlNakN5l7bZTn+MgAyYRVz1HPcJL9ZNUbN6Tzh?=
 =?us-ascii?Q?cCJRHeST8qdj1FaTEhn1ADa2nSRCuHPZE/EnCsYi3GvWBH9OzIJfSRQczmrW?=
 =?us-ascii?Q?9UQDmw7Bk/GRJS+To83fT+wh3AFpIOIgkiZ0PsAaOgZhA2vDwGxMtLHFR0x1?=
 =?us-ascii?Q?4hQg9TM45L+TRCNOxymAJPXSN/Q1DQPnS5vE8hFFEYM99lTdzqOseTiVAhdv?=
 =?us-ascii?Q?NfSNJcMY7FmupWipEv6g6nPxxQ9uJcx0mJEQI9TU?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 913e2d9a-1f6e-4636-c354-08da6f2b9f8d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 17:23:57.9522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OVJYuK2of8SaKcy5mGEWByc0cqZsbCl9vsrBy4UGIvDiETWjnrv/ObsVMdLrmC4E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2530
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 26, 2022 at 06:17:18PM +0530, Abhishek Sahu wrote:
>  Thanks Alex for your thorough review of uAPI.
>  I have incorporated all the suggestions.
>  Following is the updated uAPI.
>  
>  /*
>   * Upon VFIO_DEVICE_FEATURE_SET, allow the device to be moved into a low power
>   * state with the platform-based power management.  Device use of lower power
>   * states depends on factors managed by the runtime power management core,
>   * including system level support and coordinating support among dependent
>   * devices.  Enabling device low power entry does not guarantee lower power
>   * usage by the device, nor is a mechanism provided through this feature to
>   * know the current power state of the device.  If any device access happens
>   * (either from the host or through the vfio uAPI) when the device is in the
>   * low power state, then the host will move the device out of the low power
>   * state as necessary prior to the access.  Once the access is completed, the
>   * device may re-enter the low power state.  For single shot low power support
>   * with wake-up notification, see
>   * VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP below.  Access to mmap'd
>   * device regions is disabled on LOW_POWER_ENTRY and may only be resumed after
>   * calling LOW_POWER_EXIT.
>   */
>  #define VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY 3
>  
>  /*
>   * This device feature has the same behavior as
>   * VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY with the exception that the user
>   * provides an eventfd for wake-up notification.

It feels like this should be one entry point instead of two.

A flag "automatic re-sleep" and an optional eventfd (-1 means not
provided) seems to capture both of these behaviors in a bit clearer
and extendable way.

Jason