Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "ronak.jain@xilinx.com" <ronak.jain@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "git@xilinx.com" <git@xilinx.com>, "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Topic: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
 configuration support
Thread-Index: AQHYnaLjy2AcewErSEyspw5q+NWPga2NwKqAgAFZDXCAAD4PgIABo9kw
Date:   Tue, 26 Jul 2022 18:48:08 +0000
Message-ID: <MN0PR12MB5953571B73BE19D01BCF12D4B7949@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1658477520-13551-1-git-send-email-radhey.shyam.pandey@amd.com>
 <1658477520-13551-3-git-send-email-radhey.shyam.pandey@amd.com>
 <Yt15J6fO5j9jxFxp@lunn.ch>
 <MN0PR12MB59537FD82D25E5B6BE17D1B6B7959@MN0PR12MB5953.namprd12.prod.outlook.com>
 <Yt7OqU9LXl4SDqYx@lunn.ch>
In-Reply-To: <Yt7OqU9LXl4SDqYx@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qyj7q1B/lW0DIz9w7sS5/3iK+xJnCnUv+Y4bPz1ugvlko9lVupsRPyN2Yvvp?=
 =?us-ascii?Q?dSa7/dtcvVW8nklZm7TAA6Vi4b5OBCU1z97Xezopx3oAgMmj8NzAoIMegVoa?=
 =?us-ascii?Q?fifftSp6Xz8zUJxCL9hMk7ehz+5jdtUYQ9H8xu33xJ/1VYpXMBA9P7NUdSFz?=
 =?us-ascii?Q?F+yjkzCKEsr5daXXe3FJfYPJnTII5/SSJo0mASNsYyZFAPYfFMBPZgbdsDAg?=
 =?us-ascii?Q?Y6Ij/hsdOQhD69mVy76R8aC+8Jn15F1jnab2JfD7SQe242iUDOGmXhMyF/Xy?=
 =?us-ascii?Q?cANJYcUVfRfkwTV931zJhUjKE/uG4DDOhXdVoNR4Pm1JkWUyv4eaiRrWvcGE?=
 =?us-ascii?Q?9U9ObfjcOilxJzs5SZWZ2gTfw/KdQNXVaasTC9kt5NzWM4anZSPRRcMBjh6V?=
 =?us-ascii?Q?CZAlNduPsc81c5NnW5zBKzg3qzMBL/CZNXpX9Ln/eBxPSvv6ZRkcJilDPaqr?=
 =?us-ascii?Q?iy7aku9LOsNgDnG6Y+RICBsKNb7hCDYX3SGpqgKLWl31CjYiKSMteciuWqZj?=
 =?us-ascii?Q?ZPWvP6h6D5E0BlnIziOddN6q7IlioRy7gU30NBhKWQ11Z4YlEuyjD9FiTTbE?=
 =?us-ascii?Q?A5ObyhkRQRXnZvmehLK8ndZPaFeEUv+U8unolFxli8AxW5e3dDwUzkNdMywg?=
 =?us-ascii?Q?rPFPwIu6F3f/6J1F+e3W86U5CCgNnWRLFzlOfWiJ7E+E7IJls06g5jnZvRn5?=
 =?us-ascii?Q?lnncl6n3o13vAt8UytBaPMyM/33DHEZPx6pzw58mfGcRGSnRFZGvMxgXraXu?=
 =?us-ascii?Q?Epm2HuNd7cBMbl4l7ExwIRfeV+a9AaKGnhgb9ydgfk0xmWepxa1WU+rZGkID?=
 =?us-ascii?Q?PN2IAw50rpvXpkGPg8Cp2sBTVaI3bv1OdIGONxWAo3mDCcUY27RTtV2SiidW?=
 =?us-ascii?Q?LkxfRU/o4bYlrx7tvXIPzBHMYgtyrwFWrmLOAuDBsWt3UNIu3ds+aFxE8OkC?=
 =?us-ascii?Q?3NttX+NQM6hGfo9H2jytcQVpdXk0JWqzBqargf8Vd0TNwlFez+ZJAYxlbtWA?=
 =?us-ascii?Q?ztUxx35bjeLbVhlI8zR5ORDpdg+QCVxSEYt1Z+kb7P4YEnDc6gf3Tj6cCTbq?=
 =?us-ascii?Q?VhKbI5BJfVySkzRzf96uIZpTIdwyp4tKSIBfNHXXj2ozMU8zIFM/Lwe0ByTo?=
 =?us-ascii?Q?MTHqa/rb3CY/77eMDImSZ0ebWr0ltR5oguf/4f6ccgAVc0HkQkTCTS+Xe8px?=
 =?us-ascii?Q?oPTgZOYLLXBl9wbU7puWZmH1ANgBjG3OnM/pylUeA1LVwL8dDbxzNEJdNnu9?=
 =?us-ascii?Q?KkDVF7ShCO1iEEyzEVjhTGKB67cdDA7HFW0FcCbkz1mqot/KQ5ml73HjMiRY?=
 =?us-ascii?Q?jXgxiSGOzOqFyjWAzjFrSMl88o1ZuaNgbyBSfpsZk3qj8LAZ0628OEn+eXTh?=
 =?us-ascii?Q?NbbgtL1QNeA6b2ff7eB5hDMj02NsLzFn7AlNj/sR7/R96rlYLkIrh3618xMh?=
 =?us-ascii?Q?OoqPAIfPKvJoGB4/UZD1RHz+Ik5/SIq0XusvoU/PiOHxzBxGejiSRfras2XA?=
 =?us-ascii?Q?I3KXmg/jckKI9RLWv2sd6yckdDWAZSKE8MuxyEziUfAZsX9PFB6x3Qe4NTds?=
 =?us-ascii?Q?nXp9qZVYWb7VJ7d7/vqeyZ4/6mdQP82r/LFaXouT6DFWwjZG6ShFRbN/Kcxy?=
 =?us-ascii?Q?FMpUytcA9jCNSZRgbXWSJww=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c529e3c4-7364-4bc0-3795-08da6f376210
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 18:48:08.5147
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J/K+JP0r6rQ0sVu1lDLWChxD2D7un0ZaORG7gj7sEa/xx59NC3hh/cBnzE3GmwG9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5720
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, July 25, 2022 10:41 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> claudiu.beznea@microchip.com; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic
> configuration support
>=20
> On Mon, Jul 25, 2022 at 02:34:51PM +0000, Pandey, Radhey Shyam wrote:
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: Sunday, July 24, 2022 10:24 PM
> > > To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> > > Cc: michal.simek@xilinx.com; nicolas.ferre@microchip.com;
> > > claudiu.beznea@microchip.com; davem@davemloft.net;
> > > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > > gregkh@linuxfoundation.org; ronak.jain@xilinx.com; linux-arm-
> > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > > netdev@vger.kernel.org; git@xilinx.com; git (AMD-Xilinx)
> > > <git@amd.com>
> > > Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII
> > > dynamic configuration support
> > >
> > > > +		ret =3D of_property_read_u32_array(pdev->dev.of_node,
> > > "power-domains",
> > > > +						 pm_info,
> > > ARRAY_SIZE(pm_info));
> > > > +		if (ret < 0) {
> > > > +			dev_err(&pdev->dev, "Failed to read power
> > > management information\n");
> > > > +			return ret;
> > > > +		}
> > > > +		ret =3D zynqmp_pm_set_gem_config(pm_info[1],
> > > GEM_CONFIG_FIXED, 0);
> > > > +		if (ret < 0)
> > > > +			return ret;
> > > > +
> > >
> > > Documentation/devicetree/bindings/net/cdns,macb.yaml says:
> > >
> > >   power-domains:
> > >     maxItems: 1
> > >
> > > Yet you are using pm_info[1]?
> >
> > >From power-domain description - It's a phandle and PM domain
> > specifier as defined by bindings of the power controller specified by
> > phandle.
> >
> > I assume the numbers of cells is specified by "#power-domain-cells":
> > Power-domain-cell is set to 1 in this case.
> >
> > arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > #power-domain-cells =3D <1>;
> > power-domains =3D <&zynqmp_firmware PD_ETH_0>;
> >
> > Please let me know your thoughts.
>=20
> Ah, so you ignore the phandle value, and just use the PD_ETH_0?
>=20
> How robust is this? What if somebody specified a different power domain?

Some background - init_reset_optional() fn is implemented
for three platforms i.e., zynqmp, versal, MPFS.

zynqmp_pm_set_gem_config API expect first argument as GEM node id
so, power-domain DT property is passed to get node ID.

However, power-domain property is read only if underlying firmware=20
supports configuration of GEM secure space. It's only true for=20
zynqmp SGMII case and for zynqmp power domain is fixed.
In addition to it there is an error handling in power-domain=20
property parsing. Hope this answers the question.

>=20
> 	Andrew