Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 14:20:35 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, songmuchun@bytedance.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] hugetlbfs: fix inaccurate comment in
 hugetlbfs_statfs()
Message-ID: <YuBao9x/n6QTUWNC@monkey>
References: <20220726142918.51693-1-linmiaohe@huawei.com>
 <20220726142918.51693-6-linmiaohe@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220726142918.51693-6-linmiaohe@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fHca0NqB4108KZhaEPNoEhWOU/BssLmOlZJOitIwTQXYkZeqnOgfOAXqpC+9?=
 =?us-ascii?Q?+/Vdmx3IiaURWSI+nkOZyqWdm0jLkWWZNZQlWjDdo9tG3Wbo/0/AUikhfwz9?=
 =?us-ascii?Q?kMSsb/bv5Xsj3HjrjLCahuUVfAkn/JgXfEMstg6jg6BnZMMrtSUq3pP60REw?=
 =?us-ascii?Q?rsr8+HeiR5FypxqeRgwzps3zWx9AvTqvhhRHNelXI/OmLNJ3z/ePwAyab9Mo?=
 =?us-ascii?Q?vsbs+srNlsQ6Gy3GjpYG/xRuihx9CEpEXEysh1wWc7kG0JGIKI7j3CtuNF+a?=
 =?us-ascii?Q?whYlQkhhx7AUgWDM6Pd6MhFA/vWkjyN0bysZIcfP73JvDOxKLDXrjWJu6zQX?=
 =?us-ascii?Q?srMm+5JmCkymhLPhLGRplQ3EvhQ/4UEA5PW/xdLiL2ZA5BzbRKlAD5KQ/dZC?=
 =?us-ascii?Q?s/guX1VVp93wH0gYmJXu2CH9uR9QSRP6pGrwmpYc0vSBs0xI8A/Ct2dzEh4f?=
 =?us-ascii?Q?uP7eShFQMZB0LzJgdvQD2WozYyWWKjZ1f22NS9iYUXMUz/QxDZM4bcdIqoIY?=
 =?us-ascii?Q?7WKygKqrU7YSt/xxd4T6r1As7bbq53Y5kNFrQ3uj7w8IwCVXoZXH4L6iXWmc?=
 =?us-ascii?Q?lG1agMJHsYjqpkERLgkJHL+6gE79LJW0fZybjLjl3o2zzFFgRoCCOu1BFUcv?=
 =?us-ascii?Q?kmoHCux9mdvSGdeT/b+/tYGPqPFGXPf/hcLA5pkYxObSHqcAN38WapFAxpkA?=
 =?us-ascii?Q?Fl1XNjRVGUtFN5TEC4UqJvXi6yLosxx4yEgIcaIFJula8NdZ3Bozc9QS0vSj?=
 =?us-ascii?Q?wSdBAXUpfrrs+WLudiO7C09gYOIKr/B7IliKLAwff1JwapImSNyvBNdSLmGu?=
 =?us-ascii?Q?0/6A5CBcH25o4uc2CkV5wLn4OyeeUl60YLMhAUyFElCLkPY7w39QCJhRoRyG?=
 =?us-ascii?Q?bjRL/KFzbBKh09WQYXYzVqFF5r9csTMYQxKOvxyabFrvj/5RV5dTFflt/cUo?=
 =?us-ascii?Q?Vaso/e7mmWzgEd+Sfb4wyBfNTM8cwBX2z1RJXEoV1QoDdyRbl3F8k9484aPB?=
 =?us-ascii?Q?5zyavxh309s2/+3GN9rpWnDXqUyL4OdZ3/G3y9YRmGsgthZ8sZaUTIsZTOsu?=
 =?us-ascii?Q?VWe6qHdRwV5mxgKwSo4LzA5Vu/mHZD9aMdmvVbsQ3k7T0U8VfVxz1oU1NijM?=
 =?us-ascii?Q?gd7hF+vaosEOlkveoGKJmozGUGArpcrwMSqw2SlMYyL//spV1dLJYz7ftwaD?=
 =?us-ascii?Q?zaEnjuVxTSEQC+e/sR+SH8CtXodc5+gk4fb8uQYJ2MoYhWxL3kepy+zpUoxJ?=
 =?us-ascii?Q?Hll5+UhVd5RvP0e2wjI2YB05BxF+FxEQr20OCe7n2Ueq2/WFHaJvVMTjLfUc?=
 =?us-ascii?Q?VEHqrVoRCEjcsFnY3IDUMFt9UFv9fxYJ7uBozcOsIaFwXUGol4mZE7syj500?=
 =?us-ascii?Q?nLmrZEuUoJ2Fv2nvvzhlkhRb0vU32gnAwCqqD14embV0pbo46P6jX6ljGtPO?=
 =?us-ascii?Q?YOnontr8BCMUuDq5h1Pkl7fFRuhbsk0zqHAMpd45a6+3pp4LL9Xat+/OPXEN?=
 =?us-ascii?Q?eWHMxXZ7fli2wbJ3rneQei2AW3ELxNsPyP5ruY0X8hG7F1sXduvqO1RpQvE4?=
 =?us-ascii?Q?2sHOBlX6RlaZ6GN/OSC1laue9bGCoakquuJgDjZ515WSAcSjsZiXmSc9RmhA?=
 =?us-ascii?Q?FQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd8a8e4c-a72a-4a8c-3811-08da6f4cafa2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 21:20:38.3843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Ll5fHcZCK1urd6NZ2TE1vgY1by8tmE+2JLoKH94kbdaNXN7YXYCQgRSYaO9H2nAPQnROCwLBzyFWxdutvsTLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4964
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_07,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207260082
X-Proofpoint-GUID: OJphDrGiYVOQ0f3kSR2-YsiS2p-OHle_
X-Proofpoint-ORIG-GUID: OJphDrGiYVOQ0f3kSR2-YsiS2p-OHle_
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/26/22 22:29, Miaohe Lin wrote:
> In some cases, e.g. when size option is not specified, f_blocks, f_bavail
> and f_bfree will be set to -1 instead of 0. Likewise, when nr_inodes isn't
> specified, f_files and f_ffree will be set to -1 too. Update the comment
> to make this clear.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  fs/hugetlbfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz

> 
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 96c60aa3ab47..fe0e374b02a3 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1079,7 +1079,7 @@ static int hugetlbfs_statfs(struct dentry *dentry, struct kstatfs *buf)
>  	buf->f_bsize = huge_page_size(h);
>  	if (sbinfo) {
>  		spin_lock(&sbinfo->stat_lock);
> -		/* If no limits set, just report 0 for max/free/used
> +		/* If no limits set, just report 0 or -1 for max/free/used
>  		 * blocks, like simple_statfs() */
>  		if (sbinfo->spool) {
>  			long free_pages;
> -- 
> 2.23.0
>