Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f396712e-f567-f4f9-7b2b-a67b528e1939@oracle.com>
Date:   Tue, 26 Jul 2022 19:31:33 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v2] x86/xen: Add support for
 HVMOP_set_evtchn_upcall_vector
Content-Language: en-US
To:     Jane Malalane <jane.malalane@citrix.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Juergen Gross <jgross@suse.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Maximilian Heyne <mheyne@amazon.de>,
        Jan Beulich <jbeulich@suse.com>,
        Colin Ian King <colin.king@intel.com>,
        xen-devel@lists.xenproject.org
References: <20220726125657.12151-1-jane.malalane@citrix.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220726125657.12151-1-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjE5cjN3UXFxd2FHOUd4dGVEZHZVdmltK1NoWHV5MVozdGJRVzBINnhoY29R?=
 =?utf-8?B?ajlXR3MvdXlaOCtaN3VLaitNRWpueU1jd29OdVF4RFhML2tLeHNwOWtFVmdr?=
 =?utf-8?B?bldGUEdlV0tORWFiMUF6aXUxSzBOOVhXRVRZc1llQWl5VVE1ZG1CWHNKelo0?=
 =?utf-8?B?RnRwUHV1emdjK2FXWkc1ZThPenkrRkpJY3NDSWhSSnJySkt4aUluSGk1S0tV?=
 =?utf-8?B?UHFlUmNIa09aYjdnSzUzTUZWRXNab25KYkNCZ0txRlphK1BXSHpOcVNoVHFt?=
 =?utf-8?B?RmY4cUpqRTY0UGd5eVlsODY0ZVIvLzk5RzNqT1ordFFRc2tOelYvUFdPajY4?=
 =?utf-8?B?QXlPa3FZbVRySFFIams4WHpZdWdQOU13OERoRUZTOEk4YzNJVTNxVDNVS2JF?=
 =?utf-8?B?bko3dlZ3MnBvcWkzcTF3Qm95SDNMeXJ6cGN3N3JoUlh2TFlRc2swYmY2Rmsy?=
 =?utf-8?B?eUJKbU96K2tRY0FOQi95b21nMm1KZ1BtMk9mYm14Nm9EZ0tsdEpyMlBLbjBK?=
 =?utf-8?B?R0lGQjlGaG0zQWFkNUFWbGZCR2tXOStFemM2R0pTUnBHNmMxdzhDNHdNWmNY?=
 =?utf-8?B?RXBpZTlOdzBzR3d6OEMyS0NkZmlZT0hkY3ZuUVROZ3ZjWVdKVWZaOEU3ZGQ4?=
 =?utf-8?B?ZjdLczU5QkJodUY2YkppYlViaGJpQkFraE5jUnJBdDdMaVZxcXRCRG55V2h5?=
 =?utf-8?B?ZmpLdmg2eXJ1WkNuQXJXTUdqS1BGVHJsQW5ZZk53MFp6dVhvMk1mcW5QMDVt?=
 =?utf-8?B?RFZOeUVDQ1FhOGtJQ0dNeVRNdkdyOVNabWNoRS9oZHQwQWE5MjZON0wzNlJP?=
 =?utf-8?B?MFdPcnp5TDBnQjdUeGxMODNDbThaWnhHNVVIaE4yWG0zYnowbkR0Mk92UUdY?=
 =?utf-8?B?R3R3TzYwY3lIV1JBcmo3U1NUcVQ0cVhRWHZBTW5uakZUOEZLYVMwa29IMjh6?=
 =?utf-8?B?dzYvdU9PREhXYmNETU0zTnRnS0JMR09sNlJjM1JWQld0S1FibG9IOHZPdmxO?=
 =?utf-8?B?L0JzNjVhZDd5MzZKUjhYai95WU5DTlNvUjFrc1l1K1FMQ0kyanZpOGFRN282?=
 =?utf-8?B?b1JUMzZVQ3NZSHpPVmNLMWczWnVWWmhjSmtGSjU0ZThhLzlYSjBWOElqY1Vn?=
 =?utf-8?B?RUl3aVNqSzRyMU11UE9EUVF0cXdIamJCd1dXd2Y3SmpLekV6TVZJS01FbEdC?=
 =?utf-8?B?R2ZwRUVLSUFaMWxnelVvblp2d052OXBYM3B3Slp3THYzZ0NYMTF2V3F1MkFo?=
 =?utf-8?B?RDhyK1R1ZEhQM1BvaTFUa2F3NnFTY1hnV1NzTDZTNEFINHBXakZCQm1KS29V?=
 =?utf-8?B?NkVCbjRRcTR1ZnFsOUE5M29tWDZnTkRkdkNPOGdjanVmbUF2VmI5Y2pONHl3?=
 =?utf-8?B?TW9JUEFvZXNoS2xtTm1LNWxLYkx5dWh2NmY2cURyNWUwdjM3Q0F6Q0ZHZDdm?=
 =?utf-8?B?SW5JTGhiSFd2cEk0ZWhhcGszVHQ2YUNHcE95ejVxZ1Q0WEIzRG1wWnJNMlRD?=
 =?utf-8?B?UzAwcGdldVBYS0N1SG0yMVdWeWJ1UUV4bFlMc2w4enRFT2RaMlptb2xrSHow?=
 =?utf-8?B?ei80T3NGRG9pOXFzVFpSZExyUXJBY1dMdkwxNWtOVlROUzdtQ2NCMDhoUHFP?=
 =?utf-8?B?Nm9RaU9DYmthQ0lSZkdxV0RVV1RtTVZsTnlUbDN2Qy9FRmlDVEdESXlEQzk5?=
 =?utf-8?B?ZjRlUnJWdG9QeTVLZ3poU04xcE4vZnZkT1hXbzg2RVpTNjJRSEdmVTNndG9j?=
 =?utf-8?B?OFpOTzM1ZHRqeEIzejhUUStwRUYrK2w4OVdwTmVxdHEwazl3N1lJKzZsRnNQ?=
 =?utf-8?B?SStSRjVtVmw0TG44YU9NdHROWWg1Vm9RSkNpYzRXUmtJQVVESEhIYWFUeElv?=
 =?utf-8?B?M2prYndSTE9Selp0NnVSbnE4Y0dFdDhHZWlOaEd1SzBnN3gvMEh1RnB2alBE?=
 =?utf-8?B?Y2dwOG12UHVQWmtidjNtd0FCSEpyRG4zNk1hVjBtT1dVYWJuT1JXSkZvV2dz?=
 =?utf-8?B?eFA5eXhIb2kxS3daT0s4Y3RVNS9SYzNpVjFodkwzaXZjbjhpK2tDT053MHBs?=
 =?utf-8?B?YnNRcnlJaUg1dWlmcHFlM1hmMHp6enJ5NVpiQzB3TG04TUVuVFV6NzYxV3d0?=
 =?utf-8?B?NWdFVGtmWmtKRzlNZ2VDKzNQNDhncm9IZG5Bd0dJaXM5U0RnMmEyWXhrOVV2?=
 =?utf-8?B?VWc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0123e62b-c3ef-4dbe-75ae-08da6f5efc3a
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 23:31:37.7363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UkxT0vvuYbbA0d9A+baZevCP+EUoo7tuHTlT4EFGQ9sNvVrOhkTDwWFj0cM6fD8e0SyotLKiBYB3WTj0hg6v/RI9WaeY78vGYEhHqplQfMM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5260
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_07,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207260089
X-Proofpoint-GUID: Ul6hWfnwxE-yWm59F8N7TnJNRPUNyOHC
X-Proofpoint-ORIG-GUID: Ul6hWfnwxE-yWm59F8N7TnJNRPUNyOHC
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/26/22 8:56 AM, Jane Malalane wrote:
>   
> +/* Setup per-vCPU vector-type callbacks and trick toolstack to think
> + * we are enlightened. If this setup is unavailable, fallback to the
> + * global vector-type callback. */


Comment style.


> +static __init void xen_init_setup_upcall_vector(void)
> +{
> +	unsigned int cpu = 0;


Unnecessary variable.


> +
> +	if (!xen_have_vector_callback)
> +		return;
> +
> +	if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) &&
> +	    !xen_set_upcall_vector(cpu) && !xen_set_callback_via(1))
> +		xen_percpu_upcall = true;
> +	else if (xen_feature(XENFEAT_hvm_callback_vector))
> +		xen_setup_callback_vector();
> +	else
> +		xen_have_vector_callback = false;
> +}
> +
> +int xen_set_upcall_vector(unsigned int cpu)
> +{
> +	int rc;
> +	xen_hvm_evtchn_upcall_vector_t op = {
> +		.vector = HYPERVISOR_CALLBACK_VECTOR,
> +		.vcpu = per_cpu(xen_vcpu_id, cpu),
> +	};
> +
> +	rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op);
> +	if (rc)
> +		return rc;
> +
> +	if (!cpu)


A comment (e.g. "Let toolstack know that we are enlightened." or something along these lines) would be useful here.


-boris


> +		rc = xen_set_callback_via(1);
> +