Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn>
In-Reply-To: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Wed, 27 Jul 2022 06:31:23 +0530
Message-ID: <CAFqt6zabgY6DgCQBe0HCsMYScNEnKbm-0nH4ghhALZpF14rm4g@mail.gmail.com>
Subject: Re: [PATCH] memblock tests: compiling error
To:     Liu Xinpeng <liuxp11@chinatelecom.cn>
Cc:     Mike Rapoport <rppt@kernel.org>, Linux-MM <linux-mm@kvack.org>,
        David Hildenbrand <david@redhat.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote:
>
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>

what is the steps to hit this compile error ?

> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified")
> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> ---
>  tools/testing/memblock/internal.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c..cf67e6e 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,9 @@
>  static int memblock_debug = 1;
>  #endif
>
> +#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__);
> +
> +bool mirrored_kernelcore = false;
>  struct page {};
>
>  void memblock_free_pages(struct page *page, unsigned long pfn,
> --
> 1.8.3.1
>
>