Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bf50501-fac5-cd59-660e-52a6b779865f@huawei.com>
Date:   Wed, 27 Jul 2022 09:53:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.3
CC:     <mawupeng1@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memblock tests: compiling error
Content-Language: en-US
To:     <liuxp11@chinatelecom.cn>, <rppt@kernel.org>, <linux-mm@kvack.org>,
        <david@redhat.com>
References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn>
From:   mawupeng <mawupeng1@huawei.com>
In-Reply-To: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/7/26 11:05, Liu Xinpeng wrote:
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
> 
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified")

Fixs should not have word warp.

Tested-by: Ma Wupeng <mawupeng1@huawei.com>

> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
> 
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> ---
>  tools/testing/memblock/internal.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c..cf67e6e 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,9 @@
>  static int memblock_debug = 1;
>  #endif
>  
> +#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__);
> +
> +bool mirrored_kernelcore = false;
>  struct page {};
>  
>  void memblock_free_pages(struct page *page, unsigned long pfn,