Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Saravana Kannan'" <saravanak@google.com>,
        "'Tomasz Figa'" <tomasz.figa@gmail.com>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
        "'Alim Akhtar'" <alim.akhtar@samsung.com>,
        "'Linus Walleij'" <linus.walleij@linaro.org>
Cc:     <kernel-team@android.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <20220727013349.3056826-1-saravanak@google.com>
Subject: RE: [PATCH v1] pinctrl: samsung: Finish initializing the gpios
 before registering them
Date:   Wed, 27 Jul 2022 11:01:58 +0900
Message-ID: <000001d8a15c$da89d980$8f9d8c80$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQKDghdYfyUFZdNhjAU1XAi4XeJOwAIqlEK5rCpf/UA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220727013403epcas2p452b5f66597b4298b7a573393927ac96e@epcas2p4.samsung.com>
        <20220727013349.3056826-1-saravanak@google.com>
Precedence: bulk

> Subject: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before
> registering them
> 
> As soon as a gpio is registered, it should be usable by a consumer. So, do
> all the initialization before registering the gpios. Without this change,
> a consumer can request a GPIO IRQ and have the gpio to IRQ mapping fail.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>

Make sense for me and I tested this on my Exynos Auto v9 SADK board.

Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Tested-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park