Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1774d0f6-9607-0111-c940-f0bd2b4f7c75@huawei.com>
Date:   Wed, 27 Jul 2022 10:09:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] mm: memory-failure: convert to pr_fmt()
Content-Language: en-US
To:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>
CC:     Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220726081046.10742-1-wangkefeng.wang@huawei.com>
 <20220727011203.GA3346517@hori.linux.bs1.fc.nec.co.jp>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20220727011203.GA3346517@hori.linux.bs1.fc.nec.co.jp>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/7/27 9:12, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Tue, Jul 26, 2022 at 04:10:46PM +0800, Kefeng Wang wrote:
>> Use pr_fmt to prefix pr_<level> output.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> There're other classes of prefixes like "Unpoison:" and "soft offline:" in
> mm/memory-failure.c.  So simply adding subsystem-wide pr_fmt() changes to
> print out two prefixes like below:
>
>    [ 1479.892348] Memory failure: soft offline: 0x1b8200: page migration failed 1, type 0x57ffffc00a000c(uptodate|dirty|mappedtodisk|swapbacked|node=1|zone=2|lastcpupid=0x1fffff)
>
>    [ 1486.871130] Memory failure: Unpoison: Software-unpoisoned page 0x14f00
>
> Do you intend this change?


Firstly I think they are all in memory failure, with this prefix is no 
bad impact,

soft_offline_page() and unpoison_memory()  are used by error injection,

but soft_offline_page() could be used in memory hotremove, so let's add

'#undef pr_fmt' before unpoison_pr_info definition, options? thanks.

>
> Thanks,
> Naoya Horiguchi