Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "Zhangfei Gao" <zhangfei.gao@linaro.org>,
        "Zhu, Tony" <tony.zhu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>
Subject: RE: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Topic: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Index: AQHYkC3GvF//WyZOvUaTLdl04LC2Cq2MG8sAgAEavgCAAhH3gIABB5EAgAB+1ACAANqooA==
Date:   Wed, 27 Jul 2022 03:20:25 +0000
Message-ID: <BN9PR11MB5276974ABA5981A7361953708C979@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-5-baolu.lu@linux.intel.com>
 <20220723141118.GD79279@nvidia.com>
 <686b137f-232a-2a78-beb0-e4373bd20959@linux.intel.com>
 <20220725144005.GE3747@nvidia.com>
 <6da27a6b-b580-4ba4-24c8-ebdfb2d9345d@linux.intel.com>
 <20220726135722.GC4438@nvidia.com>
In-Reply-To: <20220726135722.GC4438@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FI7wI7E61sr6cKfYZc4/GlandHTdPXfB0g7aTL7mlm6VAjZF8LAgaeWJ3NjJ?=
 =?us-ascii?Q?uJa065TN/AsXYekAFcWqxjwjqrN3aU2pnF50VOTR0M+dsfx0q00vfUZK6Cbn?=
 =?us-ascii?Q?Wu20UX8Gi8KzQxtHGWMV5Vaup802DuvFG4Pgx2HHT3TDp6NqrzErVQ9wT22P?=
 =?us-ascii?Q?xwGigDz0KIN05w9uZ+QfN7G3H5DTxFmcU9A7NEAjipjX1SsNwgcmf0effcDZ?=
 =?us-ascii?Q?3WVb9+JapSuefNyzgaKGdCm8jvwco5GqlWz+Nxx3EHUUHu8J3iUI4LTJY7g2?=
 =?us-ascii?Q?CPrmWoMPmy1tZAM+Y7c5gdrf3fGY0CPerSPkhAT16dP7DoShax8tnZxAJNGm?=
 =?us-ascii?Q?472mWmLWeqJKHjkvfzB1t3MVOJU/uTkptsCfo8N3lMop+vEaD4iB+MS/l5vt?=
 =?us-ascii?Q?TTgP1ecJKOVrrpriuZaVZsphwgR1m68jdqqP9PofDA7j+uZ8LzyDhR184Vx3?=
 =?us-ascii?Q?UkuNJIQDYs5noV+aEFpFXKFg5rX7tSvYtwv2xRj/Uzbf8jst7JwsD9KqsKtO?=
 =?us-ascii?Q?aR6k8/kOyfSOzh1IwxjhaLM0WoLLNoe8CUONkmpbQ3mQKxWDoW5or9nWGFf2?=
 =?us-ascii?Q?lUbVXPqipYo7TgJHb5kQ8p/t/4dRoFDFULLMiBSEIgWPXU/+yQipDQbrXmJX?=
 =?us-ascii?Q?pjT20HOdIfEauK4zqz2yFnVTIGeGY+KTWePh+igsg2RdT9ZZlUkcti9KoVvw?=
 =?us-ascii?Q?KJlKwfi3VK99chTn7scozRLggnPLcnixaMVr5scpePAatSV1oM1mX5EUIiOT?=
 =?us-ascii?Q?dxLwgvgAv8Tr/2Rhz+XGBk8+Ty8MMOKJ+93BeosdCnxcOQveAkAyiYBcB33J?=
 =?us-ascii?Q?8yOlSViVx2akSHc2duxiA8tNseAUZhQ12gHRTtPHwWhawtYKFW9kZgUv/VsJ?=
 =?us-ascii?Q?nKGpNH6gHJvWEq4mKJZkWAM35XCziViX7EqjWNuultTp8sUE090XxRMWopQ+?=
 =?us-ascii?Q?vWj6JqoUqM+CulJrmfRPq8ihdtO4HQBQS56zS30q4AYbHKsc+clm0U8fPIkA?=
 =?us-ascii?Q?fxZ7yTLM7YQdYRr/XafkYEySs8aBOPbTgo7mfupKqLzRiQJw+KKDAHQdYFRN?=
 =?us-ascii?Q?xChQ/GqmM7VFfJUb08w8Fsgxd8baEcJxFsjNVAId5IhghtVtu+C/Ktp0tOI3?=
 =?us-ascii?Q?RESfeharB80I+qtcPcrW8rxux4/XcpLnBuRx8I982NnGl/JqU0uROgz6Hrs+?=
 =?us-ascii?Q?Y+4tzlvliwRkX6nGDy124D4E6kmQpLIL/hHPqV+x90LRI9jN9hcUP6DqpuMD?=
 =?us-ascii?Q?MJ8HjuL5JWsiwn8LKrMSV3PYm1ik3B/WJuv8imuLekMGyD/Qr+bKlHBXo6tB?=
 =?us-ascii?Q?YI2IeMFso6KQ5k78KYdzkas9V9oEGK6QCFTzNCTxmeDc1ftofpx9+Bh8A6Zm?=
 =?us-ascii?Q?o5WeDKYwsbqqOQgd3udJ8cL5rSdbAoi4rC2LGn2QcefUiHusp/1UjS6yb+bh?=
 =?us-ascii?Q?RCnkqSIy/RAAt6vk4Ovab83vXq3Bk6nhGijJk0Mr0//1vnwivU4T8BSu3x+o?=
 =?us-ascii?Q?5FotF0arfjrHrKISmjXciMOLONh+cAs1JejZQctU+vabkq+60wNn89emVNTi?=
 =?us-ascii?Q?gEa9FEOAxvheZPJG0LdPVXbWUV9KbUjptbZbgQfz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98a26d0d-b5ba-47c5-2d27-08da6f7ef2cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 03:20:25.5907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LDeuN7x8jry2aGLibnrEkVpkjlHwb8jP4N83EHXiTWFgJQF2WzZHOLYPkXU+geOAI6YUemsy+FNL5NlD7W9ZYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3513
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, July 26, 2022 9:57 PM
>=20
> On Tue, Jul 26, 2022 at 02:23:26PM +0800, Baolu Lu wrote:
> > On 2022/7/25 22:40, Jason Gunthorpe wrote:
> > > On Sun, Jul 24, 2022 at 03:03:16PM +0800, Baolu Lu wrote:
> > >
> > > > How about rephrasing this part of commit message like below:
> > > >
> > > > Some buses, like PCI, route packets without considering the PASID v=
alue.
> > > > Thus a DMA target address with PASID might be treated as P2P if the
> > > > address falls into the MMIO BAR of other devices in the group. To m=
ake
> > > > things simple, these interfaces only apply to devices belonging to =
the
> > > > singleton groups.
> > >
> > > > Considering that the PCI bus supports hot-plug, even a device boots
> with
> > > > a singleton group, a later hot-added device is still possible to sh=
are
> > > > the group, which breaks the singleton group assumption. In order to
> > > > avoid this situation, this interface requires that the ACS is enabl=
ed on
> > > > all devices on the path from the device to the host-PCI bridge.
> > >
> > > But ACS directly fixes the routing issue above
> > >
> > > This entire explanation can be recast as saying we block PASID
> > > attachment in all cases where the PCI fabric is routing based on
> > > address. ACS disables that.
> > >
> > > Not sure it even has anything to do with hotplug or singleton??
> >
> > Yes, agreed. I polished this patch like below. Does it look good to you=
?
> >
> > iommu: Add attach/detach_dev_pasid iommu interface
> >
> > Attaching an IOMMU domain to a PASID of a device is a generic operation
> > for modern IOMMU drivers which support PASID-granular DMA address
> > translation. Currently visible usage scenarios include (but not limited=
):
> >
> >  - SVA (Shared Virtual Address)
> >  - kernel DMA with PASID
> >  - hardware-assist mediated device
> >
> > This adds a pair of domain ops for this purpose and adds the interfaces
> > for device drivers to attach/detach a domain to/from a {device,
> > PASID}.
>=20
> > The PCI bus routes packets without considering the PASID value.
>=20
> More like:
>=20
> Some configurations of the PCI fabric will route device originated TLP
> packets based on memory address, and these configurations are
> incompatible with PASID as the PASID packets form a distinct address
> space. For instance any configuration where switches are present
> without ACS is incompatible with PASID.

This description reads like ACS enables PASID-based routing...

In reality PCI fabric always route TLP based on memory address.
ACS just provides a way to redirect the packet to RC, with or
without PASID.

So it's simply that PASID requires such redirection hence ACS
because only RC/IOMMU understands PASID and related
address space.

>=20
> > +	/*
> > +	 * Block PASID attachment in all cases where the PCI fabric is
> > +	 * routing based on address. ACS disables it.
> > +	 */
> > +	if (dev_is_pci(dev) &&
> > +	    !pci_acs_path_enabled(to_pci_dev(dev), NULL, REQ_ACS_FLAGS))
> > +		return -ENODEV;
>=20
> I would probably still put this in a function just to be clear, and
> probably even a PCI layer funcion 'pci_is_pasid_supported' that
> clearly indicates that the fabric path can route a PASID packet
> without mis-routing it.

But there is no single line in above check related to PASID...

>=20
> If the fabric routes PASID properly then groups are not an issue - all
> agree on this?
>=20

IMHO if the fabric can route PASID properly, and according to
above once such redirect is available it applies to both non-PASID
and PASID TLP, then the group will be singleton in the first place.

Is there a real-world example where the fabric can route PASID
properly for a multi-devices group?

Thanks
Kevin