Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 10:41:39 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Yosry Ahmed <yosryahmed@google.com>,
        "Mingwei Zhang" <mizhang@google.com>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 4/6] KVM: x86/mmu: Track the number of TDP MMU pages,
 but not the actual pages
Message-ID: <YuCl48wyA1XkqMan@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20220723012325.1715714-1-seanjc@google.com>
 <20220723012325.1715714-5-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220723012325.1715714-5-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MMk7N254fBKT7Cr4S8hxGGwlCBKOSgQmvtLjxBDR5esBWmzYOmnGgNjhr+Db?=
 =?us-ascii?Q?uHGQkWeh5xnoxL3Z4qEmjLX6hmEo/cKOr4Nv30xQzWWHJUwIK0ipqZVyJWna?=
 =?us-ascii?Q?5fIUooAE2x+Tkbjv+BNZPId1GPYR4JvxijjPJYIPQUKA7uh2PazAGz/5RH2Z?=
 =?us-ascii?Q?6ChQZu/clYEwpJ5zSPbD+mF89XxKhS9AVL16Co/CFC5ve2UKPY+8hqcRykz/?=
 =?us-ascii?Q?JLt3zuab5wsjLOB/MkqHraFt6cXvPscNjTqFqp1kwiOzYNk/6V2sqY7Iwrkd?=
 =?us-ascii?Q?nr1G9WQJzFNXJnhPydwG52gGoR9OIEs0cQZlyIt5snx7ZX54O2xMR7sbI3s2?=
 =?us-ascii?Q?B75sbb3n2j4I70YWBl5+GyLmU7tSOe4RJCvWwNAnawhAbQ7h7GR+VDdtDfBa?=
 =?us-ascii?Q?K3P0pJV0FBrndCzw/xVRx0c3Psua3jWT/4/MJyQYBklfRNbTEl8dk420jNPg?=
 =?us-ascii?Q?LPM+G7MMBcE90XCvYiu9MimOgk9t3HuUccYzhwpYTA8IJKKHHc99qVvR8mKz?=
 =?us-ascii?Q?huf4R0zXVP4UCBh6F4UHvok4Ycu8UwhafqArZuM7HAvTU2q/7d852wVCk5G3?=
 =?us-ascii?Q?bASXtmCAXPJfkwvR0tLjj95WlXnkgj8xNmman9GAVs4aWxPkZP8EQU2nR3Ko?=
 =?us-ascii?Q?4zmGGZKrIq6JaubZMNv0gYQFY4+Gs2u79GFJw4btWrmhRnyTMjvRuo+xr+kg?=
 =?us-ascii?Q?UiKtyvqed2DhH8H9OxyTNnWq5CVII960NUVTqXAF4v5Ss0+AimcP9RYiSJUW?=
 =?us-ascii?Q?P0WBh20A5tiXpKGLiPGTsnKVB36CWQQT1jZChPGIUN/jD2onHrRpCGm0tn8/?=
 =?us-ascii?Q?VnnhOcB0HcmsrkeEkNvDzdVDNb4QcIWtG6FXS488qK47juyJNrSUaPlyeHil?=
 =?us-ascii?Q?9U8XAtATLaXMBdKYBdLzVIB0c8Eles8HDN8iMoyR5AeIH1irs44yFU9iEfUj?=
 =?us-ascii?Q?0GsNpBgbTefeHHJZoX6skpzxjt+a61fAPhT11BAVNnlu6mAhdWadE5w4ADZe?=
 =?us-ascii?Q?FpM6iOXXFG+PofioszwUuv5nDx0VhwR4wDE6tSdJxtX4HghwotszmKAYCjV3?=
 =?us-ascii?Q?F+HRWYTfmiYL7NUHwuKbokeylvdV+pas9yiyGqBuPKzEeuxl/ajHUCOR1HdZ?=
 =?us-ascii?Q?IVWUZETTRnxAbvGxpVXBsgWHEBG3gfK99nK+ToPhT8xGnWp6ca83O0J+weHl?=
 =?us-ascii?Q?grJJxMDajxD5jN8z/kV0CATBYesIQV3n+PIRWCrBw5NLvpsrX6j3Dp7+YJpK?=
 =?us-ascii?Q?xIzE8FzeLx7EAiB9sfuuX7PsrBab9jH7z7Qv8U3xyT3uFIoLs7QFEz5OrmKv?=
 =?us-ascii?Q?igFjDepEjr/PcYr+z+0ameQRRTlBj712guOIV9DgLSWmreJ2H3+hGMfiM4ob?=
 =?us-ascii?Q?+lWrT18FH7nnQsxBOFN1TzT4lQ2C3BeQjC++FK+cM3CKI2L1P7Z2EbP2IH9F?=
 =?us-ascii?Q?GvWw3JlXA+qgSUhlBzeS/33rttgJJDRml+AJ1EEK8xqI/Y4igr6aJAGHGeyV?=
 =?us-ascii?Q?zxmmjA4l6xhy3i9sErdloZ6FZ2b6O8XETF0zsIdgvDCpiS/2fE3XIumNd4st?=
 =?us-ascii?Q?9pVguW2vsz3FyDGHxSJMGcpZziwZkjzVPVbKcqcI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac079255-96e6-40df-ec34-08da6f7c694b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 03:02:16.4257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bGOoyuKb0pjlnmob3F7/49XZrR73D1LUW9cJQkrGmmtER+3gyvmfBOgtSUHy8JKNDGv7JtttOi5tZHlc9q83gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3623
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 23, 2022 at 01:23:23AM +0000, Sean Christopherson wrote:

<snip>

> @@ -386,16 +385,18 @@ static void handle_changed_spte_dirty_log(struct kvm *kvm, int as_id, gfn_t gfn,
>  static void tdp_mmu_unlink_sp(struct kvm *kvm, struct kvm_mmu_page *sp,
>  			      bool shared)
>  {
> +	atomic64_dec(&kvm->arch.tdp_mmu_pages);
> +
> +	if (!sp->nx_huge_page_disallowed)
> +		return;
> +
Does this read of sp->nx_huge_page_disallowed also need to be protected by
tdp_mmu_pages_lock in shared path?

Thanks
Yan

>  	if (shared)
>  		spin_lock(&kvm->arch.tdp_mmu_pages_lock);
>  	else
>  		lockdep_assert_held_write(&kvm->mmu_lock);
>  
> -	list_del(&sp->link);
> -	if (sp->nx_huge_page_disallowed) {
> -		sp->nx_huge_page_disallowed = false;
> -		untrack_possible_nx_huge_page(kvm, sp);
> -	}
> +	sp->nx_huge_page_disallowed = false;
> +	untrack_possible_nx_huge_page(kvm, sp);
>  
>  	if (shared)
>  		spin_unlock(&kvm->arch.tdp_mmu_pages_lock);
> @@ -1132,9 +1133,7 @@ static int tdp_mmu_link_sp(struct kvm *kvm, struct tdp_iter *iter,
>  		tdp_mmu_set_spte(kvm, iter, spte);
>  	}
>  
> -	spin_lock(&kvm->arch.tdp_mmu_pages_lock);
> -	list_add(&sp->link, &kvm->arch.tdp_mmu_pages);
> -	spin_unlock(&kvm->arch.tdp_mmu_pages_lock);
> +	atomic64_inc(&kvm->arch.tdp_mmu_pages);
>  
>  	return 0;
>  }
> -- 
> 2.37.1.359.gd136c6c3e2-goog
>