Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp85070imn; Tue, 26 Jul 2022 23:46:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vEYBQeOtcZ3lCwghVH3mNJvvkeZ+aUQG9T2UUFMIa+gZDm8jUqMdyjm/RIsReJvIuZT6Uj X-Received: by 2002:a17:90a:9412:b0:1f2:59ad:1f4 with SMTP id r18-20020a17090a941200b001f259ad01f4mr2880620pjo.147.1658904390184; Tue, 26 Jul 2022 23:46:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658904390; cv=none; d=google.com; s=arc-20160816; b=wXeogCxx4O87mCZRcZqdjFJvmuykVrBK7eYy+bryB1LxloO85k+7Ufphu9EDvSsMFC Hk2GFjbKBXGhVxtXdJvdwGW3nA7LqqhDU4vpGZ7GBSkkT48i6kCiVzthDXmLXgH0lgra 6sE8PcaNhuuUvgM4IxIoPz9ijqloF9lS0eijJyEuy2i4uUjDPc+mQ9s6tJf9b/NqvoHO EQa+kGlYWOtUxB0oAsrR9rrbOGJln29gddkveeVd/0zDpQW+fTmPkPzAlvEHWOjK7RUI BqwWXbwa0tqw4M0uyZ+B/PP+nn96obsecB+5HfjdAxjf81mXDhkQrNyOv7PcBitjfiCI +ayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IJf4TgefHFadagzVeTqif8QAQCz24R5RnXBmjOKxUSg=; b=0HAR3kAiYgyRnrYa7/IZOZs4cbQKs2H1/R08kCvYp0D4ojsa60FoBsVddgkQS8Q1ND uUPNYqmAR/lpAEDfNZjRXa05qa3lv71V0CqSdZLNDxJeImac97lMtSUkCVLCVTRtLGAO F8Bj24/7LX4ngHF4IRZsIlAyYctmx6RaIa7QaHHJYEfBN/GOHrljUAiKwTIyUxkSygau 8JESVX3o3r0xXqqrQ0r/Y+ElS9Nydmv9gYhqcl+G1zyN2MrH0IDf60b+rzUgjsepfiuy +w9gBhr5kyekd+J4egNh5t20bEX+StWl4NDh2JzG91JZq4sL+m4pUK2YzH7ZUOIISmh9 I9yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RP4nLawu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u16-20020a170903125000b0016ca0533a62si25033793plh.306.2022.07.26.23.46.15; Tue, 26 Jul 2022 23:46:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RP4nLawu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230371AbiG0Goz (ORCPT + 99 others); Wed, 27 Jul 2022 02:44:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbiG0GoL (ORCPT ); Wed, 27 Jul 2022 02:44:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0BC4419AF for ; Tue, 26 Jul 2022 23:43:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 193F56148C for ; Wed, 27 Jul 2022 06:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0543C43142; Wed, 27 Jul 2022 06:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658904230; bh=IJf4TgefHFadagzVeTqif8QAQCz24R5RnXBmjOKxUSg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RP4nLawu1SjE42GGT2T0CYiFNI88lBUX+ScZxBWJLO0PNbKOfC4o0ofueHOXdOTl5 8c5lzI5TuuwAhRJWVVM2MYUihNNGv8P93IJqNjTWtSsSpAi/WQp+a+MzOorFpTOytp Vhtrpy96W+KoGCIwIMrKQN7K4LV/aZ5mrlap3+cw= Date: Wed, 27 Jul 2022 08:43:47 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt Message-ID: References: <20220724153917.138848-1-martin@kaiser.cx> <20220724153917.138848-2-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220724153917.138848-2-martin@kaiser.cx> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 24, 2022 at 05:39:13PM +0200, Martin Kaiser wrote: > Define a struct ieee80211_mgmt in the OnAssocRsp function. Read the > destination address (da) from this struct. This explains (sortta) what this patch does, but not why you are doing this. To me this looks like a step backwards, why is this change needed at all? thanks, greg k-h