Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp109700imn; Wed, 27 Jul 2022 00:48:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vBmx1X5UFtVOFEyfqcpS06jWkJvWjtOytr1us5VyCJt1Ho4PQNQY7ahiun4wuzGVay0cjN X-Received: by 2002:a05:6402:2788:b0:43a:e0aa:97f4 with SMTP id b8-20020a056402278800b0043ae0aa97f4mr21307688ede.329.1658908122556; Wed, 27 Jul 2022 00:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658908122; cv=none; d=google.com; s=arc-20160816; b=E5FM2WtaLUiSHlzh1EwHquf7ahmABegTdUerCyQswXOxk5hMYEE6oiqWPrkGpcBRRi IQ5q2cM9N3Sawi/qXOizo7DqLqbSCKUdq19Tq/01Ukhmn5wvKEeuS/lJT5vtKWb7kBp0 FZaYcp8mOxV6UYQHNAk39VIjT+byakMx1SOFicTYppiCPqZht5rzjYZcFuOW95RgM5Ke i/rOid4W6+SwtdIPIK8YAWW4UMhyuEawBCucsBxl9Mxx1qwjUvrD5gVI43RPz0BxvaBN jjf/oWZBwoHaq4O1NXXGcv4TJ2aFNvLDV+L4aCWJL7N6BFYbmIFkitg++S4RWQ5/UiJ1 nMIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=R3tUlxKD6pqZMGC1QD93QIh14w111y452iSZwxv0h8w=; b=YFOnqk66PMyv3xpHzOK64J2oyYPXXmhA0SjGxSJ1axiD3AvrSVFqofTZE2soXb9k4t bpjV1h2x2RYMUIGHWCQa/ASTgsd5XuDcF0A5XZaNHPj5A+Z4wPo4J2DS1ckzqnuXE+JW Lcti6rp8yveKPYQhybZCJqGf3mpLWEj5AUpPA1ZaMNc4aod4wHpHUq4Jt4D03kGnxPYt TueferThdMyUK+p81Oq9i8KO5m6WKAYQjK4gSSs51UbjxSVnBtl6qoUAlDcdSztrXsbX 6ZJuYq3FaQ8ocrKGC6faQaBaMbIphmMdv9QSk9Qi9tSYS+4f3Xa2+JIE/uu+7gSOVqxd J/5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ToEX/wUg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb9-20020a170907160900b00722e5217355si22315686ejc.607.2022.07.27.00.48.17; Wed, 27 Jul 2022 00:48:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ToEX/wUg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbiG0Heb (ORCPT + 99 others); Wed, 27 Jul 2022 03:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiG0He2 (ORCPT ); Wed, 27 Jul 2022 03:34:28 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C2DD422CC; Wed, 27 Jul 2022 00:34:28 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8D2CA6601ABE; Wed, 27 Jul 2022 08:34:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658907267; bh=6ps4uQowS8HpISETXvtaiicTxwDeXzdtMPrNeVaDsvk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ToEX/wUgUB/m4F2DIP7ruKo6y+qjdkYa3nKiNumxyrfxYQSnZRpIz57UFxXNkTLv5 v50V4KAS4HbXimDKUYXObvJj6LL8dZ9oJjvbuDppd7NCUxdNqEdcvjqaVaPyUwJBhN UMTLo7HkUIKVdTAhY+eEO+wlI5NTIy5vPMb+ZsowOCqcP9mz7KqIb5snaUuKekZHD8 3fFhkvQsKj72T1eQ/tDhsD8IiKZcCW7Z2X70QNpxh6ZSu6TbZMzYm4d8CIhhTKaeI8 mirvQmENKSZujpqyBvi22L7EDKvF/Fbo1sC7eOMcjp+mQmhkgSUhNcCDWxbm85GTTj 4rB8vRSImBbaw== Message-ID: <47f90532-c115-61ad-1203-5658430b6a7a@collabora.com> Date: Wed, 27 Jul 2022 09:34:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/7] Input: mt6779-keypad - support double keys matrix Content-Language: en-US To: Mattijs Korpershoek Cc: linux-arm-kernel@lists.infradead.org, Fabien Parent , linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent References: <20220720-mt8183-keypad-v2-0-6d42c357cb76@baylibre.com> <20220720-mt8183-keypad-v2-5-6d42c357cb76@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220720-mt8183-keypad-v2-5-6d42c357cb76@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/07/22 14:56, Mattijs Korpershoek ha scritto: > MediaTek keypad has 2 modes of detecting key events: > - single key: each (row, column) can detect one key > - double key: each (row, column) is a group of 2 keys > > Double key support exists to minimize cost, since it reduces the number > of pins required for physical keys. > > Double key is configured by setting BIT(0) of the KP_SEL register. > > Enable double key matrix support based on the mediatek,keys-per-group > device tree property. > > Signed-off-by: Mattijs Korpershoek Reviewed-by: AngeloGioacchino Del Regno