Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp114385imn; Wed, 27 Jul 2022 01:01:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sIMUHUEDzJL/JOqo1sl87CQFUDyUR9DAr+pByyWugSXKz+J1u+KXKgiqDRxxgZUGZeTJmG X-Received: by 2002:a65:6850:0:b0:41a:7361:86ee with SMTP id q16-20020a656850000000b0041a736186eemr17667772pgt.486.1658908894195; Wed, 27 Jul 2022 01:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658908894; cv=none; d=google.com; s=arc-20160816; b=C0X5OwfPF2X+OPB1jnXSNHUuiy7tA+HR0H4eA0WClUal+1Tl2hS61y4OfxeHJ5K4U6 oHkkC1ZnI5bSSt0cFKdtbrRSnFWlDXIUDsBxyXj6nYwz6l5BK0ZpYGj7DdQK3af3on63 5TKwqVBzpkl84Nl7Dm9hXldaZdSook9p/Hjp0bMkriQdVZwXC4QlyoxHraOX0L8abzDl Oq9k+hrtCU9VKYS27AvCjvX1EJK+Is4OMs/cYTpiTjSGoXhp0NAFU/yoCA72KADFFWPP M6Vdm0tyTsHDYU7chbwjkPOIU4RK6Wl+hFwOIN7kJLafZJH4wKwHlfEnGZSPsHljUSXC h5Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=yZbawSuRU443TjKi4boL0Vbr518AuKIw3zU52hGnqEY=; b=UFmebAYbj5u5jxfM7R5KT4EOOKR5BBHojW88DXbnVPkSolT/jpaQA/DzOt/ts6Kz8x ReeM6O/SeinHmLJKp+3N5Jo/W2wV8ui6/OZwxe1UFGnCJICZ2fdFVEIgRqXam4ZXsduk fDAXcnTCjhcnYRGPBah8NvWwCrHbiC5l1RbBQdY6oW/G/sXPxL54G0D2+NnFt5jVZfwc P/z/UrkztFxUjF0YJrf46i9GNgdpGDRtTAW+d8yn23InuGkNS8xNXBchXnjx13TpA80V srGEtK077tMSf7cxMcnXswuJgrYI89gzOg+2rhZWj8bggq7gq5WLlGbdCRARvQKhXzHz edZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=obJ1brsK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a634707000000b0041a4f693412si18730246pga.134.2022.07.27.01.01.16; Wed, 27 Jul 2022 01:01:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=obJ1brsK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbiG0HeP (ORCPT + 99 others); Wed, 27 Jul 2022 03:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230297AbiG0HeM (ORCPT ); Wed, 27 Jul 2022 03:34:12 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8EDBE34; Wed, 27 Jul 2022 00:34:11 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id F3C026601ABE; Wed, 27 Jul 2022 08:34:08 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658907249; bh=z8qNM7YJGlGgLr5CtAhQT5G31+zHCWFzXU6yj7DoQRw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=obJ1brsK60dsAyiQVGl3tC8c/dqH6jT8h6XczYe+jJWOD5TXjCvZ7k+YZoYPqv2SF d9SRts3+EZEmgCfZoMBurFII3X8GYQHMwZPbP/oeCKOdiFisG+7JQOSp+/DDjGlSGt YR73wFCosNkFHu3hVCwzTLyssbl+MGtrAtCqAb2YaJ1vX/zs+INb7IjHiEDgbKRgD9 0NZzqX7wyZmZ6sgi651J0Belo+wY+gZSsf1MK7YHPiY8o13cQ0WKfGp3E+beQqkX4F umbSmHt00/x5gdhR0yCu4+gyUZ2tw6mrLUEdNUpfqH2r341YbP37ZP0jjzNV0lCX3M /1hF/5A7b7wAA== Message-ID: <62fa552b-6117-3f76-d3a1-e08a33f287d1@collabora.com> Date: Wed, 27 Jul 2022 09:34:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/7] Input: mt6779-keypad - prepare double keys support with calc_row_col Content-Language: en-US To: Mattijs Korpershoek Cc: linux-arm-kernel@lists.infradead.org, Fabien Parent , linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent References: <20220720-mt8183-keypad-v2-0-6d42c357cb76@baylibre.com> <20220720-mt8183-keypad-v2-4-6d42c357cb76@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220720-mt8183-keypad-v2-4-6d42c357cb76@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/07/22 14:56, Mattijs Korpershoek ha scritto: > The MediaTek keypad can operate in two modes: single key or double key. > The driver only supports single key mode. In double key mode, the > row/column calculation based on the key is different. > > Add a calc_row_col function pointer which will be different based on > single/double key mode. > > No functional change. > > Suggested-by: AngeloGioacchino Del Regno > Signed-off-by: Mattijs Korpershoek Reviewed-by: AngeloGioacchino Del Regno