Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH v2] page_alloc: fix invalid watemark check on a negative
 value
Reply-To: jaewon31.kim@samsung.com
Sender: Jaewon Kim <jaewon31.kim@samsung.com>
From:   Jaewon Kim <jaewon31.kim@samsung.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Jaewon Kim <jaewon31.kim@samsung.com>
CC:     "minchan@kernel.org" <minchan@kernel.org>,
        "bhe@redhat.com" <bhe@redhat.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "mgorman@techsingularity.net" <mgorman@techsingularity.net>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        GyeongHwan Hong <gh21.hong@samsung.com>,
        YongTaek Lee <ytk.lee@samsung.com>,
        "jaewon31.kim@gmail.com" <jaewon31.kim@gmail.com>
In-Reply-To: <20220725113707.e03007d0761423f642c15749@linux-foundation.org>
Message-ID: <20220727074619epcms1p7285bceab31c4e04406094eee84862803@epcms1p7>
Date:   Wed, 27 Jul 2022 16:46:19 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20220725113707.e03007d0761423f642c15749@linux-foundation.org>
        <20220725095212.25388-1-jaewon31.kim@samsung.com>
        <CGME20220725095214epcas1p1cc2019c792560da07d673809a3fc7ef3@epcms1p7>
Precedence: bulk

>=C2=A0=0D=0A>=C2=A0=0D=0A>---------=20Original=20Message=20---------=0D=0A=
>Sender=20:=20Andrew=20Morton=C2=A0<akpm=40linux-foundation.org>=0D=0A>Date=
=20:=202022-07-26=2003:37=20(GMT+9)=0D=0A>Title=20:=20Re:=20=5BPATCH=20v2=
=5D=20page_alloc:=20fix=20invalid=20watemark=20check=20on=20a=20negative=20=
value=0D=0A>=C2=A0=0D=0A>On=C2=A0Mon,=C2=A025=C2=A0Jul=C2=A02022=C2=A018:52=
:12=C2=A0+0900=C2=A0Jaewon=C2=A0Kim=C2=A0<jaewon31.kim=40samsung.com>=C2=A0=
wrote:=0D=0A>=0D=0A>>=C2=A0There=C2=A0was=C2=A0a=C2=A0report=C2=A0that=C2=
=A0a=C2=A0task=C2=A0is=C2=A0waiting=C2=A0at=C2=A0the=0D=0A>>=C2=A0throttle_=
direct_reclaim.=C2=A0The=C2=A0pgscan_direct_throttle=C2=A0in=C2=A0vmstat=C2=
=A0was=0D=0A>>=C2=A0increasing.=0D=0A>>=C2=A0=0D=0A>>=C2=A0This=C2=A0is=C2=
=A0a=C2=A0bug=C2=A0where=C2=A0zone_watermark_fast=C2=A0returns=C2=A0true=C2=
=A0even=C2=A0when=C2=A0the=C2=A0free=0D=0A>>=C2=A0is=C2=A0very=C2=A0low.=C2=
=A0The=C2=A0commit=C2=A0f27ce0e14088=C2=A0(=22page_alloc:=C2=A0consider=C2=
=A0highatomic=0D=0A>>=C2=A0reserve=C2=A0in=C2=A0watermark=C2=A0fast=22)=C2=
=A0changed=C2=A0the=C2=A0watermark=C2=A0fast=C2=A0to=C2=A0consider=0D=0A>>=
=C2=A0highatomic=C2=A0reserve.=C2=A0But=C2=A0it=C2=A0did=C2=A0not=C2=A0hand=
le=C2=A0a=C2=A0negative=C2=A0value=C2=A0case=C2=A0which=0D=0A>>=C2=A0can=C2=
=A0be=C2=A0happened=C2=A0when=C2=A0reserved_highatomic=C2=A0pageblock=C2=A0=
is=C2=A0bigger=C2=A0than=C2=A0the=0D=0A>>=C2=A0actual=C2=A0free.=0D=0A>>=C2=
=A0=0D=0A>>=C2=A0If=C2=A0watermark=C2=A0is=C2=A0considered=C2=A0as=C2=A0ok=
=C2=A0for=C2=A0the=C2=A0negative=C2=A0value,=C2=A0allocating=0D=0A>>=C2=A0c=
ontexts=C2=A0for=C2=A0order-0=C2=A0will=C2=A0consume=C2=A0all=C2=A0free=C2=
=A0pages=C2=A0without=C2=A0direct=C2=A0reclaim,=0D=0A>>=C2=A0and=C2=A0final=
ly=C2=A0free=C2=A0page=C2=A0may=C2=A0become=C2=A0depleted=C2=A0except=C2=A0=
highatomic=C2=A0free.=0D=0A>>=C2=A0=0D=0A>>=C2=A0Then=C2=A0allocating=C2=A0=
contexts=C2=A0may=C2=A0fall=C2=A0into=C2=A0throttle_direct_reclaim.=C2=A0Th=
is=0D=0A>>=C2=A0symptom=C2=A0may=C2=A0easily=C2=A0happen=C2=A0in=C2=A0a=C2=
=A0system=C2=A0where=C2=A0wmark=C2=A0min=C2=A0is=C2=A0low=C2=A0and=C2=A0oth=
er=0D=0A>>=C2=A0reclaimers=C2=A0like=C2=A0kswapd=C2=A0does=C2=A0not=C2=A0ma=
ke=C2=A0free=C2=A0pages=C2=A0quickly.=0D=0A>>=C2=A0=0D=0A>>=C2=A0Handle=C2=
=A0the=C2=A0negative=C2=A0case=C2=A0by=C2=A0using=C2=A0MIN.=0D=0A>>=C2=A0=
=0D=0A>=0D=0A>Thanks,=C2=A0I=C2=A0added=C2=A0cc:stable=C2=A0to=C2=A0this.=
=0D=0A>=0D=0A=0D=0ASorry=20for=20your=20inconvenience.=0D=0A=0D=0ACould=20y=
ou=20fix=20a=20typo=20by=20adding=20r=20to=20watermark=20on=20title=0D=0A=
=0D=0A-=20page_alloc:=20fix=20invalid=20watemark=20check=20on=20a=20negativ=
e=20value=0D=0A+=20page_alloc:=20fix=20invalid=20watermark=20check=20on=20a=
=20negative=20value=0D=0A=0D=0A=0D=0AI've=20appreciated=20it=20in=20advance.