Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp141806imn; Wed, 27 Jul 2022 02:07:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vc6sz0KxwIV6sB/d/B5GjBGQDxKXwxuKFTpvUTH3p+7P3xt0jz19meK0zHeHZEDGyWkGz/ X-Received: by 2002:aa7:d150:0:b0:43c:864c:51fc with SMTP id r16-20020aa7d150000000b0043c864c51fcmr5640282edo.138.1658912823409; Wed, 27 Jul 2022 02:07:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658912823; cv=none; d=google.com; s=arc-20160816; b=tL+ULsqYfRP1HaMDNHaKph2Q8tdCd1ThRKsKhwgakW+0oUg/xDT06Ar4kUJwqPDUTo PdU9b4UeGSom04RhN6VIuqTuiaih1770P8S9/TCrXINvGmH+VzxceOjufoCHGgARpx6Z rC8vOOjO6zh67KvodVyfR3KVLcQFDJtG/PnaA9IFl9AZnbEa93XAiQ5WCKrfd4XIzLM1 ch6geqPzRR1n3fsjobOFc2wFanZ3WYE1wyVCuoD3xFyAWsPOzClpHaSjMBXjvz/uNX7J jA+ZUazwiLn/eZQQbxtc7v644g967j+sfqrBKyDoLemgYvSbcyvY5v53lEDpq7D7Qusj zSNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=52YT4f2neETdfG32mraDwGLruVCe/2pjtd1VhSOaC/0=; b=J0tq7QU0yScA8kpglVsIvAaBAnWgmJLGD2zJoB2i55vwrVYbq15Dwx2SmHvKwYK5Bj H4rQBmFU3ZdzVTgUl66XINVuXt0x5MIznvFmmIDUZ39wepzgUCJTDHH2KbTe+lIjV7k0 rPSPigJvaInWABETwG0ekY6CLTOOb5aC4PX03Oq++AZpH5TjmdkR2CWHFfqFh0KpeZGT 9d2dcr/hflKbbB+ckeX9C9+bLT+BobMGQxt2muinZ7rh6Lbe184OeR3EEWqLFkpGQtlL BPTIywVmyvBHzctuAFOmvkYmeUeIq95glx+jSDoa6ytkZLzjn2myFR4qGsiOKcKpMi/E nCQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Vn8aNrDh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ev11-20020a056402540b00b0043cbf605c9fsi586611edb.64.2022.07.27.02.06.36; Wed, 27 Jul 2022 02:07:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Vn8aNrDh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbiG0IqM (ORCPT + 99 others); Wed, 27 Jul 2022 04:46:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiG0IqL (ORCPT ); Wed, 27 Jul 2022 04:46:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9362101C2; Wed, 27 Jul 2022 01:46:08 -0700 (PDT) Received: from zn.tnic (p57969665.dip0.t-ipconnect.de [87.150.150.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C6CA91EC064A; Wed, 27 Jul 2022 10:46:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658911562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=52YT4f2neETdfG32mraDwGLruVCe/2pjtd1VhSOaC/0=; b=Vn8aNrDhBbfOQkUVWZduL8uERb/KaEf9hlTAcS/86DfU3EDPg3fMqAJPILBdoKNzYJx0oC 1gkuDw8YZPTAF7d1rYbGtbehx9KSfRBhiRE+hGy4MYOUyNDsYziPEcUGxZxwmTNpDfpdZF kGNPVyqUFjMNXyCNo5gUM3DXvTFDppI= Date: Wed, 27 Jul 2022 10:45:57 +0200 From: Borislav Petkov To: Toshi Kani Cc: rric@kernel.org, mchehab@kernel.org, elliott@hpe.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] EDAC/ghes: Set the DIMM label unconditionally Message-ID: References: <20220726164628.1756924-1-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220726164628.1756924-1-toshi.kani@hpe.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2022 at 10:46:28AM -0600, Toshi Kani wrote: > The following buffer overflow BUG was observed on an HPE system. > ghes_edac_register() called strlen() on an uninitialized label, > which had non-zero values from krealloc_array(). ... > Fixes: b9cae27728d1f ("EDAC/ghes: Scan the system once on driver init") > Signed-off-by: Toshi Kani > Co-developed-by: Robert Richter > Tested-by: Robert Elliott > --- > drivers/edac/ghes_edac.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Amended and pushed out. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette