Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   tujinjiang@bytedance.com
To:     akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Jinjiang Tu <tujinjiang@bytedance.com>
Subject: [PATCH] vmscan: fix potential arbitrary pointer passed to kfree in unregister_shrinker
Date:   Wed, 27 Jul 2022 17:07:00 +0800
Message-Id: <20220727090700.3238-1-tujinjiang@bytedance.com>
Precedence: bulk

From: Jinjiang Tu <tujinjiang@bytedance.com>

when shrinker is registered with SHRINKER_MEMCG_AWARE flag,
register_shrinker will not initialize shrinker->nr_deferred,
but the pointer will be passed to kfree in unregister_shrinker
when the shrinker is unregistered. This leads to kernel crash
when the shrinker object is dynamically allocated.

To fix it, this patch initialize shrinker->nr_deferred at the
beginning of prealloc_shrinker.

Signed-off-by: Jinjiang Tu <tujinjiang@bytedance.com>
---
 mm/vmscan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index f7d9a683e3a7..06ab5a398971 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -613,6 +613,7 @@ int prealloc_shrinker(struct shrinker *shrinker)
 	unsigned int size;
 	int err;
 
+	shrinker->nr_deferred = NULL;
 	if (shrinker->flags & SHRINKER_MEMCG_AWARE) {
 		err = prealloc_memcg_shrinker(shrinker);
 		if (err != -ENOSYS)
-- 
2.17.1