Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a1f170aae331e0ad9694ad99451bfb06098d9965.camel@pengutronix.de>
Subject: Re: [PATCH v2 2/2] reset: tps380x: Add TPS380x device driver supprt
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Marco Felsch <m.felsch@pengutronix.de>, robh+dt@kernel.org,
        krzk+dt@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Date:   Wed, 27 Jul 2022 11:13:08 +0200
In-Reply-To: <20220726084518.qmb2wjcazi3djcqr@pengutronix.de>
References: <20220530092226.748644-1-m.felsch@pengutronix.de>
         <20220530092226.748644-2-m.felsch@pengutronix.de>
         <20220726084518.qmb2wjcazi3djcqr@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

Hi Marco,

On Di, 2022-07-26 at 10:45 +0200, Marco Felsch wrote:
> Hi Philipp,
> 
> gentle ping.

Applied to reset/next.

I've taken liberty to remove the TODO comment, see below:

> On 22-05-30, Marco Felsch wrote:
[...]
> > +	/*
> > +	 * Todo:
> > +	 * Add firmware handling to switch between min/typ/max reset time
> > +	 */

I've dropped this because I think waiting for max reset time is the
only way to guarantee correctness, if we expect that tps3801 delay
times actually vary between min and max reset time (whether that is due
to production variance or temperature sensitivity).

If a board vendor can guarantee that the actual max delay on a given
board is less than the specified max reset time, this could be handled
via an optional device tree parameter to overrride the delay.

regards
Philipp
>