Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp164993imn; Wed, 27 Jul 2022 02:57:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vi+bOL6uU7juqL4cJKj3k3Ww6IFvKhUs+VzJ5+fdNNg40NtAk+LjTIS484Ai4iR7CR1NiG X-Received: by 2002:a17:907:7d8e:b0:72b:9d09:5c48 with SMTP id oz14-20020a1709077d8e00b0072b9d095c48mr17529308ejc.38.1658915875394; Wed, 27 Jul 2022 02:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658915875; cv=none; d=google.com; s=arc-20160816; b=jO3RO3nxKqWrZhNwptpkps5jmZRxEhCjMGg6kTLFA3tWnMcKud+2ihB2eJTm1bxweB col34ASOdugXdeP8HbaXIGGTHXDHdfplLJITly6LSxK9/2szg/fl3Tk+dDsaa8DwbRX6 cUAG+m1nU4xVSfyH0NAIa1Skx/BP+wYt30MSvDn5PpWK5nFRHwaveG5AHS+qJrkSlq0o IVyS/NUObkmbE/Q0G1EX0QAB0a83orRDwhvhY+/YFFxjMOJ5vIXkBSk6kx3zJAfTQ5vv GCNSucTgBu7hq7IdHJMb29E/OJafegpNx6rJugZleX8Ir/hFJ6ts5gkKsb1KBfpfEXhD EUSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=pDxU8UpTzIwC16C1Npz7pNPhe0tD3l3qzIZ1ONOmOR4=; b=nn1YkPlgF0rdxB4NJXIAPHqnSPwjVlk+iCT7jOuW7ope21ihM7hFiZ9EE+CjtxREjq AXG9tx2icxa1lxQq3a75EYffle/ieM2CHBqo9bG6yE2ZE6eFbvDtG5HDQ34iAxlE4fWH hkpMBnSbbJhUi3gsLQqFWKFC4U9jB021i4fWOCr1jMIHUVfEsILBLOtl77Nl1bSKT8A3 HqmW0R2HIFHQfQwmdzpYCS8riWUWZmH/HzTXJWV+ZNKRQTuqctg3QQj6S1YBu+vZK/uX bvCL5wcJzXwE9NYtbaj8Shtf///YO62/H+x0sFXwKxsBRiM4ul6vDEzi6A2EnT9f4EAI hQMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=NeR96LvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e40-20020a056402332800b0043ba2138fcesi4482852eda.142.2022.07.27.02.57.27; Wed, 27 Jul 2022 02:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=NeR96LvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbiG0JcP (ORCPT + 99 others); Wed, 27 Jul 2022 05:32:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbiG0JcN (ORCPT ); Wed, 27 Jul 2022 05:32:13 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6813118399 for ; Wed, 27 Jul 2022 02:32:10 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id m8so20623162edd.9 for ; Wed, 27 Jul 2022 02:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pDxU8UpTzIwC16C1Npz7pNPhe0tD3l3qzIZ1ONOmOR4=; b=NeR96LvHqZ4iiknwkBuU1u7f6VpIPcxOlNjDmhTTE13tFIrwW1ooRsTz3eqVihjsyc 3eAZu96HSAb+QSXpsLzFY/XbevcakwU3HospbNRqWamftyFqJ9rJUq7bokpML3GHzzYI J/RgaW3DRCBmVFGpG7D1IlGH0KS4EmS0DsZwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pDxU8UpTzIwC16C1Npz7pNPhe0tD3l3qzIZ1ONOmOR4=; b=zVWKxQliDveS6E8+mZd3yZlJ3vO4giqi9usA5Jl0stlwM0LOM7aaInA2MsndehQ6ZE eJHs1q3ya+dWa8rOdryawLkNWo9lv6wy4bMbVlX7CHcjIb8oVrfznyIzKfkIJ9vMdlC/ U0wmQTrP7Rh+2v3ZLTxTc+hBVQLxOAMToOpENm+zWBwzV17fWpR3LBIWbCpK3abk9Efb XLenKAIDFRMlJ+k9jhUtfsmeBTEPN9BbTzOxG+4ZJFjb17E6rsvoytiBDcPbgoid7jAM F76va1z7kdQn60OwST5wh0c9u7F12Lcj8w1ZqEjvGaym6jP6orBHqs3Wf9PSFdqXwOD4 ODIw== X-Gm-Message-State: AJIora/U5s+kOWXCTkH1Vn2w95epmQqBUMuIxg+XK63qJvsXH9AK37j/ uD1x4VhnXUHuWxMXlpEMGq4aZK38BJ0xts9o35/7JQ== X-Received: by 2002:a05:6402:e96:b0:43a:f21f:42a0 with SMTP id h22-20020a0564020e9600b0043af21f42a0mr22730535eda.382.1658914328760; Wed, 27 Jul 2022 02:32:08 -0700 (PDT) MIME-Version: 1.0 References: <20220727064425.4144478-1-dlunev@chromium.org> In-Reply-To: <20220727064425.4144478-1-dlunev@chromium.org> From: Miklos Szeredi Date: Wed, 27 Jul 2022 11:31:57 +0200 Message-ID: Subject: Re: [PATCH v5 0/2] Prevent re-use of FUSE block-device-based superblock after force unmount To: Daniil Lunev Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, fuse-devel , Christoph Hellwig , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jul 2022 at 08:44, Daniil Lunev wrote: > > Force unmount of fuse severes the connection between FUSE driver and its > userspace counterpart. However, open file handles will prevent the > superblock from being reclaimed. An attempt to remount the filesystem at > the same endpoint will try re-using the superblock, if still present. > Since the superblock re-use path doesn't go through the fs-specific > superblock setup code, its state in FUSE case is already disfunctional, > and that will prevent the mount from succeeding. Applied, thanks. Miklos