Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Cao, Bingbu" <bingbu.cao@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
        "Tu, ShawnX" <shawnx.tu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: RE: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
 fwnode
Thread-Topic: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
 fwnode
Thread-Index: AQHYoOgT3BbsvDQ0lEurL8cW5qr1wa2R9Ryw
Date:   Wed, 27 Jul 2022 09:41:05 +0000
Message-ID: <DM8PR11MB56539D93300DE7709DB0F0DF99979@DM8PR11MB5653.namprd11.prod.outlook.com>
References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com>
 <20220726120556.2881-4-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220726120556.2881-4-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P/Jjm1URVSqs2a8XzQ9SCC2WYABQ6aKXZJ52sXwoAtD/Vm7HSHO21SW0GRtx?=
 =?us-ascii?Q?KiLO98yd/Z4rL9vMNDlMVD00p7iCH4Sb+AC/xXTts+gvVnL6no0hxOsPo/kL?=
 =?us-ascii?Q?Q/LfzGt1nVU2ngxp2fTyNgmpWs9qEvEgaPRVbK6hAFrDjd4x2QtfP937dIry?=
 =?us-ascii?Q?s/r4HNatOlMlG0g69AI9FBoXInx9ZiIQZ9r/jOTRLAT//5q8KsdZvm8poGp9?=
 =?us-ascii?Q?VJVBYgGQfAz1Qqx8KUUpigsQCjCJ3ggC1rb+vnfFvA8M9VJ+R4M/crO+iHOb?=
 =?us-ascii?Q?uHRbpa2JqLav7adv0w6icR72ojuBzqZWNrHYLEe7PqzpsUc/p/SC1e1VUycN?=
 =?us-ascii?Q?IjPokfJGHZ2zinEmMObgOvTp1b0zL7WwtXYPyOEUiDUZ6C+3YNCFRRbDOt0h?=
 =?us-ascii?Q?8K4l7BhZOVVCrRPdq1C9OKPKqdWi4GcOtexyisK4bG+0/VeWztKVHnAXkUjt?=
 =?us-ascii?Q?Wzyw2IxzJYjqk2705qqlFSxfJxN7aye0P9VKzsWPnOlGjonN2F2nlajdV76g?=
 =?us-ascii?Q?NokgA8MUWK0QOfTgOKbDZ6nXxeSG2I3D7CVQhP1qA3DPF9v4H+tkKT1ytWXp?=
 =?us-ascii?Q?5eZBP7OdTHgLEXXxxLcen9AIZWW3c4QuafJ3DS3sNeEkzXMUS/XihVPHJTSb?=
 =?us-ascii?Q?4dyjFvpu/4zC3NBJgaR52dCeeJ7s5cOUwgm7Bqe50LaQ9/JPZTLPTizAvtlk?=
 =?us-ascii?Q?KaEKzX68+SJ6O0TzRdCTrhT3URwp26Ve7ag+l+kGtaRa5QqcUZhC95tpU1Oi?=
 =?us-ascii?Q?USGgyXxm7Szm3lRPgy80Q2cjp/BsAmEJlMXnp+J1RYPEC6DuvnlJBGqmVtqp?=
 =?us-ascii?Q?xxGtIbSSi5CPuV4lsSMCmGPnywvohpH6AWCNN+LiLKTOBGk4oDGxUTImUp1Q?=
 =?us-ascii?Q?AbriiWZHQ28C/hm5mJkI3jPYmGMokK6LvRd1E7rXS/smMXoxRS6iRPiP9Z96?=
 =?us-ascii?Q?Sae6ObkBoNWs+bJZcCrXS7/tkDG6RXWdRB1QebBGNpOx7hUBN7Bp3kUTOdVJ?=
 =?us-ascii?Q?kFzSE+qzl+b31HWx452X8kycWZcIu3ZSu7gdZCWQPoSjnTG3csRQVM74a4o0?=
 =?us-ascii?Q?EvdYGOSFcM71lD/qL2HMSatMjTNp8EKh+OyK6qpxYPyzLnmqMhstDQc69TNO?=
 =?us-ascii?Q?Ds60KTTZbtl+JSeedA2qIXYzjLI27xEMj8tpQ7L6t8WWxsLEow4raw7FlDAU?=
 =?us-ascii?Q?H3VAt8G722csinqW8x+9U1Qv8vxTbeVT4Ob1crj5hgVLjLFz/v02T1z7GNr5?=
 =?us-ascii?Q?utiBtcSkFBq6VeSCPdGuwiMkXTZyHPrCDpLLlau6hmeVAoH3YWFNHR15zyKL?=
 =?us-ascii?Q?RiWpk4DsSNJv2yaKGk489RYGgDoGvzyHLzca74Znb3I/INUeNucJzmTxkyKI?=
 =?us-ascii?Q?l3TRjPc1JUAtrN4ODyLrSlGJpO5lHmeTonGv6UczA2SwYc6Sq5ZD0oGt5neN?=
 =?us-ascii?Q?BDUaNgtZlTL8ZfjbsP12Q0YMCFfX/Y7aCx28dFACULFYgotd+jdZArpFkO7P?=
 =?us-ascii?Q?gI3Wstp7yS+YdWFSFeBBxvHXVVvOkXWEeByasFxEkrbV173vtt89404SBHSz?=
 =?us-ascii?Q?8Yfg9vFM4Zx80fC1SisuU7oPuE5eUNGzMmO9dmCy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68306f78-758a-4ff3-29ca-08da6fb42061
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 09:41:05.3756
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NPlHbhDriZib8wX/l+aeq5vK6XCPqnfz2LyFviHbWk1IGq6xizXd/QLxdybmn+ImkK0cniG967v/9OESlyny7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2815
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Andy

Thanks for your patch.

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

________________________
BRs, =20
Bingbu Cao=20

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Qiu, Tian Shu <tian.shu.qiu@intel.com>; Tu, ShawnX
> <shawnx.tu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>
> Subject: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
> fwnode
>=20
> fwnode API does proper checks and returns correct codes, no need to repea=
t
> it in the caller.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/i2c/ov2740.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c inde=
x
> 9420258c6073..07fe8fda274e 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -1009,9 +1009,6 @@ static int ov2740_check_hwcfg(struct device *dev)
>  	int ret;
>  	unsigned int i, j;
>=20
> -	if (!fwnode)
> -		return -ENXIO;
> -
>  	ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
>  	if (ret)
>  		return ret;
> --
> 2.35.1