Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Cao, Bingbu" <bingbu.cao@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
        "Tu, ShawnX" <shawnx.tu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: RE: [PATCH v1 7/8] media: ov2740: Add missed \n to the end of the
 messages
Thread-Topic: [PATCH v1 7/8] media: ov2740: Add missed \n to the end of the
 messages
Thread-Index: AQHYoOgTCK3PndfoK02A1T2sPMnCeq2R/cfw
Date:   Wed, 27 Jul 2022 10:01:19 +0000
Message-ID: <DM8PR11MB56539B719C80F54BC0EBF8C299979@DM8PR11MB5653.namprd11.prod.outlook.com>
References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com>
 <20220726120556.2881-7-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220726120556.2881-7-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sp7PdJsoe8XCyjXh0iEurXqIXZcOw9VCVRX9Uu09yLU3LyREoNDXQtmNdFLg?=
 =?us-ascii?Q?SWTNZVqUeqoIa36B+KmuhDibSj8aGbnTWgbjj8hqw1wFVgBiLtb+aZ83Wn+K?=
 =?us-ascii?Q?26ljkIMtM8iKdFdA/FKV41ilEMOIFO6D4Hc5gRbWsSwEWmJ0O9RCFDYfD9wr?=
 =?us-ascii?Q?2R+DNrIb/eTKlzjmKPbJZdZPG3AuwMY7K2NZSrBVOhEoWjPE6SO/1mPGAJ+M?=
 =?us-ascii?Q?E+WADYQhWZPGma2H4PxJCLHn/WcEOP0LpOsV1ScEBNhfOQpJPXOWw/suOziT?=
 =?us-ascii?Q?eBDiT4GNa+oGboDRkvovHTQYOKYplRvibwyz2MtiuSkJ3vMuBofRIxglMlM2?=
 =?us-ascii?Q?EgQpwaZhLo6IyJpkQGdagVYnJMhkfGb6c/xXdUKvdQTsxr4b2a92NC5IGbcd?=
 =?us-ascii?Q?Wyf5YVzHrwjrEk70s4GlKC+zI52amibLfVbLx3YfadkVJEfw7eIRmIsT3SbS?=
 =?us-ascii?Q?68W2bYbth3YP0VwvDu8aiCTcK8kUaGd8AXYENl4+HSXofM7s3MH2Dh8soDpQ?=
 =?us-ascii?Q?axT1yzLftTQ3p8zmZYfYc0TLh8gsrOOyMWA7sQbhDMifNr644YCpdDvU2L2g?=
 =?us-ascii?Q?Q3+gaQpouB0h5CFUGCQZwBnpTc9cQqD7BXo/owmLcXe9LAJpq2QmR3ppGCKG?=
 =?us-ascii?Q?6dKu85gJRpkxJGgEtSobIiRrHfmKiHX2zGfZ9+cx3IpAxmu2rhps8Fu15/oD?=
 =?us-ascii?Q?KEG+GUDqvSrmAptnGfvy42S7nRg9mDjgd65hBsIOyzRVy31qx5etAXxu9Dwo?=
 =?us-ascii?Q?VeFoANQzrT53nsjEa+TAgzfdFFrIgumi5dlmNk4gVUlhCOX6B0w/gvS9C4ZF?=
 =?us-ascii?Q?E203o0DMfdq3n72HKEy/aOWdZMEYgAa8VxZJPuXZdTR/423OF7QbktDlVWt0?=
 =?us-ascii?Q?VZaj9oBFgmSUtne2PuPEj6api2JOwAZVR1qpx/c6gcvONEi6eObISgDJ/5m2?=
 =?us-ascii?Q?P9rADhDHUWIRyxyIiT4MGZ38D/kVnaGBX+ozm6XEz+mDemdal24yLeFu9VnA?=
 =?us-ascii?Q?cl2G2HiTC2wiRBZ3M2yGyvVtpn4piRO8SxEjLS7R7ZcrhCpAabdzaJ7UqsIs?=
 =?us-ascii?Q?o2nlDnpuChn6vol80gS2uB5FZLMEH364+STz4e2KNNA+v2Mx0++ldl49wjXF?=
 =?us-ascii?Q?3NUaLHFwLM6e+id96ckwRQgWovT1ULYpjbhCM/q/Rf5Kv7sZi7qM8A3uk5+N?=
 =?us-ascii?Q?dr5tRTGknLTq7djlTxdRrZd/OF6kz37JGal4Q4ZOYRhdfPm+btISEDHHtP6O?=
 =?us-ascii?Q?RKwNj2OFBKhhdlpZBQ83RnRNWkqt24DXtjX5xsOxT2TTRzxUJx6z//1pyzOC?=
 =?us-ascii?Q?CpjbYC2mj3HOl37ZFS6jOpMD3cMCKFurV37tecSGxWOD7MDFJeWMFimhy328?=
 =?us-ascii?Q?M5G1+U7XNJav+SZ4mJPnDQWJfpNlhuYgoB5Tw3DVa6KZWROa8O6SYSHHw/op?=
 =?us-ascii?Q?53SAmzXcIsOYCTtmg6eapR1FAyqeRqwJHGAnx8jfojyDEbIorTZkHqQ1WVOl?=
 =?us-ascii?Q?r021B1i8oN3CpuiGaW+878hzX6w841TfUIdOYzkau+jwZposmBJhEzB+b5jh?=
 =?us-ascii?Q?bUVuoVq3S8XpIUgJOuUgJRRF1TNhNEv+3EZehosQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df0d5e39-3381-440d-ead6-08da6fb6f438
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 10:01:19.7822
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZJga+yhlhT8zZE5WYjW7eQI9GbkLjZftn3gyL4thvg1y3Jp+IcPN1cKLjjm7a7Kh4u3BrtB9ShRr9n1Yhj9jgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6732
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

________________________
BRs, =20
Bingbu Cao=20

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Qiu, Tian Shu <tian.shu.qiu@intel.com>; Tu, ShawnX
> <shawnx.tu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>
> Subject: [PATCH v1 7/8] media: ov2740: Add missed \n to the end of the
> messages
>=20
> Add missed \n to the end of the messages.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/i2c/ov2740.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c inde=
x
> 7271e3d011c9..c4c511f90257 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -451,7 +451,7 @@ static int ov2740_write_reg_list(struct ov2740 *ov274=
0,
>  				       r_list->regs[i].val);
>  		if (ret) {
>  			dev_err_ratelimited(&client->dev,
> -					    "write reg 0x%4.4x return err =3D %d",
> +					    "write reg 0x%4.4x return err =3D %d\n",
>  					    r_list->regs[i].address, ret);
>  			return ret;
>  		}
> @@ -474,7 +474,7 @@ static int ov2740_identify_module(struct ov2740
> *ov2740)
>  		return ret;
>=20
>  	if (val !=3D OV2740_CHIP_ID) {
> -		dev_err(&client->dev, "chip id mismatch: %x!=3D%x",
> +		dev_err(&client->dev, "chip id mismatch: %x !=3D %x\n",
>  			OV2740_CHIP_ID, val);
>  		return -ENXIO;
>  	}
> @@ -772,14 +772,14 @@ static int ov2740_start_streaming(struct ov2740
> *ov2740)
>  	reg_list =3D &link_freq_configs[link_freq_index].reg_list;
>  	ret =3D ov2740_write_reg_list(ov2740, reg_list);
>  	if (ret) {
> -		dev_err(&client->dev, "failed to set plls");
> +		dev_err(&client->dev, "failed to set plls\n");
>  		return ret;
>  	}
>=20
>  	reg_list =3D &ov2740->cur_mode->reg_list;
>  	ret =3D ov2740_write_reg_list(ov2740, reg_list);
>  	if (ret) {
> -		dev_err(&client->dev, "failed to set mode");
> +		dev_err(&client->dev, "failed to set mode\n");
>  		return ret;
>  	}
>=20
> @@ -790,7 +790,7 @@ static int ov2740_start_streaming(struct ov2740
> *ov2740)
>  	ret =3D ov2740_write_reg(ov2740, OV2740_REG_MODE_SELECT, 1,
>  			       OV2740_MODE_STREAMING);
>  	if (ret)
> -		dev_err(&client->dev, "failed to start streaming");
> +		dev_err(&client->dev, "failed to start streaming\n");
>=20
>  	return ret;
>  }
> @@ -801,7 +801,7 @@ static void ov2740_stop_streaming(struct ov2740
> *ov2740)
>=20
>  	if (ov2740_write_reg(ov2740, OV2740_REG_MODE_SELECT, 1,
>  			     OV2740_MODE_STANDBY))
> -		dev_err(&client->dev, "failed to stop streaming");
> +		dev_err(&client->dev, "failed to stop streaming\n");
>  }
>=20
>  static int ov2740_set_stream(struct v4l2_subdev *sd, int enable)
> --
> 2.35.1