Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Cao, Bingbu" <bingbu.cao@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
        "Tu, ShawnX" <shawnx.tu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: RE: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
 fwnode
Thread-Topic: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
 fwnode
Thread-Index: AQHYoOgT3BbsvDQ0lEurL8cW5qr1wa2R/aEg
Date:   Wed, 27 Jul 2022 10:01:02 +0000
Message-ID: <DM8PR11MB5653DB7732D4EA48A1D45CCC99979@DM8PR11MB5653.namprd11.prod.outlook.com>
References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com>
 <20220726120556.2881-4-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220726120556.2881-4-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vUG2Q0h1ZvpCP/hOt4+Zu4uVLLJX8cDB0HKAB5PLprF6G2WOD32fisPca3Z+?=
 =?us-ascii?Q?6uGdwK4PWdu6aAoNocFqT2ZpqNu7F1JIf1q44RSYaIfaKvj0oskJD02GB6D4?=
 =?us-ascii?Q?LuS0JKNWfVAWPQn+1L21Gvm3V/RUWPJ6xmLWqyl4lxPIABw0EbNJ3n71ZfB4?=
 =?us-ascii?Q?of9eA6MCS3UCSrF7L5U3xXNHrxAfqE3ee/pswC1ooSUgcxuLB9D0OlhQDYvH?=
 =?us-ascii?Q?kLKBzUP2DXO+/bXGC7s2JUnT7qFStAPVz3E4YRgLLr1HWBt7FgGIL9on9PUM?=
 =?us-ascii?Q?hIV5QPOkMntxj8Mnbw8L32OinU9L67sTsCLnu7R1/6k8gY95VqNBbzNDVpxS?=
 =?us-ascii?Q?m6oxTmgvuInU7LIt5RFfunxOmYzLuMALV2k3FxjTF6Ye5tlQDe7Sx1mVKvdf?=
 =?us-ascii?Q?zwDj0ZNBKpYlXkWlvChh9GjBEylYelBLfn00hC64EMkumuZs1BIt8o/2v+YF?=
 =?us-ascii?Q?31g56pd68DSNReF1Ql7wB7Qx/0pg3eVYImBRzVFVRYVpLJUexrf0yFpXrcZS?=
 =?us-ascii?Q?E2lnA9JO+5dHIe5XojHSf/Rv1orFqsybSCGWxw8Ok+5Warkuyt61L9OBODv4?=
 =?us-ascii?Q?R7GkPuQTNgy6/8Es0NSDzglF56RVCapuMrIPzjc5o8jId10+1VSqc8gaC5K7?=
 =?us-ascii?Q?2hRKYOzemn5VNYrWC631p3PcrJvQaQjKLHhl43gOn99sRjgn+XA6McwGOBbA?=
 =?us-ascii?Q?EH1Yz5jG8k8jQbQucMeaOLm91/JFSF6HaeKtTYqhS89qUVxdbXPWL7kc0u4b?=
 =?us-ascii?Q?x//bQIvbCuTz1snXNojLUyhCYotkJSWefzWpyNVLs2uFNlRiJk7mQ20xwMqx?=
 =?us-ascii?Q?2Nd/wAteb0EgFYjqol9nXuJRLJ4L8dnLGQFIYhccrTDrUC7iX1Y33xsZgr/L?=
 =?us-ascii?Q?oJM2h9nL59dqBlJfWTpqz+GfAV5EgLse1orjmWqjqH5FAdAmKZ1IntjA4DZp?=
 =?us-ascii?Q?KaWF6v3jE2oQ/4k3pTxwHoQd1LvSY2sDAS/PO0JKY5VUGEEKlO7ELpXLQjtp?=
 =?us-ascii?Q?x2j1xcg6eXleYwMUKTP9kZ0702gheWJmVgu3FcsqWMJO3Ne9sqkQO2UbI+D0?=
 =?us-ascii?Q?hkA7a5KinD1Jl0jUQAW0F7HoO3tYrTryV7HkJICmMmn49GpqOX7CkOCZMQuV?=
 =?us-ascii?Q?wF18w85/erLf5NE0f5rKLvZiNbCwbTsehoYn2e6sCVo1FGSp35qUy0LP41gF?=
 =?us-ascii?Q?rKU7jUFW8DNCJOylkGww79J0rnzqm/H/I3wj2KOl28nos0yr8Dp/X040pnM1?=
 =?us-ascii?Q?YtVOkwG42CRdDHH/KH8o7EqMg7qJYQouRNVcl+oSJ7mrHfeziLDsra+m7vC7?=
 =?us-ascii?Q?pIfVQMy5SD+WGAq7TYxVqHGvr6rWWs/stNowUpulqbPLhwegsDzJf6VbBk7l?=
 =?us-ascii?Q?XeV40+lTEkyO9gCdQvOwLTH0uPfKumBB7pkBfesq1L5Sk2SRn45cEKOjX63j?=
 =?us-ascii?Q?UkwSuhyfoUnJa5q545F7sQiHLQsGyvYYluvRPbPL2bVUx0H2s3NSJ78COi+s?=
 =?us-ascii?Q?z5h3015PfgJhxXNe9l0QgsXgEVTXvOoVNAt+Opc58o1D0lj/+MVDAxiB6yLW?=
 =?us-ascii?Q?1GprSgn/Lx5CF/ctgqmSfXTmZ/iKY1dUGugmHK3h?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0be194-ecc1-4c82-37a2-08da6fb6e9bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 10:01:02.2075
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HAndfCU8vgVXL5poWMNDEcGHwmaKlrfVn/0Q1Z56Re2lSKXtjv0KXyf7gsFUdlxy5GioGS28zivxmCGIOS3I/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6732
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

________________________
BRs, =20
Bingbu Cao=20

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Qiu, Tian Shu <tian.shu.qiu@intel.com>; Tu, ShawnX
> <shawnx.tu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>
> Subject: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
> fwnode
>=20
> fwnode API does proper checks and returns correct codes, no need to repea=
t
> it in the caller.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/i2c/ov2740.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c inde=
x
> 9420258c6073..07fe8fda274e 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -1009,9 +1009,6 @@ static int ov2740_check_hwcfg(struct device *dev)
>  	int ret;
>  	unsigned int i, j;
>=20
> -	if (!fwnode)
> -		return -ENXIO;
> -
>  	ret =3D fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
>  	if (ret)
>  		return ret;
> --
> 2.35.1