Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 13:28:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marcin Wojtas <mw@semihalf.com>
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        netdev@vger.kernel.org, rafael@kernel.org, sean.wang@mediatek.com,
        Landen.Chao@mediatek.com, linus.walleij@linaro.org, andrew@lunn.ch,
        vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux@armlinux.org.uk, hkallweit1@gmail.com,
        gjb@semihalf.com, jaz@semihalf.com, tn@semihalf.com,
        Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com
Subject: Re: [net-next: PATCH v3 2/8] net: mdio: switch fixed-link PHYs API
 to fwnode_
Message-ID: <YuETUjgDzKjvM6lb@smile.fi.intel.com>
References: <20220727064321.2953971-1-mw@semihalf.com>
 <20220727064321.2953971-3-mw@semihalf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220727064321.2953971-3-mw@semihalf.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jul 27, 2022 at 08:43:15AM +0200, Marcin Wojtas wrote:
> fixed-link PHYs API is used by DSA and a number of drivers
> and was depending on of_. Switch to fwnode_ so to make it
> hardware description agnostic and allow to be used in ACPI
> world as well.

...

> +	/* Old binding */
> +	len = fwnode_property_count_u32(fwnode, "fixed-link");
> +	if (len == 5)
> +		return true;
> +
> +	return false;

Can be

	return len == 5;

or

	return fwnode_...(...) == 5;

Original also good, so up to you,

...

> +		if (fwnode_property_read_u32(fixed_link_node, "speed",
> +					     &status.speed)) {
> +			fwnode_handle_put(fixed_link_node);
> +			return -EINVAL;
> +		}

Why shadowing actual error code?

Either

	ret = fwnode_...(...);
	if (ret) {
		...
		return ret;
	}

or add a comment explaining the above magic transformations.

...

> +	/* Old binding */
> +	if (fwnode_property_read_u32_array(fwnode, "fixed-link", fixed_link_prop,
> +					   ARRAY_SIZE(fixed_link_prop)) == 0) {
> +		status.link = 1;
> +		status.duplex = fixed_link_prop[1];
> +		status.speed  = fixed_link_prop[2];
> +		status.pause  = fixed_link_prop[3];
> +		status.asym_pause = fixed_link_prop[4];
> +		goto register_phy;
> +	}
> +
> +	return -ENODEV;

Ditto.

-- 
With Best Regards,
Andy Shevchenko