Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Cao, Bingbu" <bingbu.cao@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
        "Tu, ShawnX" <shawnx.tu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: RE: [PATCH v1 6/8] media: ov2740: Switch to use dev_err_probe()
Thread-Topic: [PATCH v1 6/8] media: ov2740: Switch to use dev_err_probe()
Thread-Index: AQHYoOgVZRiE1du5qUyV0ggsCc6Y3q2R/0Yg
Date:   Wed, 27 Jul 2022 10:06:47 +0000
Message-ID: <DM8PR11MB5653E201B8116E1F47FE759499979@DM8PR11MB5653.namprd11.prod.outlook.com>
References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com>
 <20220726120556.2881-6-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220726120556.2881-6-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PSKxTQmZc38Ii52A4evj3SjBQ1qnC5d63gX5JD6qhxzfCMxQTWvDadF+JgVw?=
 =?us-ascii?Q?PRZmO0o2ZSpPOOALk+BEEGetOt9UWWpUr0T7mCeQ/w8t9TT0TGQWMnIWJXfu?=
 =?us-ascii?Q?A4FnonccNAqhoxKd4TUQodIdDXucdt0Py1ktMOxIpsQ6vkB/jd34ARHZM4TE?=
 =?us-ascii?Q?0JU20hckI8FwcB6ASj/gUkxUDU+f+O+syt1cSGQz4Z4FfaOefZB9rX9lS5fV?=
 =?us-ascii?Q?/jobw4PNfpEC4Y+Vq+LqTmwe+BcATPodQ46iDn/INbP1HI5LHE2C1W/60KFj?=
 =?us-ascii?Q?1ivnD7CdJm+g3PPel4qQweA1todgZFbkF6bzCaIbReqgxcie/Zsnn0x0Xupu?=
 =?us-ascii?Q?BQE7V1gQQigwnrEwE2CPd+bgEvaFE5IfbthF1IpQCvHViderq5jOTz6sUqfk?=
 =?us-ascii?Q?p4pFn6VJXtdldBIle8wQWMF52a6BVmBpFxv8/mIBVZJ2e6oBQgKKLrFdl4jm?=
 =?us-ascii?Q?kTqpyy3e1i14ejxodr5O9sM0X3OFZHi6PnXtg+nTVfGfvgh19c1SkCw2W2GP?=
 =?us-ascii?Q?8WyCYWDL0UWmBh4fla1kOER+4vrIqm0Anl+WrbW91ITgmhNLajCiACNc4HL7?=
 =?us-ascii?Q?/lSl4ATUpfBxfFxoS5tsQVlVhlbMmE3dnQPDWPiEB9zEocO63X0zSgDDFVvc?=
 =?us-ascii?Q?DnZBu/ZXSWPJwIM1vSP7qudtOwUrWno1JzMCryuGRhFSYWRxmpv8YYQ6NmzC?=
 =?us-ascii?Q?ot5dM1NK5l7AMdSnwPEf6geJjKgdL0TPVPIMfJ6dDzfo5MedUshQaikMyzfV?=
 =?us-ascii?Q?5NqrjdydRUU8MUJRW4Q3CjoucK8M1anK2RYYI/CIabicxpaTj69LAr/w7Zfj?=
 =?us-ascii?Q?bxpRdMvmhe813vrYTqYf4vPCzT9Yk2BSyfq8D0hXKt5VeJ9MJiq2xXcgqSzM?=
 =?us-ascii?Q?JkmpzqgWq1JgoJu6q2ityn1qtTvHGwWoZJSmler84gDCVWlqSFx1OJVfhJaf?=
 =?us-ascii?Q?Z2kTco09259JR4drcfztFAcMAWhyd2SKbIOH9SSErJvPid0NsKwbqO+m5uCm?=
 =?us-ascii?Q?JPG5DHuqY4ggM3hAG1QqZkwDKGWQsiRuZH2X5JBpQhhvto3EC5c9ngUbeYXF?=
 =?us-ascii?Q?qgTv4UheVA1QaLuGoUE8u0JSrkDFd4lEAFVvEK1Ge14drkhO+PtLtOKS7j6x?=
 =?us-ascii?Q?1IH4mswVCiCUZ6nQUq8Z7e+8ESUkyt4Yq3c/QuD6+hBv4/UNX7S/ofBvdLZ9?=
 =?us-ascii?Q?qlY3J1w0OrpwVSrWywPmQddsxLhkIUGrxdHey5SQVQhHDi9SrKVHa4licsZ4?=
 =?us-ascii?Q?dzCA1X++UYoTtN5Eq2rv9pzgCpWIqN2cXahKxJpKJwJBSB9npVprDpRnrVJi?=
 =?us-ascii?Q?C/dJ+DO/9mGDXM56NjgBLsYFkHPbUCtOr0dhsMrFXt4Z0ZGRfyi6hi1ZnxRv?=
 =?us-ascii?Q?7+ZNcYHbkBV8pjSgeMBqvyYxmoZ7j2eln9y7X029ZbjN5EHuj6vVYXnEvJrn?=
 =?us-ascii?Q?Q3AIHMPX9bT2tvWe+0XgrIyBf/+fXbtthVc8OQzA97OlsmY3+K2K8wfS1SIE?=
 =?us-ascii?Q?FZeUy8oWz9hWl5kTH2iBn4NFyZvYz10yFRL3Vg0+HxS/4hJih403XXHcINHN?=
 =?us-ascii?Q?l1avDBVrFoAXHw+pJstlWB/JdtAHrnIn3iRivQ3s?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e5a7df6-16cd-4046-0a4a-08da6fb7b77a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 10:06:47.4117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cYflpVH6MonI2w3urgTFOmjWAgBixbKCw2jiy9HDCFZjzIXMkjsiIW918J8lM9DuKYcvoAi54vd2PNlm/c8D6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5366
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
________________________
BRs, =20
Bingbu Cao=20

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Qiu, Tian Shu <tian.shu.qiu@intel.com>; Tu, ShawnX
> <shawnx.tu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>
> Subject: [PATCH v1 6/8] media: ov2740: Switch to use dev_err_probe()
>=20
> Switch to use dev_err_probe() to simpify error path and unify message
> template.
>=20
> While at it, add missed \n to the end of the messages.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/i2c/ov2740.c | 44 ++++++++++++++++----------------------
>  1 file changed, 19 insertions(+), 25 deletions(-)
>=20
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c inde=
x
> 212190cb14e4..7271e3d011c9 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -1013,10 +1013,10 @@ static int ov2740_check_hwcfg(struct device *dev)
>  	if (ret)
>  		return ret;
>=20
> -	if (mclk !=3D OV2740_MCLK) {
> -		dev_err(dev, "external clock %d is not supported", mclk);
> -		return -EINVAL;
> -	}
> +	if (mclk !=3D OV2740_MCLK)
> +		return dev_err_probe(dev, -EINVAL,
> +				     "external clock %d is not supported\n",
> +				     mclk);
>=20
>  	ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL);
>  	if (!ep)
> @@ -1028,15 +1028,14 @@ static int ov2740_check_hwcfg(struct device *dev)
>  		return ret;
>=20
>  	if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D OV2740_DATA_LANES) {
> -		dev_err(dev, "number of CSI2 data lanes %d is not supported",
> -			bus_cfg.bus.mipi_csi2.num_data_lanes);
> -		ret =3D -EINVAL;
> +		ret =3D dev_err_probe(dev, -EINVAL,
> +				    "number of CSI2 data lanes %d is not
> supported\n",
> +				    bus_cfg.bus.mipi_csi2.num_data_lanes);
>  		goto check_hwcfg_error;
>  	}
>=20
>  	if (!bus_cfg.nr_of_link_frequencies) {
> -		dev_err(dev, "no link frequencies defined");
> -		ret =3D -EINVAL;
> +		ret =3D dev_err_probe(dev, -EINVAL, "no link frequencies
> defined\n");
>  		goto check_hwcfg_error;
>  	}
>=20
> @@ -1048,9 +1047,9 @@ static int ov2740_check_hwcfg(struct device *dev)
>  		}
>=20
>  		if (j =3D=3D bus_cfg.nr_of_link_frequencies) {
> -			dev_err(dev, "no link frequency %lld supported",
> -				link_freq_menu_items[i]);
> -			ret =3D -EINVAL;
> +			ret =3D dev_err_probe(dev, -EINVAL,
> +					    "no link frequency %lld supported\n",
> +					    link_freq_menu_items[i]);
>  			goto check_hwcfg_error;
>  		}
>  	}
> @@ -1153,16 +1152,14 @@ static int ov2740_register_nvmem(struct i2c_clien=
t
> *client,
>=20
>  static int ov2740_probe(struct i2c_client *client)  {
> +	struct device *dev =3D &client->dev;
>  	struct ov2740 *ov2740;
>  	bool full_power;
>  	int ret;
>=20
>  	ret =3D ov2740_check_hwcfg(&client->dev);
> -	if (ret) {
> -		dev_err(&client->dev, "failed to check HW configuration: %d",
> -			ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to check HW
> configuration\n");
>=20
>  	ov2740 =3D devm_kzalloc(&client->dev, sizeof(*ov2740), GFP_KERNEL);
>  	if (!ov2740)
> @@ -1172,17 +1169,15 @@ static int ov2740_probe(struct i2c_client *client=
)
>  	full_power =3D acpi_dev_state_d0(&client->dev);
>  	if (full_power) {
>  		ret =3D ov2740_identify_module(ov2740);
> -		if (ret) {
> -			dev_err(&client->dev, "failed to find sensor: %d",
> ret);
> -			return ret;
> -		}
> +		if (ret)
> +			return dev_err_probe(dev, ret, "failed to find
> sensor\n");
>  	}
>=20
>  	mutex_init(&ov2740->mutex);
>  	ov2740->cur_mode =3D &supported_modes[0];
>  	ret =3D ov2740_init_controls(ov2740);
>  	if (ret) {
> -		dev_err(&client->dev, "failed to init controls: %d", ret);
> +		dev_err_probe(dev, ret, "failed to init controls\n");
>  		goto probe_error_v4l2_ctrl_handler_free;
>  	}
>=20
> @@ -1193,14 +1188,13 @@ static int ov2740_probe(struct i2c_client *client=
)
>  	ov2740->pad.flags =3D MEDIA_PAD_FL_SOURCE;
>  	ret =3D media_entity_pads_init(&ov2740->sd.entity, 1, &ov2740->pad);
>  	if (ret) {
> -		dev_err(&client->dev, "failed to init entity pads: %d", ret);
> +		dev_err_probe(dev, ret, "failed to init entity pads\n");
>  		goto probe_error_v4l2_ctrl_handler_free;
>  	}
>=20
>  	ret =3D v4l2_async_register_subdev_sensor(&ov2740->sd);
>  	if (ret < 0) {
> -		dev_err(&client->dev, "failed to register V4L2 subdev: %d",
> -			ret);
> +		dev_err_probe(dev, ret, "failed to register V4L2 subdev\n");
>  		goto probe_error_media_entity_cleanup;
>  	}
>=20
> --
> 2.35.1