Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 13:30:54 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        michael@amarulasolutions.com,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        Jeroen Hofstee <jhofstee@victronenergy.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH v3 8/9] can: slcan: add support to set bit time
 register (btr)
Message-ID: <20220727113054.ffcckzlcipcxer2c@pengutronix.de>
References: <20220726210217.3368497-1-dario.binacchi@amarulasolutions.com>
 <20220726210217.3368497-9-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wo6f23lv67r22v2k"
Content-Disposition: inline
In-Reply-To: <20220726210217.3368497-9-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--wo6f23lv67r22v2k
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.07.2022 23:02:16, Dario Binacchi wrote:
> It allows to set the bit time register with tunable values.
> The setting can only be changed if the interface is down:
>=20
> ip link set dev can0 down
> ethtool --set-tunable can0 can-btr 0x31c
> ip link set dev can0 up

As far as I understand, setting the btr is an alternative way to set the
bitrate, right? I don't like the idea of poking arbitrary values into a
hardware from user space.

Do you have a use case for this?

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--wo6f23lv67r22v2k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmLhIesACgkQrX5LkNig
013QcAgAki/APZw2NZdx7MYizFEMgcZs7wph/ASDUdNrNRR41Q+qDqxCS3MMn+Sx
mbORSwe2pNt1z1CrjnOMqHLNWCZ86ejIHa52iGlWOGhc88oC9U5wKk2kTP97C8tf
Pd+vsu1J/cA53Z2dmDfIrl58+xRJOdqfRzvh4J/nL0AfXfTjvXCVFGIBN/Dv8JXp
6caqLbi3HRCp0gJ87lWk8TnLvJ2rlLXHVYHxwe6+tZ3CJn7/HaB69mBVDPEGE1sg
6laYbxsGKk9qiD+Is8lvHzWUT3Bq8Gniu+vpp8GV6cnxeBSCLDUIChPK+kLhbYkz
bpo+kfyfBJgF2W6pVbapeLD4BiFhVA==
=bFCW
-----END PGP SIGNATURE-----

--wo6f23lv67r22v2k--