Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220727064415.940690-1-potin.lai.pt@gmail.com>
 <CAHp75VfNmq12Yv7mqVeijqK0vwRdPsSrH5wMzg9qR15+t7ArSQ@mail.gmail.com> <a385e266-b24e-7ffb-c083-891edd4b0b14@gmail.com>
In-Reply-To: <a385e266-b24e-7ffb-c083-891edd4b0b14@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 27 Jul 2022 13:56:43 +0200
Message-ID: <CAHp75VdjvJRwzPLLdMji+_m2tQY4JLBcNwt-QFkDJTyGFUOdKg@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] iio: humidity: hdc100x: add manufacturer and
 device ID cehck
To:     Potin Lai <potin.lai.pt@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Patrick Williams <patrick@stwcx.xyz>,
        Potin Lai <potin.lai@quantatw.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 27, 2022 at 12:42 PM Potin Lai <potin.lai.pt@gmail.com> wrote:
> On 7/27/22 18:00, Andy Shevchenko wrote:
> > On Wed, Jul 27, 2022 at 8:46 AM Potin Lai <potin.lai.pt@gmail.com> wrote:

...

> >> +       data = device_get_match_data(&client->dev);
> >> +       if (data) {
> > This check is redundant. Too much protective programming. Just oblige
> > that matched ID has to always have an associated data.
> Is it guaranteed that device_get_match_data will not return NULL? I find some examples in other drivers, all of them have a check on returned data.

No, but as I said you may guarantee that by obliging developers not to
shoot in their feet.

> Will it be more appropriate if I move device_get_match_data to probe function, and return EINVAL when we get a NULL pointer from device_get_match_data?

Why is this check needed? We do not like dead code.

> >> +               if (!data->support_mfr_check)
> >> +                       return true;
> >> +       }

-- 
With Best Regards,
Andy Shevchenko