Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   William Kucharski <william.kucharski@oracle.com>
To:     Yongqiang Liu <liuyongqiang13@huawei.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "zhangxiaoxu5@huawei.com" <zhangxiaoxu5@huawei.com>,
        "yanaijie@huawei.com" <yanaijie@huawei.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH] mm/folio-compact: fix potential NULL pointer in
 pagecache_get_page
Thread-Topic: [PATCH] mm/folio-compact: fix potential NULL pointer in
 pagecache_get_page
Thread-Index: AQHYoa2x/5ssiZt4Vk+oe4Am08PSlw==
Date:   Wed, 27 Jul 2022 11:40:38 +0000
Message-ID: <B92F20D6-595A-4B7F-95CA-7C681C2AF79D@oracle.com>
References: <20220727064621.534528-1-liuyongqiang13@huawei.com>
In-Reply-To: <20220727064621.534528-1-liuyongqiang13@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BNU2cwr0dMW1hV2+JB/OxjReH5uOWHtYN/jtDcpQj7MO27JUymGNIn+uN7+W?=
 =?us-ascii?Q?926OI+SPM92FoyaaAZTqDAjNbozsU1AlYo1YrYkP04QKm6jttMp2PzbUfCi6?=
 =?us-ascii?Q?AObn9mgNYyolKFBKhMAR9l3k+JVguWMXYkmHzuSD4jzlLSic93zO4Agbgp90?=
 =?us-ascii?Q?thUOS2mFn9h75tIP+8/ekALSlPrf704Kqqm3WcIajwAz/dv8UTPmxYYEOmXu?=
 =?us-ascii?Q?W/VBK5HyPF93I7IwcrR0ZoZ8kI8AiK6HQ31cGmysha8USHJMlUcM3JM7O7Zd?=
 =?us-ascii?Q?BsI6RUbjxp0q42bJwbPohtfhQRZgYQniit32OWElkpmrshRCP65IOY6Is9bx?=
 =?us-ascii?Q?YGd8oz0FqFPIpzqjNvE1tRuooiinPPaYtjAvl4OSGkVXPU/TBJYD7Q9JjSeb?=
 =?us-ascii?Q?aw/L4JjO/bwiZru70vdNWJoXr+J10nejjQNoT/3QttWzf6J4Qg60dm+MMm14?=
 =?us-ascii?Q?pUWYyLkbXy7O5qIm2Bz7arpgvDm2S+IUTiEvWYIjT5glB1eAwGwUtlUuGF4T?=
 =?us-ascii?Q?1Po+iW+8V/kNFF1VQzXcO4KFR9zMgcgu+YiPKIze7lkXjlpQLBRA/MUTem8D?=
 =?us-ascii?Q?YE5zEO5sK4gZ2o0t2LPfFcUHGexYjAe+Lsd9Cxj/5pmUy22lYrvstthgGHQv?=
 =?us-ascii?Q?eHzci4wkC9PFz6LFICowsujVpwcJY0+rzocJq9eeTIFOUbm/ZCRYL42oj0p7?=
 =?us-ascii?Q?yaXac1PUolQB3XAc8f7v7TFOGSHzcUQiqLTPg8Zq+h0Mbjf+70sFDIOflL2m?=
 =?us-ascii?Q?FXIPftMb4ahLMuEaAWnMSsmZ842HnEAhJi5znr+iYha1fEe5pUwZ2BSCwvT7?=
 =?us-ascii?Q?ETp3hJHAKSofbna4UR4dtuvR3vT9EaRzWV7qCpMEN12WZQtKM6i/79eyM/1Q?=
 =?us-ascii?Q?JB9JWA/0ibanMSXDL9gcvat+TC9CI5H0bFLcNm9D9ShsAeNtuF2Cj8sOXOaP?=
 =?us-ascii?Q?y3R/3vhoug8JKibttMhYPSvVCDMYbCr8Ydw5yW4LSQyKG+V37+pWn1vFjUlz?=
 =?us-ascii?Q?7fbnyDSabNkOFUGt9wh29pKKj/uMVNqVBvQzMS9xcEA/zqnm8eqsMsz6JERb?=
 =?us-ascii?Q?NHZptEzbvNBnWN0Gor/nl1lRQ8OaycsOLKIxIqidwEQW0snAI9o5JVa8Be8L?=
 =?us-ascii?Q?eokOY8RHh/ebJ9nB/eA3e7Ddsn6BAfuowO8yMghOytAXjcXkkq4dY6enzQTK?=
 =?us-ascii?Q?IZkfgSUOeLM6Ex5ozrm5tICmmaI1iWAA7P6AcWM4ukAWSTTdWsd2fEGiTD3A?=
 =?us-ascii?Q?+e4VH5/BDJklPnGhg7SbHAIWSJq8dHfs305voI37RJ/t9CGcFQcMjqItx/wb?=
 =?us-ascii?Q?7oGQeXPZtiRdiFWl/kvA0y2YSG7bIhY0Lsw/haeHCPmHspZz0cspotRCL7M1?=
 =?us-ascii?Q?ZDL0DXngxfxMMxHTzrAOdKzMtbV+ghHfuE+AirIRQrB1pqzMKIIoEZYrWxCL?=
 =?us-ascii?Q?TkDVwMZJpr3u0s5lQAMBEFXYrOjYTp7EtlemfDn1jZf+c30cc8wuZIJdH4H5?=
 =?us-ascii?Q?akuIjxLXmTyWjJ5tKXmTGVL/wHXccIBcMXXmxN31A6EkKXrYIib7o0ayMnyf?=
 =?us-ascii?Q?ACuAiHoV9XJJuOb0v7lr0kYADneRAvNPwQ6YrTnDOh2Cn4cYFnNX5oV4OXYP?=
 =?us-ascii?Q?4nzDrhiqL5FrEL388o0lSzvXKuEcWkJbudwvD5sJHiTrAtdAEGArK6bgm7D5?=
 =?us-ascii?Q?COCWdg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <53433F1D26FFFD46A6869BFFF09C99F7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2e13f6e-9f88-48a3-6c6a-08da6fc4d3ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 11:40:38.6883
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AheabCx4iSOWH6wPZn8wuNZWVdhO7PHUTOHojRdGjr2uiH3SUjQEK1EUjJUzjWAUYlzlpMTZU5yTmk13rAXse8VhJFJCqaXpfTSoq6BG5WY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB5935
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-27_02,2022-07-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207270048
X-Proofpoint-GUID: ZYz6RRVKudfYVsUuetD-LOO0gDHVp4nF
X-Proofpoint-ORIG-GUID: ZYz6RRVKudfYVsUuetD-LOO0gDHVp4nF
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This isn't a NULL pointer dereference; returning &(0->page) is completely l=
egal
as was discussed regarding this exact code back in April:

https://lore.kernel.org/lkml/YmfgqKcMmstgfz+0@casper.infradead.org/

> On Jul 27, 2022, at 12:46 AM, Yongqiang Liu <liuyongqiang13@huawei.com> w=
rote:
>=20
> When __filemap_get_folio() failed and returned NULL, we would
> get a NULL pointer dereference in pagecache_get_page.
>=20
> Fixes: 3f0c6a07fee6 ("mm/filemap: Add filemap_get_folio")
> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
> Cc: <stable@vger.kernel.org> # 5.16
> ---
> mm/folio-compat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/mm/folio-compat.c b/mm/folio-compat.c
> index 20bc15b57d93..7b21393480e0 100644
> --- a/mm/folio-compat.c
> +++ b/mm/folio-compat.c
> @@ -124,7 +124,9 @@ struct page *pagecache_get_page(struct address_space =
*mapping, pgoff_t index,
> struct folio *folio;
>=20
> folio =3D __filemap_get_folio(mapping, index, fgp_flags, gfp);
> - if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio))
> + if (!folio)
> + return NULL;
> + if ((fgp_flags & FGP_HEAD) || xa_is_value(folio))
> return &folio->page;
> return folio_file_page(folio, index);
> }
> --=20
> 2.25.1
>=20
>=20