Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp266762imn; Wed, 27 Jul 2022 05:49:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vCO9HbSMP1FwB0GR8PnO+r7/UBV6e7KdadQRXWSKg7d5wGRl6AXQKtKMal/k/RisytrrmV X-Received: by 2002:a17:90b:4d90:b0:1f3:1399:404c with SMTP id oj16-20020a17090b4d9000b001f31399404cmr882927pjb.133.1658926189056; Wed, 27 Jul 2022 05:49:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658926189; cv=none; d=google.com; s=arc-20160816; b=eoeDAUycVLwvMr/m1oTdAKy3Qocvl2pYKCG+cydribAW29wTTfwR7zuU2zZhKkr/Jr xPAXSBtvsNp51MDI6j2uU1Vc/cEtVtB25qROgL4mNY87MiC6eDKIQRZQxZk3AwB4DmrI g8ZWfpXhiJ/vVykD7EbEZ9eSlw45B+eCpgLyVH5I6BhqRaMeO4kPYWusOCMwOFamv3Qh ZahVKetz+EEMHQJfu+1bygwetIHV7htYJ5TpfqDGpbkF+GAz8Rrp1w+/rKovmfQOxOFD sYpqpMvBaOmG5cXr5KymbQ3Pdur5WerTXfPxH4TriAXaDzOlDKqTELoqfukWHd9MLzX5 1zCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:references:message-id :subject:cc:to:date:from:dkim-signature; bh=N58X1M9T+NpMZ44HX48MblFSIP40P/RQn+KIwFV37SI=; b=MRV9HFSGrw9TybCSgsddCpD1Md1Fjd0HA+TGZYMFr6boStgWX4pSjApvqJHlcCDYBu Mxb+65T7VJ3tXqkiTEilEK6e8SzgY+ld+TT75aPfcLFwnK/8N2PdBqpO85f9tIUlWhwu S7W16myttseb6T1VJMUrqSHpk98+csOuzG5urdQP3YRWX2t4Wk2ZirV1n1dna5M0VQBU i46iyqWi5BlJuXJiBiEfHeu97a1Gs38oEOsRneLE29ATlwLyEegpUwSJdZBNE4Isetyn 8/gjzMaeEEeLMImOwt+QRe9IvyHLYSfZpbb/O+s0fzN3CCBM0hnFVFXj48B6uQerWyK+ DnLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JJg3nUiG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h71-20020a62834a000000b005254abef688si18403013pfe.239.2022.07.27.05.49.33; Wed, 27 Jul 2022 05:49:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=JJg3nUiG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231758AbiG0MfV (ORCPT + 99 others); Wed, 27 Jul 2022 08:35:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233088AbiG0MfT (ORCPT ); Wed, 27 Jul 2022 08:35:19 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DFB7BC8B for ; Wed, 27 Jul 2022 05:35:16 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id w205so12659704pfc.8 for ; Wed, 27 Jul 2022 05:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :in-reply-to; bh=N58X1M9T+NpMZ44HX48MblFSIP40P/RQn+KIwFV37SI=; b=JJg3nUiGV30JG3q/C2KeuG1vIQYeUtRgLPKysoPJbjdFxkI+xl+O4utZEAtHY1eN39 1QI/XVdWnCSsTdgto/BEDAeSRuEbA7Bg2xFQZu2PeCMjfby8Q9xp5pWm2DwrTl56O4Dy 2CQd3U+oRbCsJq0qH7PjoQ4XQOdAh3+acxKsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:in-reply-to; bh=N58X1M9T+NpMZ44HX48MblFSIP40P/RQn+KIwFV37SI=; b=cmZq1A5qMsGN6KirSj2RJVArrqxYTlDO/ZuKPaJcKLSRsRDKmDAiObQrI+rTSyibB9 7lDBuJ/pBzEtQOjCd/aNF23UR7MfF58p/TOH2ETndXl8tGibADmQImOwhDTaAmFlWND9 /p7OW70UwDvUF2Nsyh7XJHe4SCufe7Y31BJ0jjvyu4VfYydz9FVTC78HKZhbnzzMXvFm HRmDnpEGdUViRNewh6NXmUcdQQ+9bqHhfAkjTrGoh1unDGzOCcc5hBuYQkJ/gDRexP/f wkSO6ge/Sa/gChIsMIMEKlRZSlsYV8b1pS1J8TnbW2yjLsUQdvJNrkGoIWaBf59gUmSv Q65Q== X-Gm-Message-State: AJIora/vRHAn9BON/F1oB+np8ypf3Xc61cQacBDAEGvhAT9u+yk17M3g KE2ts6sWIg/Ie0/vi0BBsfdnIw== X-Received: by 2002:a63:b08:0:b0:41a:a7b9:d8d6 with SMTP id 8-20020a630b08000000b0041aa7b9d8d6mr18876285pgl.306.1658925315989; Wed, 27 Jul 2022 05:35:15 -0700 (PDT) Received: from C02YVCJELVCG (104-190-227-136.lightspeed.rlghnc.sbcglobal.net. [104.190.227.136]) by smtp.gmail.com with ESMTPSA id s12-20020a170902ea0c00b0016c28fbd7e5sm4671616plg.268.2022.07.27.05.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 05:35:14 -0700 (PDT) From: Andy Gospodarek X-Google-Original-From: Andy Gospodarek Date: Wed, 27 Jul 2022 08:35:08 -0400 To: Jiri Pirko Cc: Vikas Gupta , kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, stephen@networkplumber.org, edumazet@google.com, pabeni@redhat.com, ast@kernel.org, leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, michael.chan@broadcom.com, andrew.gospodarek@broadcom.com Subject: Re: [PATCH net-next v7 1/2] devlink: introduce framework for selftests Message-ID: References: <20220727063719.35125-1-vikas.gupta@broadcom.com> <20220727063719.35125-2-vikas.gupta@broadcom.com> MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000030666f05e4c8a68d" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --00000000000030666f05e4c8a68d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 27, 2022 at 09:26:48AM +0200, Jiri Pirko wrote: > Wed, Jul 27, 2022 at 08:37:18AM CEST, vikas.gupta@broadcom.com wrote: > >Add a framework for running selftests. > >Framework exposes devlink commands and test suite(s) to the user > >to execute and query the supported tests by the driver. > > > >Below are new entries in devlink_nl_ops > >devlink_nl_cmd_selftests_show_doit/dumpit: To query the supported > >selftests by the drivers. > >devlink_nl_cmd_selftests_run: To execute selftests. Users can > >provide a test mask for executing group tests or standalone tests. > > > >Documentation/networking/devlink/ path is already part of MAINTAINERS & > >the new files come under this path. Hence no update needed to the > >MAINTAINERS > > > >Signed-off-by: Vikas Gupta > >Reviewed-by: Michael Chan > >Reviewed-by: Andy Gospodarek > > Note that if the patch changed since the person provided the review tag, > you should drop it. I'm pretty sure that you carry these tags from V1. To give Vikas credit on this, I think most (if not all) were reviewed internally before sending out to the list, so it wasn't a total cut and paste of these for each revision. :) > Looks good, couple small nits and I will be fine :) Great! Thanks for the detailed review. > > > >--- > > .../networking/devlink/devlink-selftests.rst | 38 +++ > > include/net/devlink.h | 21 ++ > > include/uapi/linux/devlink.h | 29 +++ > > net/core/devlink.c | 216 ++++++++++++++++++ > > 4 files changed, 304 insertions(+) > > create mode 100644 Documentation/networking/devlink/devlink-selftests.rst > > > >diff --git a/Documentation/networking/devlink/devlink-selftests.rst b/Documentation/networking/devlink/devlink-selftests.rst > >new file mode 100644 > >index 000000000000..c0aa1f3aef0d > >--- /dev/null > >+++ b/Documentation/networking/devlink/devlink-selftests.rst > >@@ -0,0 +1,38 @@ > >+.. SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >+ > >+================= > >+Devlink Selftests > >+================= > >+ > >+The ``devlink-selftests`` API allows executing selftests on the device. > >+ > >+Tests Mask > >+========== > >+The ``devlink-selftests`` command should be run with a mask indicating > >+the tests to be executed. > >+ > >+Tests Description > >+================= > >+The following is a list of tests that drivers may execute. > >+ > >+.. list-table:: List of tests > >+ :widths: 5 90 > >+ > >+ * - Name > >+ - Description > >+ * - ``DEVLINK_SELFTEST_FLASH`` > >+ - Devices may have the firmware on non-volatile memory on the board, e.g. > >+ flash. This particular test helps to run a flash selftest on the device. > >+ Implementation of the test is left to the driver/firmware. > >+ > >+example usage > >+------------- > >+ > >+.. code:: shell > >+ > >+ # Query selftests supported on the devlink device > >+ $ devlink dev selftests show DEV > >+ # Query selftests supported on all devlink devices > >+ $ devlink dev selftests show > >+ # Executes selftests on the device > >+ $ devlink dev selftests run DEV id flash > >diff --git a/include/net/devlink.h b/include/net/devlink.h > >index 5bd3fac12e9e..b311055cc29a 100644 > >--- a/include/net/devlink.h > >+++ b/include/net/devlink.h > >@@ -1509,6 +1509,27 @@ struct devlink_ops { > > struct devlink_rate *parent, > > void *priv_child, void *priv_parent, > > struct netlink_ext_ack *extack); > >+ /** > >+ * selftests_check() - queries if selftest is supported > >+ * @devlink: devlink instance > >+ * @test_id: test index > >+ * @extack: extack for reporting error messages > >+ * > >+ * Return: true if test is supported by the driver > >+ */ > >+ bool (*selftest_check)(struct devlink *devlink, unsigned int test_id, > > Should be just "id" to be consistent with the rest of the code. > > > >+ struct netlink_ext_ack *extack); > >+ /** > >+ * selftest_run() - Runs a selftest > >+ * @devlink: devlink instance > >+ * @test_id: test index > >+ * @extack: extack for reporting error messages > >+ * > >+ * Return: status of the test > >+ */ > >+ enum devlink_selftest_status > >+ (*selftest_run)(struct devlink *devlink, unsigned int test_id, > > Same here. > > > >+ struct netlink_ext_ack *extack); > > }; > > > > void *devlink_priv(struct devlink *devlink); > >diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h > >index 541321695f52..d6e2d3b76e47 100644 > >--- a/include/uapi/linux/devlink.h > >+++ b/include/uapi/linux/devlink.h > >@@ -136,6 +136,9 @@ enum devlink_command { > > DEVLINK_CMD_LINECARD_NEW, > > DEVLINK_CMD_LINECARD_DEL, > > > >+ DEVLINK_CMD_SELFTESTS_GET, /* can dump */ > >+ DEVLINK_CMD_SELFTESTS_RUN, > >+ > > /* add new commands above here */ > > __DEVLINK_CMD_MAX, > > DEVLINK_CMD_MAX = __DEVLINK_CMD_MAX - 1 > >@@ -276,6 +279,30 @@ enum { > > #define DEVLINK_SUPPORTED_FLASH_OVERWRITE_SECTIONS \ > > (_BITUL(__DEVLINK_FLASH_OVERWRITE_MAX_BIT) - 1) > > > >+enum devlink_attr_selftest_id { > >+ DEVLINK_ATTR_SELFTEST_ID_UNSPEC, > >+ DEVLINK_ATTR_SELFTEST_ID_FLASH, /* flag */ > >+ > >+ __DEVLINK_ATTR_SELFTEST_ID_MAX, > >+ DEVLINK_ATTR_SELFTEST_ID_MAX = __DEVLINK_ATTR_SELFTEST_ID_MAX - 1 > >+}; > >+ > >+enum devlink_selftest_status { > >+ DEVLINK_SELFTEST_STATUS_SKIP, > >+ DEVLINK_SELFTEST_STATUS_PASS, > >+ DEVLINK_SELFTEST_STATUS_FAIL > >+}; > >+ > >+enum devlink_attr_selftest_result { > >+ DEVLINK_ATTR_SELFTEST_RESULT_UNSPEC, > >+ DEVLINK_ATTR_SELFTEST_RESULT, /* nested */ > >+ DEVLINK_ATTR_SELFTEST_RESULT_ID, /* u32, enum devlink_attr_selftest_id */ > >+ DEVLINK_ATTR_SELFTEST_RESULT_STATUS, /* u8, enum devlink_selftest_status */ > >+ > >+ __DEVLINK_ATTR_SELFTEST_RESULT_MAX, > >+ DEVLINK_ATTR_SELFTEST_RESULT_MAX = __DEVLINK_ATTR_SELFTEST_RESULT_MAX - 1 > >+}; > >+ > > /** > > * enum devlink_trap_action - Packet trap action. > > * @DEVLINK_TRAP_ACTION_DROP: Packet is dropped by the device and a copy is not > >@@ -578,6 +605,8 @@ enum devlink_attr { > > > > DEVLINK_ATTR_NESTED_DEVLINK, /* nested */ > > > >+ DEVLINK_ATTR_SELFTESTS_INFO, /* nested */ > > Drop "INFO". There are no information, just data passed there and back. > "info" is odd. DEVLINK_ATTR_SELFTESTS is enough to carry the data there > and back. > > > >+ > > /* add new attributes above here, update the policy in devlink.c */ > > > > __DEVLINK_ATTR_MAX, > >diff --git a/net/core/devlink.c b/net/core/devlink.c > >index 698b2d6e0ec7..a942b3c9223c 100644 > >--- a/net/core/devlink.c > >+++ b/net/core/devlink.c > >@@ -201,6 +201,10 @@ static const struct nla_policy devlink_function_nl_policy[DEVLINK_PORT_FUNCTION_ > > DEVLINK_PORT_FN_STATE_ACTIVE), > > }; > > > >+static const struct nla_policy devlink_selftest_nl_policy[DEVLINK_ATTR_SELFTEST_ID_MAX + 1] = { > >+ [DEVLINK_ATTR_SELFTEST_ID_FLASH] = { .type = NLA_FLAG }, > >+}; > >+ > > static DEFINE_XARRAY_FLAGS(devlinks, XA_FLAGS_ALLOC); > > #define DEVLINK_REGISTERED XA_MARK_1 > > > >@@ -4827,6 +4831,206 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb, > > return ret; > > } > > > >+static int > >+devlink_nl_selftests_fill(struct sk_buff *msg, struct devlink *devlink, > >+ u32 portid, u32 seq, int flags, > >+ struct netlink_ext_ack *extack) > >+{ > >+ struct nlattr *selftests_list; > >+ void *hdr; > >+ int err; > >+ int i; > >+ > >+ hdr = genlmsg_put(msg, portid, seq, &devlink_nl_family, flags, > >+ DEVLINK_CMD_SELFTESTS_GET); > >+ if (!hdr) > >+ return -EMSGSIZE; > >+ > >+ err = -EMSGSIZE; > >+ if (devlink_nl_put_handle(msg, devlink)) > >+ goto err_cancel_msg; > >+ > >+ selftests_list = nla_nest_start(msg, DEVLINK_ATTR_SELFTESTS_INFO); > >+ if (!selftests_list) > >+ goto err_cancel_msg; > >+ > >+ for (i = DEVLINK_ATTR_SELFTEST_ID_UNSPEC + 1; > >+ i <= DEVLINK_ATTR_SELFTEST_ID_MAX; i++) { > >+ if (devlink->ops->selftest_check(devlink, i, extack)) { > >+ err = nla_put_flag(msg, i); > >+ if (err) > >+ goto err_cancel_msg; > >+ } > >+ } > >+ > >+ nla_nest_end(msg, selftests_list); > >+ genlmsg_end(msg, hdr); > >+ return 0; > >+ > >+err_cancel_msg: > >+ genlmsg_cancel(msg, hdr); > >+ return err; > >+} > >+ > >+static int devlink_nl_cmd_selftests_get_doit(struct sk_buff *skb, > >+ struct genl_info *info) > >+{ > >+ struct devlink *devlink = info->user_ptr[0]; > >+ struct sk_buff *msg; > >+ int err; > >+ > >+ if (!devlink->ops->selftest_check) > >+ return -EOPNOTSUPP; > >+ > >+ msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); > >+ if (!msg) > >+ return -ENOMEM; > >+ > >+ err = devlink_nl_selftests_fill(msg, devlink, info->snd_portid, > >+ info->snd_seq, 0, info->extack); > >+ if (err) { > >+ nlmsg_free(msg); > >+ return err; > >+ } > >+ > >+ return genlmsg_reply(msg, info); > >+} > >+ > >+static int devlink_nl_cmd_selftests_get_dumpit(struct sk_buff *msg, > >+ struct netlink_callback *cb) > >+{ > >+ struct devlink *devlink; > >+ int start = cb->args[0]; > >+ unsigned long index; > >+ int idx = 0; > >+ int err = 0; > >+ > >+ mutex_lock(&devlink_mutex); > >+ devlinks_xa_for_each_registered_get(sock_net(msg->sk), index, devlink) { > >+ if (idx < start || !devlink->ops->selftest_check) > >+ goto inc; > >+ > >+ devl_lock(devlink); > >+ err = devlink_nl_selftests_fill(msg, devlink, > >+ NETLINK_CB(cb->skb).portid, > >+ cb->nlh->nlmsg_seq, NLM_F_MULTI, > >+ cb->extack); > >+ devl_unlock(devlink); > >+ if (err) { > >+ devlink_put(devlink); > >+ break; > >+ } > >+inc: > >+ idx++; > >+ devlink_put(devlink); > >+ } > >+ mutex_unlock(&devlink_mutex); > >+ > >+ if (err != -EMSGSIZE) > >+ return err; > >+ > >+ cb->args[0] = idx; > >+ return msg->len; > >+} > >+ > >+static int devlink_selftest_result_put(struct sk_buff *skb, unsigned int test_id, > >+ enum devlink_selftest_status test_status) > >+{ > >+ struct nlattr *result_attr; > >+ > >+ result_attr = nla_nest_start(skb, DEVLINK_ATTR_SELFTEST_RESULT); > >+ if (!result_attr) > >+ return -EMSGSIZE; > >+ > >+ if (nla_put_u32(skb, DEVLINK_ATTR_SELFTEST_RESULT_ID, test_id) || > >+ nla_put_u8(skb, DEVLINK_ATTR_SELFTEST_RESULT_STATUS, > >+ test_status)) > >+ goto nla_put_failure; > >+ > >+ nla_nest_end(skb, result_attr); > >+ return 0; > >+ > >+nla_put_failure: > >+ nla_nest_cancel(skb, result_attr); > >+ return -EMSGSIZE; > >+} > >+ > >+static int devlink_nl_cmd_selftests_run(struct sk_buff *skb, > >+ struct genl_info *info) > >+{ > >+ struct nlattr *tb[DEVLINK_ATTR_SELFTEST_ID_MAX + 1]; > >+ struct devlink *devlink = info->user_ptr[0]; > >+ struct nlattr *attrs, *tests_info; > >+ struct sk_buff *msg; > >+ void *hdr; > >+ int err; > >+ int i; > >+ > >+ if (!devlink->ops->selftest_run || !devlink->ops->selftest_check) > >+ return -EOPNOTSUPP; > >+ > >+ if (!info->attrs[DEVLINK_ATTR_SELFTESTS_INFO]) { > >+ NL_SET_ERR_MSG_MOD(info->extack, "selftest information required"); > > no "information" > > > >+ return -EINVAL; > >+ } > >+ > >+ attrs = info->attrs[DEVLINK_ATTR_SELFTESTS_INFO]; > >+ > >+ err = nla_parse_nested(tb, DEVLINK_ATTR_SELFTEST_ID_MAX, attrs, > >+ devlink_selftest_nl_policy, info->extack); > >+ if (err < 0) > >+ return err; > >+ > >+ msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); > >+ if (!msg) > >+ return -ENOMEM; > >+ > >+ err = -EMSGSIZE; > >+ hdr = genlmsg_put(msg, info->snd_portid, info->snd_seq, > >+ &devlink_nl_family, 0, DEVLINK_CMD_SELFTESTS_RUN); > >+ if (!hdr) > >+ goto free_msg; > >+ > >+ if (devlink_nl_put_handle(msg, devlink)) > >+ goto genlmsg_cancel; > >+ > >+ tests_info = nla_nest_start(msg, DEVLINK_ATTR_SELFTESTS_INFO); > >+ if (!tests_info) > >+ goto genlmsg_cancel; > >+ > >+ for (i = DEVLINK_ATTR_SELFTEST_ID_UNSPEC + 1; > >+ i <= DEVLINK_ATTR_SELFTEST_ID_MAX; i++) { > >+ enum devlink_selftest_status test_status; > >+ > >+ if (nla_get_flag(tb[i])) { > >+ if (!devlink->ops->selftest_check(devlink, i, > >+ info->extack)) { > >+ if (devlink_selftest_result_put(msg, i, > >+ DEVLINK_SELFTEST_STATUS_SKIP)) > >+ goto selftests_info_nest_cancel; > >+ continue; > >+ } > >+ > >+ test_status = devlink->ops->selftest_run(devlink, i, > >+ info->extack); > >+ if (devlink_selftest_result_put(msg, i, test_status)) > >+ goto selftests_info_nest_cancel; > >+ } > >+ } > >+ > >+ nla_nest_end(msg, tests_info); > >+ genlmsg_end(msg, hdr); > >+ return genlmsg_reply(msg, info); > >+ > >+selftests_info_nest_cancel: > >+ nla_nest_cancel(msg, tests_info); > >+genlmsg_cancel: > >+ genlmsg_cancel(msg, hdr); > >+free_msg: > >+ nlmsg_free(msg); > >+ return err; > >+} > >+ > > static const struct devlink_param devlink_param_generic[] = { > > { > > .id = DEVLINK_PARAM_GENERIC_ID_INT_ERR_RESET, > >@@ -8970,6 +9174,7 @@ static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = { > > [DEVLINK_ATTR_RATE_PARENT_NODE_NAME] = { .type = NLA_NUL_STRING }, > > [DEVLINK_ATTR_LINECARD_INDEX] = { .type = NLA_U32 }, > > [DEVLINK_ATTR_LINECARD_TYPE] = { .type = NLA_NUL_STRING }, > >+ [DEVLINK_ATTR_SELFTESTS_INFO] = { .type = NLA_NESTED }, > > }; > > > > static const struct genl_small_ops devlink_nl_ops[] = { > >@@ -9329,6 +9534,17 @@ static const struct genl_small_ops devlink_nl_ops[] = { > > .doit = devlink_nl_cmd_trap_policer_set_doit, > > .flags = GENL_ADMIN_PERM, > > }, > >+ { > >+ .cmd = DEVLINK_CMD_SELFTESTS_GET, > >+ .doit = devlink_nl_cmd_selftests_get_doit, > >+ .dumpit = devlink_nl_cmd_selftests_get_dumpit > >+ /* can be retrieved by unprivileged users */ > >+ }, > >+ { > >+ .cmd = DEVLINK_CMD_SELFTESTS_RUN, > >+ .doit = devlink_nl_cmd_selftests_run, > >+ .flags = GENL_ADMIN_PERM, > >+ }, > > }; > > > > static struct genl_family devlink_nl_family __ro_after_init = { > >-- > >2.31.1 > > > > --00000000000030666f05e4c8a68d Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQegYJKoZIhvcNAQcCoIIQazCCEGcCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3RMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVkwggRBoAMCAQICDBPdG+g0KtOPKKsBCTANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDAyMzhaFw0yMjA5MjIxNDExNTVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGDAWBgNVBAMTD0FuZHkgR29zcG9kYXJlazEtMCsGCSqGSIb3 DQEJARYeYW5kcmV3Lmdvc3BvZGFyZWtAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAp9JFtMqwgpbnvA3lNVCpnR5ehv0kWK9zMpw2VWslbEZq4WxlXr1zZLZEFo9Y rdIZ0jlxwJ4QGYCvxE093p9easqc7NMemeMg7JpF63hhjCksrGnsxb6jCVUreXPSpBDD0cjaE409 9yo/J5OQORNPelDd4Ihod6g0XlcxOLtlTk1F0SOODSjBZvaDm0zteqiVZb+7xgle3NOSZm3kiCby iRuyS0gMTdQN3gdgwal9iC3cSXHMZFBXyQz+JGSHomhPC66L6j4t6dUqSTdSP07wg38ZPV6ct/Sv /O2HcK+E/yYkdMXrDBgcOelO4t8AYHhmedCIvFVp4pFb2oit9tBuFQIDAQABo4IB3zCCAdswDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDApBgNVHREEIjAggR5hbmRyZXcuZ29zcG9kYXJla0Bicm9hZGNvbS5jb20wEwYDVR0lBAwwCgYI KwYBBQUHAwQwHwYDVR0jBBgwFoAUljPR5lgXWzR1ioFWZNW+SN6hj88wHQYDVR0OBBYEFKARn7Ud RlGu+rBdUDirYE+Ee4TeMA0GCSqGSIb3DQEBCwUAA4IBAQAcWqh4fdwhDN0+MKyH7Mj0vS10E7xg mDetQhQ+twwKk5qPe3tJXrjD/NyZzrUgguNaE+X97jRsEbszO7BqdnM0j5vLDOmzb7d6qeNluJvk OYyzItlqZk9cJPoP9sD8w3lr2GRcajj5JCKV4pd2PX/i7r30Qco0VnloXpiesFmNTXQqD6lguUyn nb7IGM3v/Nb7NTFH8/KUVg33xw829ztuGrOvfrHfBbeVcUoOHEHObXoaofYOJjtmSOQdMeJIiBgP XEpJG8/HB8t4FF6A8W++4cHhv0+ayyEnznrbOCn6WUmIvV2WiJymRpvRG7Hhdlk0zA97MRpqK5yn ai3dQ6VvMYICbTCCAmkCAQEwazBbMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQR2xvYmFsU2lnbiBu di1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMgUGVyc29uYWxTaWduIDIgQ0EgMjAyMAIM E90b6DQq048oqwEJMA0GCWCGSAFlAwQCAQUAoIHUMC8GCSqGSIb3DQEJBDEiBCCDR83lRCIcRLAZ jIHtso4pI4IoAalKPSy7u73L+xWAqjAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3 DQEJBTEPFw0yMjA3MjcxMjM1MTZaMGkGCSqGSIb3DQEJDzFcMFowCwYJYIZIAWUDBAEqMAsGCWCG SAFlAwQBFjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwCwYJKoZIhvcNAQEKMAsGCSqGSIb3DQEB BzALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEggEAlMNhAO9Q+ZNxroRmrFL02jKTbxl+hkbp Gw7EQIhQD+BOXu+Ptlce+KMWypQQGhMoX0TmqPlpjd+42CQo0JSFG3iBoL5PjdeZi8DAByBr5Gpr ypvTzIVu/jMN8QJBl2q59PMsqZB8Ipm+lDxmKKhGWwQ+URCHo8bIf957fnAXEFJ30qtRiX147g5h updQS/8BOfU8XUJFfFoQ53zdTezikggL0uxH0pHspKQswAkAFu8RrW4hjZRcY2aslBFkQ0c5Uy2t 0xEwn/C782yQLNQLGRKIwVRwFmtUjfhs7AcjbjE3wyLVBc5XeEF/aJTKKM4JB6fjKWzv0SG0ORPe 2fHasQ== --00000000000030666f05e4c8a68d--