Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 14:32:00 +0200
From:   Jiri Pirko <jiri@resnulli.us>
To:     Vikas Gupta <vikas.gupta@broadcom.com>
Cc:     jiri@nvidia.com, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        dsahern@kernel.org, stephen@networkplumber.org,
        edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
        leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
        michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v8 2/2] bnxt_en: implement callbacks for devlink
 selftests
Message-ID: <YuEwQFirDFkC7x6O@nanopsycho>
References: <20220727092035.35938-1-vikas.gupta@broadcom.com>
 <20220727092035.35938-3-vikas.gupta@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220727092035.35938-3-vikas.gupta@broadcom.com>
Precedence: bulk

Wed, Jul 27, 2022 at 11:20:35AM CEST, vikas.gupta@broadcom.com wrote:
>From: vikas <vikas.gupta@broadcom.com>
>
>Add callbacks
>=============
>.selftest_check: returns true for flash selftest.
>.selftest_run: runs a flash selftest.
>
>Also, refactor NVM APIs so that they can be
>used with devlink and ethtool both.
>
>Signed-off-by: vikas <vikas.gupta@broadcom.com>

Wrong SOB line.


>Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>


Reviewed-by: Jiri Pirko <jiri@nvidia.com>