Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp287851imn; Wed, 27 Jul 2022 06:21:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vw+Sd0iCM3Qs8NGIQ3at+SoVBg3F3eGLART/m3zAR21YOQL6R5KoBaRibptj262p4caf5G X-Received: by 2002:a05:6402:484:b0:43b:6e02:71af with SMTP id k4-20020a056402048400b0043b6e0271afmr23511852edv.176.1658928095664; Wed, 27 Jul 2022 06:21:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658928095; cv=none; d=google.com; s=arc-20160816; b=turSqK58r3n6Kjll/ZQscc9SjtBDX7j4fL+b+3pTSzPpkQm5MySTF0/KNb0Pp1hoUC nwzRRlyuUeoUA5O5kvUuBB00w7/CJE+ottxhOGlfL7r+tPnvYl0k4qqCJJLuvJRvfqte Xv/rzXaF4lqha4xbOaQgSC6aXGS90ZKKLzygGutZaN8f/myl1eoh0+bUekBzHguzPBin aix3+fXuAdgyNlEtHefvdbrGe4hKMiqKhblEmSX7AvUD6k7Ug4ZFZ0D+5Ves2iipPHUc sEntkXDMSbVUuOG05zvSoXC1wdgRA3JcqjPiepANdUw1HGT3H9knOHGediQvJ3ApgiP/ uyJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GBbYFGg6eFG4lFnup1FTd9trnPxKQVIL1w8McbpG83w=; b=mdMvr8wjc7vUJsxmsem1HrX0hTdN1EWyqF6Q1imk4Zy7WwyZejsBEbqZaWA6xPDd37 xptT1X0UuIO3f9eI7E0wbank81BCgG0k/CEZfP4COj2+oL74zLOJLYcFYXeWNNt+Hiei ZRHkBcPaIs6WqLeyEa2qE2ZJPqymExuBER3IMzqzKPYwunCdB3bmMjztPK77UefvHi5a Eek6qpx0I9jNUulc/4F3AfOYdep7v9MowW8JCspusAnr6XmwqQczYMgZnPoUHfH4ShU5 JQirgKqAU+sOgI77LWT6L9IoTuZIgrZgTFJKljAS9dKJ7hnzUZBFz24rOO3oY0+IkDkE bKIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LrwHHE8s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a056402274f00b0043bf2514a63si10958656edd.376.2022.07.27.06.21.10; Wed, 27 Jul 2022 06:21:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LrwHHE8s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231892AbiG0M0M (ORCPT + 99 others); Wed, 27 Jul 2022 08:26:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbiG0M0L (ORCPT ); Wed, 27 Jul 2022 08:26:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4BA3C6; Wed, 27 Jul 2022 05:26:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4222D6108C; Wed, 27 Jul 2022 12:26:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50199C433D6; Wed, 27 Jul 2022 12:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658924768; bh=gv8Wv2GNLgTDe7dGwAeuH5X32u+PlcW6hhAiGUQ2dNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LrwHHE8s61XnGu8ZStGXd7rKV1WvNIir/S4KaA+2htipqxE4F0kt9BfnSVhK41+uw VLHV4JaVAdQgv17Jn+UOp9nCxglz/ikapuP/OdHL9F52ojW10+P8f56TA4GawSXCWD zbXt+j3+atTvTO11VCyoF8Bav2MJorqrDcPdeWug= Date: Wed, 27 Jul 2022 14:26:06 +0200 From: Greg Kroah-Hartman To: Dongliang Mu Cc: Dongliang Mu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: trancevibrator: simplify tv_probe Message-ID: References: <20220720072346.33511-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220720072346.33511-1-dzm91@hust.edu.cn> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2022 at 03:23:43PM +0800, Dongliang Mu wrote: > From: Dongliang Mu > > The function tv_probe does not need to invoke kfree when the > allocation fails. So let's simplify the code of tv_probe. > Another change is to remove a redundant space. Those are two different things, please resend as a patch series of 2 different patches. thanks, greg k-h