Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <alexandru.tachici@analog.com>
To:     <andrew@lunn.ch>
CC:     <alexandru.tachici@analog.com>, <d.michailidis@fungible.com>,
        <davem@davemloft.net>, <devicetree@vger.kernel.org>,
        <edumazet@google.com>, <geert+renesas@glider.be>,
        <geert@linux-m68k.org>, <gerhard@engleder-embedded.com>,
        <joel@jms.id.au>, <krzysztof.kozlowski+dt@linaro.org>,
        <kuba@kernel.org>, <l.stelmach@samsung.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <robh+dt@kernel.org>, <stefan.wahren@i2se.com>,
        <stephen@networkplumber.org>, <wellslutw@gmail.com>
Subject: [net-next,v2,2/3] net: ethernet: adi: Add ADIN1110 support
Date:   Wed, 27 Jul 2022 16:26:12 +0300
Message-ID: <20220727132612.31445-1-alexandru.tachici@analog.com>
In-Reply-To: <Yt76W+MbeHucJj0f@lunn.ch>
References: <Yt76W+MbeHucJj0f@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

> > +static irqreturn_t adin1110_irq(int irq, void *p)
> > +{
> > +	struct adin1110_priv *priv = p;
> > +	u32 status1;
> > +	u32 val;
> > +	int ret;
> > +	int i;
> > +
> > +	mutex_lock(&priv->lock);
> 
> The MDIO bus operations are using the same lock. MDIO can be quite
> slow. Do you really need mutual exclusion between MDIO and interrupts?
> What exactly is this lock protecting?
> 
>   Andrew

Hi Andrew,

Thanks for all the help here.

With this lock I am mainly protecting SPI read/writes. The hardware doesn't expose the MDIO pins.
In order to read/write a PHY reg, there has to be a SPI read/write to the device, the same
line where the MAC is programmed and ethernet frames are sent/received, not very efficient I know.

Best regards,
Alexandru