Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 15:09:25 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jiho Chu <jiho.chu@samsung.com>
Cc:     arnd@arndb.de, linux-kernel@vger.kernel.org,
        yelini.jeong@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 4/9] trinity: Add schduler module
Message-ID: <YuE5BYqgDrSlw8k7@kroah.com>
References: <20220725065308.2457024-1-jiho.chu@samsung.com>
 <CGME20220725065309epcas1p42ba84c5241d69192ea73904ed6af17d7@epcas1p4.samsung.com>
 <20220725065308.2457024-5-jiho.chu@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220725065308.2457024-5-jiho.chu@samsung.com>
Precedence: bulk

On Mon, Jul 25, 2022 at 03:53:03PM +0900, Jiho Chu wrote:
> This patch includes NPU scheduler interface.
> 
> Tasks can be pushed to the NPU in order by the scheduler. The default
> schduling algorithm is provided using Priority policy.
> The scheduler waits request from the user. When the requests are
> invoked, it submits each request to the NPU by the priority, and waits
> until complete interrupt arrives. The priority is calculated with
> remained time to requested timeout.
> 
> Thus the scheduler algorithm may be added more in the later, it
> provides an interface which can support various schedulers.

Please do not add interfaces that you do not use at all.  Just make it
simple for the first version and then, if you really need to add new
types of "schedulers" add them later on.

As it is, this is a whole layer of abstraction that is not needed and
can be removed.

thanks,

greg k-h