Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 15:43:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Phillip Potter <phil@philpotter.co.uk>, Larry.Finger@lwfinger.net,
        paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
        abdun.nihaal@gmail.com, philipp.g.hortmann@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: convert rtw_pwr_wakeup to correct
 error code semantics
Message-ID: <20220727124342.GR2316@kadam>
References: <20220725220745.12739-1-phil@philpotter.co.uk>
 <YuDcKoSibAo93a6P@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YuDcKoSibAo93a6P@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1Mmj8s1VJshobKA2T0Gv4FBQ7nZqNFn5wWpCu5kYFgHfYWMZtAW9ATdVUGKH?=
 =?us-ascii?Q?X2ZMhs4Pv1IAWgeo6EjtA6Z1h70oLZOckGlQCELmed8kATxsco6cupxQcadA?=
 =?us-ascii?Q?5bY/q/wMxUgecROqNPS1DrI03i4xnKjauc5JFDZG+3RrcdCGz6a7hjjJhfSZ?=
 =?us-ascii?Q?mIlSe42qXadD1PzpA1njAucHSaW7X+gNAxahxhO7z//Z8HXYAp1Ws5XlZw+f?=
 =?us-ascii?Q?5+lQX+9CfmHPSLVYaVkpvq1GrWE+6MUrTkUlaefYOS9f8bA8dSWGrNFmCN+t?=
 =?us-ascii?Q?XL5wx1lAdvFnJjUvgqwbElENKrom0GBwiDBsKlUCE3p6Y70uODx/hhFng/H2?=
 =?us-ascii?Q?/bk0TRfVJaeyAmMaNtnKWqck9Lk/P8R7RKtrYKdounxgLG2krErc4Z+gH7c7?=
 =?us-ascii?Q?FppQCfX1aZscRBA+sbYLHNnouaru/+NaD5VbkJd5LqeSexB7ncu/v/QxWXrR?=
 =?us-ascii?Q?98LJTRA4DSfd6i4X0mfGrj14hP57MWmO9NDrJ0Lg3Pc9gJWgV5jxwZ6OMmPQ?=
 =?us-ascii?Q?bWxYYVllez1o+5pHrVhCeY9fdjLvm+TOTKWYGJnOKBoquiDNikInC4jshYTP?=
 =?us-ascii?Q?2cI4MdU6/c4YRsVIXnVB2nmXnvqQ2iyce8UXwVwbfo9oAk9Arh8q+iIc4bkH?=
 =?us-ascii?Q?eg1HzHjEOFnMUIif1HGUSRGMwIj7Yz0E0+KysbqRJeCSClt3iTo9DBM2zxlQ?=
 =?us-ascii?Q?QT1sfMFfHRRZGgJCvuYxlPdBPFp6mh0FX8YTWsmWmv1OG6l35g9KZPaiIJHH?=
 =?us-ascii?Q?oQ/pzCcwew8NbIppqnd51wYsh2PEgnzulPzZ7OBWkMIVCyJlJRGG8ItYgkrv?=
 =?us-ascii?Q?0Z3BpohGs3OYzu/c0y+Zcq/xsgOkykXs1F32ZjLz6EjwWLQmHj8rt+Sku34h?=
 =?us-ascii?Q?WZdfkzU4qERG77HMXmJ7I1p3SegQQx+MqzP317idDr7jzhEVG8ESu5u9QidJ?=
 =?us-ascii?Q?b8xG55JzSUdL7c0Lvf/1bWohWP3im6Ma10usU5j4wSsyEk16ohjeh9FnA3DZ?=
 =?us-ascii?Q?UfcxrnuLGObMp43p8+l3aDBdB42xgz5tdftVXCN0aALLyaxACMVRB8ulJ9yQ?=
 =?us-ascii?Q?4wlGWq/mnLTwJG02fnlHJkLEYQHLYAbZOgQQ72eRP3YOCU1ei0IjPJSbGV7Q?=
 =?us-ascii?Q?uXiNTt6Y6TQSbPkNnu6in/AG0/6wscZhqp3vmy/o1zK3H4WgMFh8GGN1Oibk?=
 =?us-ascii?Q?mDvICPV5CebXEiJJA3OIOqKS4WaDk8C38A4kV9CuZPVg5dwV+lg/8JgjE6Rl?=
 =?us-ascii?Q?oF7B6G1uioyaq0RSoMoX2YS+PAZ/iscfRM61glqAlF6qDufqdp6bu3dlBq2C?=
 =?us-ascii?Q?hHC49pP0aLOK7niHCa/xvbC0RZnPJ/Ukeyesx3OsbJZU0rBxFzxabEOVUbkl?=
 =?us-ascii?Q?JUUTQHYn8MWjwKqjmFsix/BV2ATVIdsC+T2lQ002vLLeorEy22yOQqSb/cdG?=
 =?us-ascii?Q?KXKBHkaPqSvHG/izhruLgyOtLZh4itPSa/haKRT6Oq2MMqtkKLL721aDPRNW?=
 =?us-ascii?Q?4bwVnNlxUo401yVSMeGBh9rkiEHNHLoi3Mgsde58gTA/FW8kEG3mRLP2zfFg?=
 =?us-ascii?Q?8MlYhUNh+GL1iWJoG3vM+c7nR18YEJ6lx08ldxYAg/aBDAj7USl2cWOPH70w?=
 =?us-ascii?Q?VA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b19404e-c20f-4c58-d5ea-08da6fcda927
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 12:43:53.3128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3OoilCHQ2xLKMAZMB4eloDzctv5mrmnBqdWvmVZYn1OseoDiYClcXmQ9PCoAQADI74QdPWg2sBwGJw2k9JUla8fq5VO7EGVS7dyukt0xWGk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5389
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-27_04,2022-07-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207270053
X-Proofpoint-GUID: rsXDJSyLpkYLGSj7GdEWtq_k5fYnRqcx
X-Proofpoint-ORIG-GUID: rsXDJSyLpkYLGSj7GdEWtq_k5fYnRqcx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 27, 2022 at 08:33:14AM +0200, Greg KH wrote:
> > diff --git a/drivers/staging/r8188eu/core/rtw_pwrctrl.c b/drivers/staging/r8188eu/core/rtw_pwrctrl.c
> > index cf9020a73933..8b1c50668dfe 100644
> > --- a/drivers/staging/r8188eu/core/rtw_pwrctrl.c
> > +++ b/drivers/staging/r8188eu/core/rtw_pwrctrl.c
> > @@ -381,24 +381,24 @@ int rtw_pwr_wakeup(struct adapter *padapter)
> >  	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> >  	unsigned long timeout = jiffies + msecs_to_jiffies(3000);
> >  	unsigned long deny_time;
> > -	int ret = _SUCCESS;
> > +	int ret = 0;
> >  
> >  	while (pwrpriv->ps_processing && time_before(jiffies, timeout))
> >  		msleep(10);
> >  
> >  	/* I think this should be check in IPS, LPS, autosuspend functions... */
> >  	if (check_fwstate(pmlmepriv, _FW_LINKED)) {
> > -		ret = _SUCCESS;
> > +		ret = 0;
> 
> Nit, you don't need to set this again, as you already set it above to 0.
> 

I would sort of prefer to drop the initialization and keep this one.

Otherwise it causes a Smatch warning about missing error codes.  It
*looks* buggy too, like it should be an error path.  Sometimes people
add a comment explaining why those are success paths and not error paths
which also works.

The Smatch check will no warn if there is a "ret = 0;" within 4(?) lines
of the goto because that's probably intentional.

regards,
dan carpenter