Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1dad74ee-2d82-c8b1-7367-cbc6ea124785@kernel.org>
Date:   Wed, 27 Jul 2022 15:42:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V7 01/16] rv: Add Runtime Verification (RV) interface
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marco Elver <elver@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Gabriele Paoloni <gpaoloni@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        Tao Zhou <tao.zhou@linux.dev>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org
References: <cover.1658778484.git.bristot@kernel.org>
 <2aa3b18239f170ba23263f18d166d08634ed65dd.1658778484.git.bristot@kernel.org>
 <20220726122237.44386359@gandalf.local.home>
 <1e03adf9-2aea-63ab-93ae-a73836a7081a@kernel.org>
 <20220726165903.262a0a65@gandalf.local.home>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20220726165903.262a0a65@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/26/22 22:59, Steven Rostedt wrote:
>>>> +static void turn_monitoring_on(void)
>>>> +{
>>>> +	reset_all_monitors();  
>>> Why does this reset all monitors but turn_monitoring_off() does not?  
>> When we turn monitoring off, the monitors will stop monitoring while yet
>> in sync with the events generated by the system, i.e., all the events after
>> the start were processed.
>>
>> But if we disabled the monitor, and some events get ignored, the monitors
>> will be out of sync with the system. Thus, resetting the monitor to
>> for a synchronization between the monitors and the system is needed, before
>> enabling monitoring back.
>>
>>> You should keep that out.  
>> did not get :-(
> I don't like the way the _on() and _off() are different.
> 
> Have the _on() just turn in on *without* the reset.
> 
> If you need the reset, then make a separate function called:
> 
> static void turn_monitoring_on_with_reset(void)
> {
> 	reset_all_monitors();
> 	turn_monitoring_on();
> }
> 

as usual... https://www.youtube.com/watch?v=qYo0lVVH2wU

Fixed in v8, along with all other changes.

Thanks
-- Daniel