Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 15:15:25 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jiho Chu <jiho.chu@samsung.com>
Cc:     arnd@arndb.de, linux-kernel@vger.kernel.org,
        yelini.jeong@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 2/9] tirnity: Add dma memory module
Message-ID: <YuE6bQeTI/pcbLZh@kroah.com>
References: <20220725065308.2457024-1-jiho.chu@samsung.com>
 <CGME20220725065309epcas1p3c691bbc54c84775524b97c4b717c7ce7@epcas1p3.samsung.com>
 <20220725065308.2457024-3-jiho.chu@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220725065308.2457024-3-jiho.chu@samsung.com>
Precedence: bulk

On Mon, Jul 25, 2022 at 03:53:01PM +0900, Jiho Chu wrote:
> This patch includes memory management module.
> 
> It provides abstraction layer to handle DMA buffer.

Again, no abstactions please.  Get this working and merged properly
first, before worrying about any sort of additional hardware models or
abstractions.  It just makes this so much harder to review and to
determine what you really are, or are not, using here.

So far, it seems you aren't using any of these new abstractions, which
is odd.  Or I just can't find them.  Either way that's a huge sign this
code is wrong and needs to be cleaned up.

thanks,

greg k-h