Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20220724071958.2557-1-hdanton@sina.com>
References: <20220724071958.2557-1-hdanton@sina.com> <20220724052426.2504-1-hdanton@sina.com>
To:     Hillf Danton <hdanton@sina.com>
Cc:     dhowells@redhat.com, Siddh Raman Pant <code@siddh.me>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "syzbot+c70d87ac1d001f29a058" 
        <syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com>,
        "linux-security-modules" <linux-security-module@vger.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing watch_queue
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3565219.1658933355.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Wed, 27 Jul 2022 15:49:15 +0100
Message-ID: <3565221.1658933355@warthog.procyon.org.uk>
Precedence: bulk

Hillf Danton <hdanton@sina.com> wrote:

> Yes, you are right. I missed 353f7988dd84 ("watchqueue: make sure to ser=
ialize
> 'wqueue->defunct' properly"). Sorry for my noise.
> =

> Given defunct serialized, still need to clear wqueue->pipe in the clear
> path as proposed?

In fact, with the locking, is wqueue->defunct even still needed, I wonder?

David