Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1031eddb-4cfa-e94a-e77e-03aa3cb8b680@amd.com>
Date:   Wed, 27 Jul 2022 20:50:17 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access
Content-Language: en-US
To:     Alex Deucher <alexdeucher@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        Sunil-kumar.Dommati@amd.com, David Airlie <airlied@linux.ie>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        open list <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        dan.carpenter@oracle.com
References: <20220727144249.415228-1-Vijendar.Mukunda@amd.com>
 <CADnq5_PKjmNw+bAPCyDu_G=yNQcpJSpFd+EVzNwfNWzig8apFw@mail.gmail.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <CADnq5_PKjmNw+bAPCyDu_G=yNQcpJSpFd+EVzNwfNWzig8apFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGIwWTF0Y0t0U0l6ZzdvSTIvWUJOMnVjMW0vclZ3RjBnM3hPd0xQbEVNdnZa?=
 =?utf-8?B?Wi9lUGdBTzZmeVM0QUVCVER2UFdlM20vK1dlM3pSQlhkS3hLOXpucG80UzJU?=
 =?utf-8?B?RkwzeUN5a2EvbXFXdy9uZTlXTGVIOGlzMVF3SGhvem9uaEZ4aTc2ZWNnZlNv?=
 =?utf-8?B?Qjh1cnFSbnRrUEQwcXRxTHZOQ0RmVE9NMEVRWjR0Nit3SFJxbmJCS2hSZ1Fx?=
 =?utf-8?B?aUd6Z1JIbFRvcVhDOTNGZzZ6T0hLZ04wcERGVnZlcTNrRHpGSmM4cGdrWXAx?=
 =?utf-8?B?OVJad2c5VlZJVHdTVjdWSngxVHphOFdBQzNjZkpXaWp2a1RrdFhPV3JFU29C?=
 =?utf-8?B?Y1NHT3VHNU9VUzdNOHJhK2RYSXVRQlB0c0NMSHRBWHkwYlNrQU5NU0hmRWl1?=
 =?utf-8?B?NlNrcGF1K09OdXQzWGsremgxK0xFRmlTZjM3MDN0VmRFZ1pjMmNmUE4ySld6?=
 =?utf-8?B?UVl4bVVNeWd5eENuMENrYWhTZHR6ZG9yTlVxeXFYUU12K0xsWnJwcjVwcUFx?=
 =?utf-8?B?cFlIUXVkVWZad2VCVExpd3VYaG5CUzlXOTJxQXljQXhCUG13S2RXQzZ5ZXpE?=
 =?utf-8?B?d20zeWViY0VuNW5hc1JiSWswTFJadmZmTlZtS0VUaXdMVXlxZllvLzFWM3hP?=
 =?utf-8?B?OEFXdjFHUi9nbm1Lc056OVJRZlZqVk1kMXd1aGsrdVNHRE9ETUVkbVZ6S2dO?=
 =?utf-8?B?WVFwZUZPSkRUU0RldWladjNOWkY4YjBCS2lXY09rYlMrYVMvM1hmR25WSzlr?=
 =?utf-8?B?Y25UT1RDV0c4dG1UTXV0SytleVl1akZaTU5JdnFqdHhodW5hMGtKaXordDVP?=
 =?utf-8?B?STg0V3FxL3JnSUFnbTFRczN5dTNwelk5K0w4dEhhTlMvOWkxaUpObE1rSllB?=
 =?utf-8?B?OXVvZUpMNjRPNnFISkNsUzJoTEg5OFRoVE5BbGRVclU1elVWdGUvQ3VGSTZ2?=
 =?utf-8?B?dndKQm1tazVHUFB5VzdMMFh6TVlONUU4eTRhVlYrRG1jZm4vUE4rMHlqc2k1?=
 =?utf-8?B?SFNxOVVtZ0VsZHArTzBOOG50Uy9NVFJyN2xJV1FsUElNcUVMdTY5bjM4N3lv?=
 =?utf-8?B?clBwYVByclJBR0tDK0dxME02d2xmOEMrTktwY1A5ajgyeEZiTTcvMVNFZGtU?=
 =?utf-8?B?TWFJa083UndUTEFJbEFWSmpLU3BEcGJBeDJhYThYcURlN0pQWEhFMEVtN3M4?=
 =?utf-8?B?bHZjL0tJcHFXMXhka0EwUFl5N0VhZ1RvUldhRGozK0g4ZmxUa0dHbGdma2dF?=
 =?utf-8?B?NWVWRXRPTCt4NTAzNGVraFBjL2IrV1JGOHJSUldjbXcwK1NDaWlPK0RpL0lr?=
 =?utf-8?B?aDlBZHcvU2RwbWZyaHJYYzBTSkRZdm1VSTVveko0QTJ4WllXOEVRbUhhZmtX?=
 =?utf-8?B?cWNNbUZmRjltMXdSeUh6WFZvYi9nd0xTWHNTVHd5aDRiN2Jxc2RvbXdYK3lR?=
 =?utf-8?B?YTFVaWhUQUZ1bE41MFI2UmpZNm1GbnM1eVZ5VW1aWFREY2M2ZUR3VlNBU1ll?=
 =?utf-8?B?MG9LcGdhU2xyYmdYVytjOC9HVkxLRk5VbVUrMVZWK2VxckNqcTRBNElOSWc3?=
 =?utf-8?B?S2pCd0trNlEwa3FqTkRvbjVKdktGM052K0V3cmIvMDNFN0JXVEhQS0tZUE9x?=
 =?utf-8?B?Wm1lQTJLMGJjV2VEd2ZTZFF0MzM0UUF5M09IMU5sbDN0NjRxTEx0K1JpM2U2?=
 =?utf-8?B?M1J6U3I1V0ZaQTlyNWc5bVJPNmlYd0c5K2xBb3grMWEwK2luYUE0SEtaeUFj?=
 =?utf-8?B?Y09wTDBDTzYxUGZWVGZXOVNHbmNENXpjMWpYamJwODVjZDJ5dFdZazJQN0ZY?=
 =?utf-8?B?azhoL25KTGYwTDV4empBUC9Zd012RlU4MTRFbFRxN1ZxS1E2R2w0aUxtMENo?=
 =?utf-8?B?VE1TYXhjMzRHZVBwWEhQNXEwblloL2RBNGhPbThIbnJWYWYzbEI5eTJjWmJI?=
 =?utf-8?B?VzJTVlFZVHB1Q2d0eTVmdE1NbXpUUnF2YmRpVExDeHJGZ1VWVXgxZHlXNmsy?=
 =?utf-8?B?bGIvN3ZKSEJLekNJWDZZc1VZbS9oRXpzdm10N2JqK2hYaEZYNEMxOGpYNlgr?=
 =?utf-8?B?SW9aK2RySlpnSEViZ1dDTWU5aERZaXRTUW5McnhvQlViK3Z1eG8vR2FQazZW?=
 =?utf-8?Q?DZxxUoNH6suaULPPjgLjtT6UO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e89f591-0d07-4f00-9574-08da6fe2e6a5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 15:15:55.2999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KdPDrUreB8XIeGUguySN6m4SU6uy7nLwbXMWazCEdygq4GhLHdZuTTbESGLH0lo973yABspJ7XVC3Jx+1i+lKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1247
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/27/22 8:25 PM, Alex Deucher wrote:
> On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda
> <Vijendar.Mukunda@amd.com> wrote:
>>
>> Fixed following Smatch static checker warning:
>>
>>     drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init()
>>     error: buffer overflow 'i2s_pdata' 3 <= 3
>>     drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init()
>>     error: buffer overflow 'i2s_pdata' 3 <= 3
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>> index bcc7ee02e0fc..6d72355ac492 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>> @@ -390,14 +390,6 @@ static int acp_hw_init(void *handle)
>>                 i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET;
>>                 i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET;
>>
>> -               i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET;
>> -               switch (adev->asic_type) {
>> -               case CHIP_STONEY:
>> -                       i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
>> -                       break;
>> -               default:
>> -                       break;
>> -               }
> 
> Is this actually not used or should we just increase the allocation size?
> 
> Alex
it's my bad. i2s_pdata array size is 3. when we recently included code
changes for JD platform , this piece of code was added mistakenly for
Stoney platform switch case.

--
Vijendar

> 
>>                 adev->acp.acp_res[0].name = "acp2x_dma";
>>                 adev->acp.acp_res[0].flags = IORESOURCE_MEM;
>>                 adev->acp.acp_res[0].start = acp_base;
>> --
>> 2.25.1
>>