Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17e02cd8-eba1-91b8-2506-91a7893ac967@amd.com>
Date:   Wed, 27 Jul 2022 12:04:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amdkfd: use time_is_before_jiffies(a + b) to replace
 "jiffies - a > b"
Content-Language: en-US
To:     Yu Zhe <yuzhe@nfschina.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
References: <20220727025917.22477-1-yuzhe@nfschina.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20220727025917.22477-1-yuzhe@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmphK1RCYUxZMTNXZ1RQZlVvWWNtL1BPbXUzaEVIQzNaNmpaN0JwUk05cFZ4?=
 =?utf-8?B?SXlqV0pTSHZQdmRLTjNncWZ3TlMydjVsUmI4aHpCNnBubGJQYXpocDgwOFkr?=
 =?utf-8?B?bG96YjB0MlFGcjlwbk15L1dnNFkwVmFGVmplRVpiU2NWK29PS2pDZXpkRlFC?=
 =?utf-8?B?VVhjMm51Z2ZLMjRWZ3htbzFPejdUMW5QNnczd3pNZnRRNlpuNlY5QlFHek1p?=
 =?utf-8?B?L0NGQUVBUGU4Q0JLQ1BLWTdBbm56Ym9CV3A4VXdGdzB1b2FLeWZtUHFOaDFP?=
 =?utf-8?B?YlA5N2J5NWNHemlWVys3c1FTY2o2ZzRodXhHVDZaWTJGQ3Qyamh2VmlCOS9S?=
 =?utf-8?B?UFFEZ1JRTE5jSDRPbE4ybTJ3Vm4wb3haUjBxS2ZPMHg1amozNmtGOXNuaUpY?=
 =?utf-8?B?VzE0ejBMeExNTUFZRnBYSGZLTitrbUowdjVocjhhbTlrME1rSm0rRzR0emor?=
 =?utf-8?B?MGZiM1dQdk9ES0Q3N0tlWE9KcmdFVmNISm93ZDYzZU1NSjBWL04xSXVwNzN1?=
 =?utf-8?B?bnozWkpIMWRwblNCWm5wbTlZNEpldjk5UE5SQjZBOUY5VjBjUEF6YngzOVox?=
 =?utf-8?B?cVh3N0gzenBDK1g0V3NwU0NiZFdMZTlYT3ZkcS9XSEdsdzlDdEVab3hqNlpI?=
 =?utf-8?B?a3R4UzJJU3VXaEJ0aDFydnpZcGpidDBUMTRxMVFURHM4a3MwUmpzdFk1SmVu?=
 =?utf-8?B?V3hEZlRmc2pRVWlwS24rZDllSEZqRS9ZVmsyV1VYWnRUU3piam5QTi9iaTVG?=
 =?utf-8?B?anhJaVVHUjF2RnBGN3EvV3d5S2x1SXRMSjVBTy9mYXB5ZU5lb3hOK3ZZelRX?=
 =?utf-8?B?UHFyNFovcnFRNjBoeWJjZklld0JiclF5MUZjUWV5ai9sUXRSeVRERVVFdmxS?=
 =?utf-8?B?bk1La3hRV052blJqZEVXUzkrSmswRHl1OWpuWEhoNnluRll2aEROLy96UE1S?=
 =?utf-8?B?NjZlRFF5eU5KWDZmSXBvMXNzY1BUYzhNaXU4REJJNXp5Q3U3QWFUNWN2ODlJ?=
 =?utf-8?B?cXRHVFBoeUFibTB0VTVkL3EyeW1tU29qQm0yZEZ2bUVpV3pXQkF6TktIOVFi?=
 =?utf-8?B?ZndnSmdmZFkvL3BuSDNGSUlUZ2RKZ0ppdy9iVlBkWGt3Z0sxYW1KT25jeDVC?=
 =?utf-8?B?eEJkVHg2TTBrbEFiaURHcGt6aE9peU5CM1VFbVVCMW1qQk1lY2l1eXY5LzdC?=
 =?utf-8?B?dVRBT3V3WWlKMFNRN3hjbmgxOFBLWWJRZDRBcDZvWDdOb1BLZXdwQkEzT1k5?=
 =?utf-8?B?QjhFSFFDMmp3ajcxOGorWGlSQ05qdmw0Qnh3OU1ORWNadkhrelZ4enloT3V1?=
 =?utf-8?B?NjR4MmVJUnVWR2tHN01ySnFMazlrYWU5SGZUK3NJUnF4UXNhQzIwYWUreHlU?=
 =?utf-8?B?cHpTd3FGYk90OHNOYjZOQzVmSUd4NU5mVklTV2FsTi83SllqS3RGV1pjczMr?=
 =?utf-8?B?R0FtZnVHTjNveEtjT1lYSEtaR29CMzNmOE1kdlBKUUE5a1l3WkFHMGFyMXUx?=
 =?utf-8?B?RU5iSHZhUzRhMUZKQVpFUEtLMTVxQnB3Z3o4YXhDeE1oWUZ1VW0zM01MSTNT?=
 =?utf-8?B?THVBRlhFZ2FrMExENzVIZzl2SzF2bzVaMWNNNTNqZjJLTDg4cXRZRHZZWlVr?=
 =?utf-8?B?TjJ0ZEhtVzBUejE4YmpPeGxGNjhUL1E0RkVXRTg4ZGROTTROODlDejVZMTZS?=
 =?utf-8?B?d2Z2QXZJTEdoaXpYRGRHeWE0YkVNaFM4b21GZ2VTakJWYmZjc0Rob245aEZD?=
 =?utf-8?B?YWkvVG1KWVFUMzBEbDdpbDRXZWxGdXcxOFlIUTBWelNXMkM3L1F6YjJMV1p4?=
 =?utf-8?B?QkNxU2tUUmVEZTJCOEo3N3BPRUdiNzJJQkE1VVB6V0FSZFNxay9QcEpqNy9s?=
 =?utf-8?B?aGRvYVRnTEVndEhUdG5McENES200aCtOQ3BpZU9kclA3MEJpcDNpSm9nUGNR?=
 =?utf-8?B?ME9aeXdLVzRFcU44SVVtcDdpeE9QZkFJYjBYaVc0aXBSV2tTZGVjYnhBS09u?=
 =?utf-8?B?OXRkbDB0RGM1TGx6YXBxbHhhVlEvbUpJcDN3bytNd3U5OExNQWVBdC92bkRY?=
 =?utf-8?B?MUtFZkxtbyt6blZSUDVxdXZHUk1vc2liMkpNZTJheVpObGR4V08zK3Z6cUJa?=
 =?utf-8?Q?8DtjywJZCqcTDJRlWlQ5CddBi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de8ab7a3-7992-4960-4206-08da6fe9a5ed
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 16:04:12.9448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 56PnFny50NM1GeoUfnNPsHUuSBV1H5iKRAw9Q7PsVif3e4tICswilZIu1jKBGrFL6muIJoW6g+L0HjHjknWcfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5316
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch introduces a build warning for me:

   CC [M]  drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_interrupt.o
In file included from /home/fkuehlin/compute/kernel/include/linux/spinlock.h:54,
                  from /home/fkuehlin/compute/kernel/include/linux/mmzone.h:8,
                  from /home/fkuehlin/compute/kernel/include/linux/gfp.h:6,
                  from /home/fkuehlin/compute/kernel/include/linux/slab.h:15,
                  from /home/fkuehlin/compute/kernel/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_interrupt.c:44:
/home/fkuehlin/compute/kernel/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_interrupt.c: In function ?interrupt_wq?:
/home/fkuehlin/compute/kernel/include/linux/typecheck.h:12:18: warning: comparison of distinct pointer types lacks a cast
    12 |  (void)(&__dummy == &__dummy2); \
       |                  ^~
/home/fkuehlin/compute/kernel/include/linux/jiffies.h:106:3: note: in expansion of macro ?typecheck?
   106 |   typecheck(unsigned long, b) && \
       |   ^~~~~~~~~
/home/fkuehlin/compute/kernel/include/linux/jiffies.h:154:35: note: in expansion of macro ?time_after?
   154 | #define time_is_before_jiffies(a) time_after(jiffies, a)
       |                                   ^~~~~~~~~~
/home/fkuehlin/compute/kernel/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_interrupt.c:159:7: note: in expansion of macro ?time_is_before_jiffies?
   159 |   if (time_is_before_jiffies(start_jiffies + HZ)) {
       |       ^~~~~~~~~~~~~~~~~~~~~~

I think you need to change the the definition of start_jiffies to be 
unsigned long. Do you want to submit a v2 of your patch?

That said, I think the existing code was fine, though the type-mismatch 
highlighted by your patch is a bit iffy.

Regards,
   Felix


Am 2022-07-26 um 22:59 schrieb Yu Zhe:
> time_is_before_jiffies deals with timer wrapping correctly.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> index a9466d154395..6397926e059c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> @@ -156,7 +156,7 @@ static void interrupt_wq(struct work_struct *work)
>   	while (dequeue_ih_ring_entry(dev, ih_ring_entry)) {
>   		dev->device_info.event_interrupt_class->interrupt_wq(dev,
>   								ih_ring_entry);
> -		if (jiffies - start_jiffies > HZ) {
> +		if (time_is_before_jiffies(start_jiffies + HZ)) {
>   			/* If we spent more than a second processing signals,
>   			 * reschedule the worker to avoid soft-lockup warnings
>   			 */