Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 17:55:16 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Stanislav Goriainov <goriainov@ispras.ru>
Cc:     Josh Poimboeuf <jpoimboe@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] objtool: Fix memory leak in create_static_call_section()
Message-ID: <YuFf5LiWGLH6ul5E@worktop.programming.kicks-ass.net>
References: <20220727154825.3427-1-goriainov@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220727154825.3427-1-goriainov@ispras.ru>
Precedence: bulk

On Wed, Jul 27, 2022 at 06:48:25PM +0300, Stanislav Goriainov wrote:
> On some paths of function create_static_call_section() the memory,
> allocated for key_name via strdup(), is not freed. Even though this
> is a utility function, and all memory will be freed automatically
> after the process is finished, there is free(key_sym) in some cases,
> so it would be sensible to always deallocate the memory.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 

This is a run-once die on error program. This is pointless and most
certainly doesn't 'fix' anything.