Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp474469imn; Wed, 27 Jul 2022 11:12:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t7aGF8SpWCOZB3i3c+3CEDIIJwwVCcjb+dMe8wL//KiiaTJKUeriBGvQ20LrjNWmuo94Nj X-Received: by 2002:a17:902:f7cc:b0:16d:28a8:ff4f with SMTP id h12-20020a170902f7cc00b0016d28a8ff4fmr22705672plw.31.1658945576569; Wed, 27 Jul 2022 11:12:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658945576; cv=none; d=google.com; s=arc-20160816; b=wy/qUL3PqXhJA1LMDJyw2UDLz1AIL2XjztE7dTeKazMtQpBYQpmsarF77BAhFgNegF Hg0OXyCwswsvSY3SyEyEFdTCJr1OBQ5Nx75PmfBHgxjrkgaPSKGyNt/io2d4EIn24CNa 3bd5aEWkghUrucOtZJwH8T4n5RRB7i+jIdSAGriJyM1LtlWui5iUp6oQPM65A9rXK5TQ DfoNjMxLg84BDxr4Nn08HYENoHJKb8257gftByHioKtqaMd8IeARwbnY7vQtTXo/S6Vv iItgffkIzju9BLXbppV5Ac8FH1aKkAKM03PYT2l+7XsO1W0cuOSK2eWAmtYMlpB2I9JZ 6HMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l0GCuG8rDBZqnlaLcyGX8e+1yGMjgHaFvPyFuQOMTGA=; b=mQ1GaZ2RMPoLLs9lo5USBCI0uItP0sI4vHeSu28IoKCuP19XdxPRZ0872tuKk2MfV5 n45JD85FWdG/r7geheYYUFfzOMitKQiFfrYihViT3B1fSjEBQzsid2UNJLlkXrxIiTzM 1T5UwVXIKuT+yF0ssvjStwYyTW43oBSeT7udVHaunDpgsGgwcYkLw6v85gXqc+uAWPPp 83wU29Z7/lTWY+OwWYlTEKZe904KEVP8OuAuJeifwtyuLlaGuxBi+8UO6VAbHX+1qTto RAIUMbyQD/pQOF6qwVNIiHX2ktvwNi+cPpVvyET2HUVRPzEGuAVSFxagEJsWZwfwbkbq UlRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Mkb+EWlh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 23-20020a630217000000b0041aff05a86esi9802305pgc.593.2022.07.27.11.12.36; Wed, 27 Jul 2022 11:12:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Mkb+EWlh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240893AbiG0Qw7 (ORCPT + 99 others); Wed, 27 Jul 2022 12:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240822AbiG0QwP (ORCPT ); Wed, 27 Jul 2022 12:52:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A140F4D16E; Wed, 27 Jul 2022 09:34:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B6CC61A7E; Wed, 27 Jul 2022 16:34:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4438AC43470; Wed, 27 Jul 2022 16:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658939646; bh=jsF4LpQm777PxNt5/h+cNChfYSEvUrbp0KZNEszQamk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mkb+EWlh3jL7W/yh8od5O4bCOtytQBtYe41sLTMCuSTIffv+GElVI2ZZBA+y+DaLR JIpTrzSm+7PqJYegGHzi4hj9NU6ZnnSrBpEZ8+R5I6wrBwvkOJ34F+X52fQc16fi30 WnVZ+j0crgj3frRt7uXaaXcT+TzRcV2qqhG5Xn2I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Linus Walleij , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.10 023/105] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe Date: Wed, 27 Jul 2022 18:10:09 +0200 Message-Id: <20220727161013.024294674@linuxfoundation.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220727161012.056867467@linuxfoundation.org> References: <20220727161012.056867467@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 80192eff64eee9b3bc0594a47381937b94b9d65a ] of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/reset/arm-versatile-reboot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/reset/arm-versatile-reboot.c b/drivers/power/reset/arm-versatile-reboot.c index 08d0a07b58ef..c7624d7611a7 100644 --- a/drivers/power/reset/arm-versatile-reboot.c +++ b/drivers/power/reset/arm-versatile-reboot.c @@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void) versatile_reboot_type = (enum versatile_reboot)reboot_id->data; syscon_regmap = syscon_node_to_regmap(np); + of_node_put(np); if (IS_ERR(syscon_regmap)) return PTR_ERR(syscon_regmap); -- 2.35.1