Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp479849imn; Wed, 27 Jul 2022 11:21:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1srS0sE7JxOpRIUKv9H/8OxIo4q+Qd5qOLvAB4P4CtGZpJzWKO4EWlNNdNxV5xFsW6oTZF6 X-Received: by 2002:a17:903:481:b0:16d:4535:6db7 with SMTP id jj1-20020a170903048100b0016d45356db7mr22594077plb.156.1658946106718; Wed, 27 Jul 2022 11:21:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658946106; cv=none; d=google.com; s=arc-20160816; b=SX0cj2wZJYFpcgyCUSUOm4HiatHogjVm9XS7fZFKyoW3NindX/pNGCHolVDX++0Z+N yvidhBKIbstHvQ5xvL71YpKz29Xhi2bBnnD1KB+G80eFe8l2y6FisdPKbTCinwo0GyBL 73pY7u7heRDW3cUFcMRXESH2G9Lyo1LtIE45fRZCho69liwTLPd3GJ3kqNVdwTgv5UWB 9lLPUkaaY5iF4Db9EzSs+KQ8iGrnH8Kquuqr8Tk768JoYGf54SOFKhSBvIJvoB2op+Yh Ilm5OuKCnaSEZtKsC3seU6gCS9pyQVZfy2Rwrq9xId9JXxNzs/dLa+M3rZH6Tzgx1sAH j9Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uPEMKCqpzCVo5p+jfQYlQw+6lVvXHjuKMVP3tozmesY=; b=nnUQrwseKFdaS9YR/zwhtOFO4ZyKDAMs1vUZdEnV4BO62yziGziiPccMNiYn8ndulY 05HVlmp2XPV1Y1vEBUOoDLbnLvzaaNYxrgDyLWRKuazBWMgvhVvgSoo85oG6WeA4oGdZ UGksOjJ9vVTm4xez2HXDUPxtwvo9dCG8rOlrm2qzX2oWkVcZGCgliyFj1LgfdAmqWmhx 0dniXw57mced5QTUVzlIPy0bQzkcmTtLbQNs7jI2dWOtJD2Tc1wVJhYawCSKnsKZPUIX Q6FanayGaVnebd13R4SQe42dDM1yEn3CIN1eqGpfzM0SnWRRsswlGxDfxGCuXuuHJHIA fM8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xKghRvpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020aa79290000000b0052b88948d54si14574417pfa.342.2022.07.27.11.21.30; Wed, 27 Jul 2022 11:21:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xKghRvpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238647AbiG0QhR (ORCPT + 99 others); Wed, 27 Jul 2022 12:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238468AbiG0Qfg (ORCPT ); Wed, 27 Jul 2022 12:35:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132844F1A7; Wed, 27 Jul 2022 09:27:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B7FAB821C5; Wed, 27 Jul 2022 16:27:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF883C433C1; Wed, 27 Jul 2022 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658939244; bh=TX+Sdx7vNb92kNhrkYvV7Qs/pncP26B1lxcQyV/riF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xKghRvpYgb/r7Hp5zuZmfCeVoYaEZ61wcFHqH/Bn5uxF7EAuv+GtvKzNerMsZwqjc 2UOSLiXLhuynHvd6T6/9mF+QTq6M9W3migTW2kw+6XCoZDGRS4nUc9f9Mbvv0thjC9 pBE7adO2Jp1vdaitrfWgPIM65lCJkVG7jrmHXWzo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Menzel , Luiz Augusto von Dentz , Marcel Holtmann , Harshit Mogalapalli Subject: [PATCH 4.19 51/62] Bluetooth: Fix bt_skb_sendmmsg not allocating partial chunks Date: Wed, 27 Jul 2022 18:11:00 +0200 Message-Id: <20220727161006.132537825@linuxfoundation.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220727161004.175638564@linuxfoundation.org> References: <20220727161004.175638564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luiz Augusto von Dentz commit 29fb608396d6a62c1b85acc421ad7a4399085b9f upstream. Since bt_skb_sendmmsg can be used with the likes of SOCK_STREAM it shall return the partial chunks it could allocate instead of freeing everything as otherwise it can cause problems like bellow. Fixes: 81be03e026dc ("Bluetooth: RFCOMM: Replace use of memcpy_from_msg with bt_skb_sendmmsg") Reported-by: Paul Menzel Link: https://lore.kernel.org/r/d7206e12-1b99-c3be-84f4-df22af427ef5@molgen.mpg.de BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215594 Signed-off-by: Luiz Augusto von Dentz Tested-by: Paul Menzel (Nokia N9 (MeeGo/Harmattan) Signed-off-by: Marcel Holtmann Cc: Harshit Mogalapalli Signed-off-by: Greg Kroah-Hartman --- include/net/bluetooth/bluetooth.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetooth.h @@ -423,8 +423,7 @@ static inline struct sk_buff *bt_skb_sen tmp = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom); if (IS_ERR(tmp)) { - kfree_skb(skb); - return tmp; + return skb; } len -= tmp->len;