Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp482202imn; Wed, 27 Jul 2022 11:26:00 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uiGsg3QhfrnfV2l3uAK3CuPvgDKYkodLe4P2KFQ+ZDP9BmC2+LKduXnnUPWnDWZpuBCTXI X-Received: by 2002:aa7:c485:0:b0:43c:c65c:e7d9 with SMTP id m5-20020aa7c485000000b0043cc65ce7d9mr2800733edq.301.1658946360646; Wed, 27 Jul 2022 11:26:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658946360; cv=none; d=google.com; s=arc-20160816; b=bVjL0UPM1qxPs3OVK3Mixahdy1UwKRfXo1BAyBkBhrnI1GDQCJm0JJAHl+eP9HYVMc h4Ii+cFl8mv0eLnSV7g0Feh3ZgMkQ8R9jRfCTjBCZLzjSlnm0/z1Ic67e2ot0iuXRqbB 9JoGQxNVya2tX9nwmWIU+ALsVh7LQeXEDm4ncp/8BoO8rm7wMN+2uEOj2INlJnFrODPw qyriXbrXrRZI0bOs7fOtZTW3qtYGmmMpWBuBgoGXr1V36GBiTBH/K8RJONbdgjEjOkjV eL9+IXWNVN62XKLUKmenYHSj3IDrjL4Qv7clXrcsv2iT83/BlsMlGcoDYpYLLJguSZOe +6DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=iD9R8IlOjFYb2nRhFRwZC44RD79swi9nBlsxP+VRxuY=; b=MxT1DJfIZxQXJZLZ7/q+QIK07tFL2+fIwrtjdQZoNKF9FIHx7qksnbQyHSMUbIvRZs 8TJMgC72LFRpiehCwIDvk6cRw6VhQjOatdQZ9vGNDRyT8Atfss31E+wtVXrTF52QBp6/ +wcW5G4/O5BKBsCsR6KKzqt5eEdm/mjV+7wZw5Z6tT15ein5WJPj+8cMoLJo2Ru1Hgdb 0PP0xbVA59TnOAAglGAlNiF3mK1uvnzaGcyuIDD4BcxF+dllNHXf3E2CB7xFC6kYTQI5 WUwu4qXzr/A8NLh3yw7oY6oBxYnEol1knHXeejdYygMYzr8yg2fSy/ny3nRMk4ifbm/x 3dRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc7-20020a1709071c0700b0072b7c700b99si19465887ejc.662.2022.07.27.11.25.35; Wed, 27 Jul 2022 11:26:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239342AbiG0QkE (ORCPT + 99 others); Wed, 27 Jul 2022 12:40:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239526AbiG0QjS (ORCPT ); Wed, 27 Jul 2022 12:39:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EC275A2F7 for ; Wed, 27 Jul 2022 09:28:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C7CCCB821C8 for ; Wed, 27 Jul 2022 16:28:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86838C433D7; Wed, 27 Jul 2022 16:28:49 +0000 (UTC) Date: Wed, 27 Jul 2022 12:28:47 -0400 From: Steven Rostedt To: Li Qiong Cc: Ingo Molnar , linux-kernel@vger.kernel.org, yuzhe@nfschina.com, renyu@nfschina.com, jiaming@nfschina.com Subject: Re: [PATCH] tracing: Do PTR_ERR() after IS_ERR() Message-ID: <20220727122847.6b00e29d@rorschach.local.home> In-Reply-To: <20220727153519.6697-1-liqiong@nfschina.com> References: <20220727153519.6697-1-liqiong@nfschina.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jul 2022 23:35:19 +0800 Li Qiong wrote: > Check IS_ERR() firstly, then do PTR_ERR(). Why? The code is fine as is. -- Steve