Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp484261imn; Wed, 27 Jul 2022 11:29:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s8A9KA1GjnKJKkmTf8G/D56ryslUN+HvQUC/FztbRAtrwlcn7mGmaYVl3IkiHCdMkfWVPZ X-Received: by 2002:a05:6402:501d:b0:437:e000:a898 with SMTP id p29-20020a056402501d00b00437e000a898mr24575009eda.265.1658946561189; Wed, 27 Jul 2022 11:29:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658946561; cv=none; d=google.com; s=arc-20160816; b=wZAKatCcKGmL73fq+U/wDK0wFYl7hUDQiNLBWZdol0OvMhUlIadWVEj7mCwn9g6zug Q32SgMdG3+yZqTyC+lcya/9sP+8PO45mu4vv0R1LJzylODrIhC0ituyDQG9G0np8KDlX lRUVKvLX5CABwE2falwYmIPLHuMCF877EZnDL28Fm0K12lqFRKf8FKyWO7B8LaGYPhqs vZhCIoglrdwBBj6ck5CbHYNd7AQcyUnJWCDWZNSkNw32W8yfulC27v4xJmiLdy3ctg38 pUhDGD9v2xtgfgz6RXjObe/F9X8ZxSDXVv7GKNBNCi/xu+9dwyr8Uvv1lUNgsG+qWkFl 3gmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=49JnqhFjk/StQIaHthapc811E38Ezgig6OHXpbtjeHo=; b=IhnkPYHzR8T/uZDSHE4HIbPS+0h68o9kojkScPc4d/C1qKC/ATsg20NlKiU3s5aWzS S3KvvSg2XL05LzfrH8Ybe6nAidJgMPiYPosCNLz2xH6EjcH6kleXx+5zDl5nmMabVneu qaoFLK8bQAUFnmTka0ZrEJo3N31ILsPXNUDh0xz/DabbbOQuR1eTD7naodWT9GcU8za8 aCGWjAdAJGA9xim9y/kG08XZMmyUBC/9G7Qo/1YWR/WBkPDLjYK79n5pMBgJia8KfbWM Q3t+vFii16szjBhnIa3SNBt4mxpRuvrZysSkJgYFONQJbbHOUvw1EA2JSflJ1C0oZm8d 5OdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DozhZZOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q14-20020a056402518e00b0043ac5ba36easi21065172edd.419.2022.07.27.11.28.56; Wed, 27 Jul 2022 11:29:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DozhZZOe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241176AbiG0RAj (ORCPT + 99 others); Wed, 27 Jul 2022 13:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241386AbiG0Q7h (ORCPT ); Wed, 27 Jul 2022 12:59:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411A3691DC; Wed, 27 Jul 2022 09:37:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6061261A91; Wed, 27 Jul 2022 16:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B9E4C433C1; Wed, 27 Jul 2022 16:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658939813; bh=7cxcXXPeU7k5QbBJxp1iNTuJ664l3od0idVpycl5vRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DozhZZOeB+yKbUVf+pNhdQdgwseZOwHl6Sphn4tYbeQiX2aW9KukjIm5bKaUviQmN RS294yjjipGwzGZLUFtl2unPAj4Ayy9PurqaHvvXDYTcUUH7jpNdw/A4GUA/7HMov2 51Xtgi0U9Uf08G4ptqRTTm/4t1o6tdNPCMsq6r2s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luiz Augusto von Dentz , Marcel Holtmann , Harshit Mogalapalli Subject: [PATCH 5.10 087/105] Bluetooth: Add bt_skb_sendmsg helper Date: Wed, 27 Jul 2022 18:11:13 +0200 Message-Id: <20220727161015.594866397@linuxfoundation.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220727161012.056867467@linuxfoundation.org> References: <20220727161012.056867467@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luiz Augusto von Dentz commit 38f64f650dc0e44c146ff88d15a7339efa325918 upstream. bt_skb_sendmsg helps takes care of allocation the skb and copying the the contents of msg over to the skb while checking for possible errors so it should be safe to call it without holding lock_sock. Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Marcel Holtmann Cc: Harshit Mogalapalli Signed-off-by: Greg Kroah-Hartman --- include/net/bluetooth/bluetooth.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetooth.h @@ -422,6 +422,34 @@ out: return NULL; } +/* Shall not be called with lock_sock held */ +static inline struct sk_buff *bt_skb_sendmsg(struct sock *sk, + struct msghdr *msg, + size_t len, size_t mtu, + size_t headroom, size_t tailroom) +{ + struct sk_buff *skb; + size_t size = min_t(size_t, len, mtu); + int err; + + skb = bt_skb_send_alloc(sk, size + headroom + tailroom, + msg->msg_flags & MSG_DONTWAIT, &err); + if (!skb) + return ERR_PTR(err); + + skb_reserve(skb, headroom); + skb_tailroom_reserve(skb, mtu, tailroom); + + if (!copy_from_iter_full(skb_put(skb, size), size, &msg->msg_iter)) { + kfree_skb(skb); + return ERR_PTR(-EFAULT); + } + + skb->priority = sk->sk_priority; + + return skb; +} + int bt_to_errno(u16 code); void hci_sock_set_flag(struct sock *sk, int nr);