Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp498928imn;
        Wed, 27 Jul 2022 11:55:52 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1uMf6Yg3t/OTydQaxqqugr6HVJBhdHRsGVhvpAUHUzI1Ep0WZHuOg9SiOLOMWEVS80CPSyb
X-Received: by 2002:a17:906:ef8b:b0:72b:58da:b115 with SMTP id ze11-20020a170906ef8b00b0072b58dab115mr18104891ejb.417.1658948151863;
        Wed, 27 Jul 2022 11:55:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1658948151; cv=none;
        d=google.com; s=arc-20160816;
        b=DSKQAl6N+8XoaxPhSA0YqNy9H7mgrVFMau49Nrb5xkWa6Ckrmhs0fZuhYhRhh3Jw/i
         YV1ELPen787UH9sMB+bSUPlqhBYsBZw+dP56dxPqj3tnjZ4lxxLNS49HUf4GATp6rkVl
         mL/5Nc+c6KJuT7kF4kPcdPVqbUkeSU2wK6pYfcYJiYrUWKjv98TND6S7tE3dknZDBaoE
         7SYzUfElEL5vyFp9hnwGvpLJj1ey638orJaBhb11MgU5uC0cBQDFWZqTpPHtLO4vb/vH
         7ayI0ggPy9EJa79ygCC8NeDJ4re+opu62mjqbmldfDoO6T7stjz8yLCc1rzOpf3sN44y
         +qug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date;
        bh=F9182ApktLXdgazGe9PE5d7k3dxEVixZ1W61fxTbz2g=;
        b=wfafNX/BqkWoAs2ixK7Ag9vJ6nSCsVqUF034qGgkjAzl0Qch0tQ9DwabTCgMJh/SJZ
         W/uNys36gRX9Qg6RNpGrORvWhsYHJZANoCG42CMdus1pkqodygqvu4JsT0QskVZPWghk
         HMufG45YINf2EZI+A8MJMNBuy7Pr+9BxRAnU14yKMGk51XiwWmfmHi1eMMOP3MLtc4b+
         t7nOdWg0agQcsmWddW9j/G7Ww0+pPydEbbQSVI5LBV02vELvplst4uem/PJeBljoGrzN
         n/FE1qExbMP6QRpZ7y6PkGinuaQ+BVNdLfq5n8GtfPPNUAicYnRSWYV0TrsYyHhqgNzF
         BJbg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id hc20-20020a170907169400b0072f1c604fd4si21169707ejc.713.2022.07.27.11.55.26;
        Wed, 27 Jul 2022 11:55:51 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S243265AbiG0SFn (ORCPT <rfc822;alizee.penel@gmail.com>
        + 99 others); Wed, 27 Jul 2022 14:05:43 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47250 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S242831AbiG0SFY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Jul 2022 14:05:24 -0400
Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id EAF7D501A2;
        Wed, 27 Jul 2022 10:09:33 -0700 (PDT)
Received: from [127.0.0.1] (localhost [127.0.0.1])
        by mail.enpas.org (Postfix) with ESMTPSA id 839EDFFCE8;
        Wed, 27 Jul 2022 17:09:31 +0000 (UTC)
Date:   Wed, 27 Jul 2022 19:09:28 +0200
From:   Max Staudt <max@enpas.org>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        michael@amarulasolutions.com,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        Jeroen Hofstee <jhofstee@victronenergy.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH v3 3/9] can: slcan: remove legacy infrastructure
Message-ID: <20220727190928.79ad62cf.max@enpas.org>
In-Reply-To: <20220726210217.3368497-4-dario.binacchi@amarulasolutions.com>
References: <20220726210217.3368497-1-dario.binacchi@amarulasolutions.com>
        <20220726210217.3368497-4-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dario,

This looks good to me now.

Thank you for cleaning up the legacy code :)


Reviewed-by: Max Staudt <max@enpas.org>