Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <13140020-8139-64f9-51b1-2b71c9b673af@amd.com>
Date:   Wed, 27 Jul 2022 18:37:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] drm/amd/display: Remove unused struct freesync_context
Content-Language: en-US
To:     =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        christian.koenig@amd.com, Xinhui.Pan@amd.com,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        mwen@igalia.com, andrealmeid@riseup.net,
        Isabella Basso <isabbasso@riseup.net>, magalilemes00@gmail.com,
        tales.aparecida@gmail.com
References: <20220727175033.453620-1-mairacanal@riseup.net>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220727175033.453620-1-mairacanal@riseup.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEdJUWtDQm5LL20vWlRaM01xMzJoczVxYlV3ME43eGNiU2RqVGRrYzgrcSto?=
 =?utf-8?B?dGJ2WjRWd0hwMmZydDcyZ3lKL1BYbXlxaVh2TjNiZXVlcmRGa3RNWEVsUzF3?=
 =?utf-8?B?RmdtUXhkcGJXQkkxdUV3K2VyUEVENThBOUJhU2phdzZyUVJpUmphV1c1cHA5?=
 =?utf-8?B?bitLM2IrMWJLeThpV0hydTBlZUNTRzFKRS9BUEV1VDl5MVVJUEtBT1pjaW1N?=
 =?utf-8?B?eFFzUmsrbmpsWDl0bmh2ZEpiYmovYkhleXA1SWE4QllDbFB5L2pCdDRUOWZB?=
 =?utf-8?B?WkRjRythZnBPZzU1NmRHaEJtUmZnMWt6Zms0OGhjdUM2NUkvK0ZuRlZlOXZW?=
 =?utf-8?B?K2U2UmlPY0dqN1JmTU4vYWhqMDRBRmNoOXlZcmQwOUhjUTQxZHkrZ3Nzd2Zq?=
 =?utf-8?B?ay9JSWN4WXpNdFFtblN3MUJ1TCszQUFacnN5V3VxSWg2YWRMT0wxR0JRTWdx?=
 =?utf-8?B?WEsxU1d2cVM5cGdvTXc3S2xITHhIMm9lNDRnd2NlMzVoVUF1RFZOcU4ySVpq?=
 =?utf-8?B?cmd3V1JtM3JLTVE0ZFhIT211TnBRRkJFTzUzZmdsbUJnT2FHZDJvM3dSM1A3?=
 =?utf-8?B?TGJOYXRNdEo1U3RBYURsc2ZHSDhYc05id0t2c29TeVlONE5TS3lxVk10UDEv?=
 =?utf-8?B?S3h4bVRWOC9lYjRvdG83czRRZnlqTUpqa0hiVFFaMDZKZTdXcTI5bGRYY3JQ?=
 =?utf-8?B?Rit5QjJjUHJSZjNDblo1MEhITnVkVmc5SUcxSUtSSC9YZjlRQnFOclV1VHhJ?=
 =?utf-8?B?NithL2ZkOFFoZnd3L1pJQll1MnREWmwyc1JUeXBNZGZ1YVNaVUwvTDh1MTdr?=
 =?utf-8?B?dHV4dDVSVWdPNDNEdFE5OHYzYmJBZHhNVDZ2VkdlYXEvRkw3RWRBTzVyRXor?=
 =?utf-8?B?bkdrK1F1cVNHNFNxVVRxcnlCNHVETFVVT1UySllLcGVOYTNtaG5tZVVOZndG?=
 =?utf-8?B?OWR0dzBqbkZ1ZDhRRzhtSGVmV3h1NmNiWjl1cG1iV0Fob0hQTU1yTS9FV29a?=
 =?utf-8?B?b2R3ckxFUFJxckw0bVR4dFZMM1dSWXdqa3BuRFZLWG82cXdsdDFvU0hOcGdw?=
 =?utf-8?B?VS9sODU2andDMHc1N3VBb29RRnk1eUM3UUs4WlZFTW9vbCttVEFNZUkwTTZx?=
 =?utf-8?B?ckJzdmV1MzRZSEtoMnpOT0lXd1ZxSkZMeHExWDRmaEk2K3NVWG4raS81SmVi?=
 =?utf-8?B?dmVUWXZFRjdhNUZNUEZkL1pOV1lpQTBwMjk5bjRFN2dmYVM3ajlORGFjbFJO?=
 =?utf-8?B?MU5pTnhWb0VkK0ZsbU9LVG5GZ2F0NTdycU5yaDNyQzQzdExpdnJnK2l5ZkhG?=
 =?utf-8?B?M1ZLU2pQRHl6aWtrNjN1K2dEb0JEamVoekpySHVqSkdDUDhTZ05WbDJQZjBO?=
 =?utf-8?B?WHhkVnIrTjY3cEtsenNNanFnTTRmZ1hWZ1VaZDNibHgzVUlpMGxTTy9oRFVS?=
 =?utf-8?B?SDRrVkplZlRvbUVsVGJmdTNXZ2hFQmdlUENjend4SkJ4OGZ1VVRQajYzdHo5?=
 =?utf-8?B?MHlNWUlmaDh4cXZscnA3SjlaV3pScFpYS2lNdWhMQTdyZmxaYnluSXV4amta?=
 =?utf-8?B?S3Y0a0IyRXJmZ2lla0xsWmp1QjhiQWw0QTIzdFpoUWk3dnhCYTRCRUhrTjlF?=
 =?utf-8?B?MnRHWVN0VHM3OTFEelBQRE12dUVQSlN4M0xteDhlTi9KK1ptZVlpclE4MjFR?=
 =?utf-8?B?WHhuMTVqSkowbFpkOFIySVVBZk1XaXllQXVuaUg1aGdtcU9JYlY4b0FvaFND?=
 =?utf-8?B?cHVWVFFCdml0RCtvd2E5aTN5Vm9rTlp2RkwyeHFWKzJXZytmYW56Tlg2RUxW?=
 =?utf-8?B?K1QrN2xPR1JlVUhoNzY0Yzlvc1UwSytLNFNmMjlUY2JFY09oWGRPdi9Ia3Y0?=
 =?utf-8?B?bllEaVJsd01GRFY4VFNnUkVjZnFtVDNoaE1nbk94UjlQVlhVOGdjcjdRL3dH?=
 =?utf-8?B?bW9iUi9waVpONnRHWmhOMWw5VzZ3citIN1pBQVdKbll3R3ZUT1l2d1dIb0Fx?=
 =?utf-8?B?cVlha1NsbUs4dVJTNUFmZTNkM1NtNTJXWW4rd1c4bldVbjMxUGR2NGlLZXdi?=
 =?utf-8?B?MkxkNVExZlNHd1FySXBmRW1kcVZtR2JyWDRabEcvRTZVdVJWbUJ3WDMvdkNj?=
 =?utf-8?Q?QetL77iaz97s5drp3hW0NptCl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2f1369-0cc7-4950-5bc7-08da7020a3aa
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 22:37:51.5024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qrnAVd5ruCQJDpB8QvVGh9uOQgAhG3QlpTmqhsQbaFyz6AvKrMMEu1gV11p3D9OX/+ukVi1LWhyLEhzVESyaRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5391
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-07-27 13:50, Maíra Canal wrote:
> All references to struct freesync_context were removed, so remove the
> struct freesync_context itself and its entry on struct dc_stream_state.
> 
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> ---
>   drivers/gpu/drm/amd/display/dc/dc_stream.h | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_stream.h b/drivers/gpu/drm/amd/display/dc/dc_stream.h
> index c3d97206ed89..f87f852d4829 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_stream.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_stream.h
> @@ -48,11 +48,6 @@ struct dc_stream_status {
>   	bool is_abm_supported;
>   };
>   
> -// TODO: References to this needs to be removed..
> -struct freesync_context {
> -	bool dummy;
> -};
> -
>   enum hubp_dmdata_mode {
>   	DMDATA_SW_MODE,
>   	DMDATA_HW_MODE
> @@ -184,9 +179,6 @@ struct dc_stream_state {
>   	struct rect src; /* composition area */
>   	struct rect dst; /* stream addressable area */
>   
> -	// TODO: References to this needs to be removed..
> -	struct freesync_context freesync_ctx;
> -
>   	struct audio_info audio_info;
>   
>   	struct dc_info_packet hdr_static_metadata;

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

and applied to amd-staging-drm-next.

Thanks
Siqueira