Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220709015033.38326-1-yangjihong1@huawei.com> <20220709015033.38326-3-yangjihong1@huawei.com>
In-Reply-To: <20220709015033.38326-3-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 27 Jul 2022 16:42:12 -0700
Message-ID: <CAM9d7civBT2-u0C1rK6OvSLAT7fzXRb8ku4xaHbF3wbUv+m1rw@mail.gmail.com>
Subject: Re: [RFC v3 02/17] perf kwork: Add irq kwork record support
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Paul Clarke <pc@us.ibm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 8, 2022 at 6:53 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Record interrupt events irq:irq_handler_entry & irq_handler_exit
>
> Test cases:
>
>  # perf kwork record -o perf_kwork.date -- sleep 1
>   [ perf record: Woken up 0 times to write data ]
>   [ perf record: Captured and wrote 0.556 MB perf_kwork.date ]
>   #
>   # perf evlist -i perf_kwork.date
>   irq:irq_handler_entry
>   irq:irq_handler_exit
>   dummy:HG
>   # Tip: use 'perf evlist --trace-fields' to show fields for tracepoint events
>   #
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> ---
>  tools/perf/Documentation/perf-kwork.txt |  2 +-
>  tools/perf/builtin-kwork.c              | 15 ++++++++++++++-
>  tools/perf/util/kwork.h                 |  1 +
>  3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-kwork.txt b/tools/perf/Documentation/perf-kwork.txt
> index dc1e36da57bb..57bd5fa7d5c9 100644
> --- a/tools/perf/Documentation/perf-kwork.txt
> +++ b/tools/perf/Documentation/perf-kwork.txt
> @@ -32,7 +32,7 @@ OPTIONS
>
>  -k::
>  --kwork::
> -       List of kwork to profile
> +       List of kwork to profile (irq, etc)
>
>  -v::
>  --verbose::
> diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c
> index f3552c56ede3..a26b7fde1e38 100644
> --- a/tools/perf/builtin-kwork.c
> +++ b/tools/perf/builtin-kwork.c
> @@ -25,7 +25,20 @@
>  #include <linux/time64.h>
>  #include <linux/zalloc.h>
>
> +const struct evsel_str_handler irq_tp_handlers[] = {
> +       { "irq:irq_handler_entry", NULL, },
> +       { "irq:irq_handler_exit",  NULL, },
> +};
> +
> +static struct kwork_class kwork_irq = {
> +       .name           = "irq",
> +       .type           = KWORK_CLASS_IRQ,
> +       .nr_tracepoints = 2,

Nit: I don't think it's gonna change frequently but
it'd be better to use ARRAY_SIZE(irq_tp_handlers)
for future changes.

Thanks,
Namhyung


> +       .tp_handlers    = irq_tp_handlers,
> +};
> +
>  static struct kwork_class *kwork_class_supported_list[KWORK_CLASS_MAX] = {
> +       [KWORK_CLASS_IRQ]       = &kwork_irq,
>  };
>
>  static void setup_event_list(struct perf_kwork *kwork,
> @@ -132,7 +145,7 @@ int cmd_kwork(int argc, const char **argv)
>         OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
>                     "dump raw trace in ASCII"),
>         OPT_STRING('k', "kwork", &kwork.event_list_str, "kwork",
> -                  "list of kwork to profile"),
> +                  "list of kwork to profile (irq, etc)"),
>         OPT_BOOLEAN('f', "force", &kwork.force, "don't complain, do it"),
>         OPT_END()
>         };
> diff --git a/tools/perf/util/kwork.h b/tools/perf/util/kwork.h
> index 6950636aab2a..f1d89cb058fc 100644
> --- a/tools/perf/util/kwork.h
> +++ b/tools/perf/util/kwork.h
> @@ -13,6 +13,7 @@
>  #include <linux/bitmap.h>
>
>  enum kwork_class_type {
> +       KWORK_CLASS_IRQ,
>         KWORK_CLASS_MAX,
>  };
>
> --
> 2.30.GIT
>