Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0aaf7458536129fd6fe81417ab43f6dc6b4d4b3.camel@intel.com>
Subject: Re: [PATCH v7 037/102] KVM: x86/mmu: Track shadow MMIO value/mask
 on a per-VM basis
From:   Kai Huang <kai.huang@intel.com>
To:     Isaku Yamahata <isaku.yamahata@gmail.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Date:   Thu, 28 Jul 2022 12:48:35 +1200
In-Reply-To: <20220727232058.GB3669189@ls.amr.corp.intel.com>
References: <cover.1656366337.git.isaku.yamahata@intel.com>
         <242df8a7164b593d3702b9ba94889acd11f43cbb.1656366338.git.isaku.yamahata@intel.com>
         <20220719084737.GU1379820@ls.amr.corp.intel.com>
         <c9d7f7e0665358f7352e95a7028a8779fd0531c6.camel@intel.com>
         <20220727232058.GB3669189@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-07-27 at 16:20 -0700, Isaku Yamahata wrote:
> > KVM has a global enable_mmio_caching boolean, and I think we should hon=
or it
> > here (in this patch) by doing below first:
> >=20
> > =C2=A0	if (enabling_mmio_caching)
> > =C2=A0		mmio_value =3D 0;
>=20
> This function already includes "if (!enable_mmio_caching) mmio_value =3D =
0;" in
> the beginning. (But not in this hunk, though).=C2=A0 So this patch honors=
 the
> kernel
> module parameter.

Yeah I missed that. Thanks.

--=20
Thanks,
-Kai